Original issue is https://www.drupal.org/project/upgrade_status/issues/3213533
The issue is still reproducible since the following commit https://git.drupalcode.org/project/upgrade_status/-/commit/f9528e7677481... completely reverts the fix because forces the default value (https://git.drupalcode.org/project/upgrade_status/-/blob/8.x-3.x/src/For...):
$this->database->version()
A patch fixing the issue and incompatibility with MSSQL is attached.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | 3301036.patch | 9.53 KB | gábor hojtsy |
| #2 | Pantheon-mysql-version.png | 212.06 KB | greg.1.anderson |
| #2 | Pantheon-mysql-proxy-version.png | 227.92 KB | greg.1.anderson |
| 3213533-fix-incorrect-mariadb-version-d8.patch | 9.67 KB | Sergei Churilo |
Comments
Comment #2
greg.1.anderson commentedThis patch works perfectly on Pantheon, correcting the error in the reported mysql version.
Screenshot: Upgrade status without patch, incorrectly showing Mysql Proxy version instead of the version of the Mysql server on Pantheon:
Screenshot: Upgrade status with patch, correctly showing Mysql server version on Pantheon:
I tried running this locally to confirm that the mysql version was reported correctly,
MySQL or Percona Server 8.0.29both with and without this patch, in my case. Screenshots omitted.Strangely enough, when I tried to apply this patch with cweagans/composer-patches, and again manually with `patch`, I had to manually rename src/Util/CorrectDbServerVersion.php to src/Util/DatabaseServerMetadataExtractor.php. I did not have this problem on Pantheon, and I am unsure what the cause was on the Mac. Use caution when applying.
I am uncertain about the cause of the test failures.
Comment #3
greg.1.anderson commentedcore_version_requirementis stillcore_version_requirement: ^8 || ^9, so the Drupal 10 failure is expected.Checked #3277147: Missing space in UI text, which is RTBC, but only tests PHP 7.3 / D9.4, which is passing here, so I am going to guess that the PHP 7.4 failures are also expected. Setting to RTBC.
Comment #4
gábor hojtsyThanks for testing!
Unfortunately as https://www.drupal.org/node/264883/qa shows the 7.4 environment has been failing since April for some reason, more precisely started failing between April 7 and April 14. There were no commits around that time in the project, so it must be an external change.
Also the Drupal 10 environment is not expected to pass yet, as the project does not work on Drupal 10 yet. I removed that environment from the daily tests, not sure why it was there.
I'll see if I can do something about that fail first and then come back here.
Comment #5
gábor hojtsyResolved PHP 7.4 and 8.0 fails in #3302828: Upgrade Status tests fail on PHP 7.4 and PHP 8.0 due to lack of rules.neon used from phpstan-drupal while 8.1 was failing due to #3274645: Deprecated function: Return type of GuzzleHttp\Cookie\CookieJar when running Upgrade Status on PHP 8.1 which was resolved thanks to @neclimdul. So sent this for a retest on all environments. The code looks fine on code review. I especially like the concentration of version cleanup in the class.
Comment #6
gábor hojtsyRerolled since it did not apply.
Comment #8
gábor hojtsyOk, passes the tests too, and looks good on a code review, so let's get this in. Yay, thanks all!
Comment #9
greg.1.anderson commentedYay! Thanks!