Drupal 10 compatibility

Last commit looks good, setting as RTBC.

Found a few small things.

Ideally we would also, like, run the tests on Drupal 9 and 10 before committing this, but I think that will require intervention from the maintainer.

Thank you all the for patches and discussion.

This patch is small enough so I can happily say "out of scope changes are welcome", plus locking down return types is really good.

This weekend
1) I will be running the tests.
2) We are altering "core_version_requirement", I am going to trigger a new 3.1 release.

If anyone has "internal business" rules and would like a 4.0 release ... just say the word.

Thank again

After verifying this works on Drupal10

I have released version 4.

Thanks again

After discussion with Phéna Proxima and Jakob Perry on slack ...

there is a discussion points about not bumping up to a 4.0.x release

but making the next release "3.1.0"

I am just leaving a breadcrumb to a summary of the reasons why...

https://medium.com/jakob-on-drupal/dont-go-making-major-version-changes-...

Ok, I am persuaded, thanks for the nudge

"Who this, new release."

Currently there's no more release shown on the module page. Is this due to this issue?

The module is marked as "unsupported" at /admin/modules/update

MAJOR version when you make incompatible API changes
MINOR version when you add functionality in a backwards compatible manner
PATCH version when you make backwards compatible bug fixes

https://semver.org

So from what I can see if you are dropping support for drupal 8, this is a major change.

Looking forward to stable version of 4.x.x

I have updated the home page

"3.0.1 Stable release covered by the Drupal Security Team released 5 June 2021
Works with Drupal: ^8 || ^9"

I hope that meets your needs.

This is what i am currently seeing:

Somewhere, where you specify the "supported_branches" of the project, it is wrong, it is marked as "3.1." and the latest version is 3.0.1, that's why it gives the (Unsupported error) in Drupal update process.

title => string (18) "Simple Google Maps"
short_name => string (11) "simple_gmap"
type => string (14) "project_module"
supported_branches => string (4) "3.1."
composer_namespace => string (18) "drupal/simple_gmap"
project_status => string (9) "published"
link => string (42) "https://www.drupal.org/project/simple_gmap"
terms => string (0) ""
releases => array (13)
last_fetch => integer 1668695464

@martin107 Do you have any plan to release the Drupal 10-compatible version?