Automated Drupal 10 compatibility fixes [#3299531]

Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects

Patches will periodically be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD10" tag from the issue to stop the bot from posting updates.

The patches will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

Accept automated patches until this issue is closed
If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot patches. The bot will still post new patches then if there is a change in the new generated patch compared to the patch that the bot posted last. Those changes are then up to humans to integrate.
Leave open but stop new automated patches.
If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated patches, remove the "ProjectUpdateBotD10" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.
Close it and don't use it
If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated patches will be posted here.

If the issue is reopened, then new automated patches will be posted.

If you are using another issue(s) to work on Drupal 10 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.

Comment	File	Size	Author
#8	xnumber.1.x-dev.rector.patch	15.94 KB	project update bot
#8	interdiff-last-bot.6664737.txt	422 bytes	project update bot
#5	Screenshot from 2022-07-29 11-02-11.png	15.48 KB	omkar-pd
#2	xnumber.1.x-dev.rector.patch	15.75 KB	project update bot

Issue fork xnumber-3299531

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

3299531-minimum-core-version changes, plain diff MR !6 / changes, plain diff MR !2
Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

23 July 2022 at 19:08

Project Update Bot created an issue. See original summary.

Comment #2

project update bot commented 23 July 2022 at 19:09

Status:

Active

» Needs review

Status	File	Size
new	xnumber.1.x-dev.rector.patch	15.75 KB

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module this patch makes this module compatible with Drupal 10! 🎉
This patch updates the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #139

This patch was created using these packages:

mglaman/phpstan-drupal: 1.1.24
palantirnet/drupal-rector: 0.13.0

Comment #3

Bushra Shaikh commented 28 July 2022 at 07:20

Assigned:	Unassigned	» Bushra Shaikh
Issue summary:	View changes

Comment #4

Bushra Shaikh commented 29 July 2022 at 04:31

Assigned:

Bushra Shaikh

» Unassigned

Comment #5

omkar-pd commented 29 July 2022 at 06:18

Issue tags:

+Drupal 10 porting day

Status	File	Size
new	Screenshot from 2022-07-29 11-02-11.png	15.48 KB

This module is Compatible with d10 as per upgrade status and tested this patch on the d10 instance as well and the module is working perfectly fine. Can be moved to RTBC.

Comment #6

drugan commented 30 July 2022 at 07:31

Status:

Needs review

» Needs work

Hi, guys!

Thanks for contribution. Please make sure all the following errors are fixed so phpstan will not complain at least at --level 0:

test.me ~$ php ./bin/phpstan analyze --level 0 web/modules/contrib/xnumber/
Note: Using configuration file /home/uladmin/public_html/ts-ink.ee/phpstan.neon.
 9/9 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ ----------------------------------------------------------------------------------------------------------------------------- 
  Line   src/Tests/XnumberFieldTest.php                                                                                               
 ------ ----------------------------------------------------------------------------------------------------------------------------- 
  28     Return type mixed of method Drupal\xnumber\Tests\XnumberFieldTest::setUp() is not covariant with return type void of method  
         PHPUnit\Framework\TestCase::setUp().                                                                                         
  79     Call to deprecated method assertEqual() of class Drupal\Tests\BrowserTestBase:                                               
         in drupal:8.0.0 and is removed from drupal:10.0.0. Use                                                                       
           $this->assertEquals() instead.                                                                                             
  87     Call to deprecated method drupalPostForm() of class Drupal\Tests\BrowserTestBase:                                            
         in drupal:9.1.0 and is removed from drupal:10.0.0. Use                                                                       
           $this->submitForm() instead.                                                                                               
  88     Call to deprecated method assertRaw() of class Drupal\Tests\BrowserTestBase:                                                 
         in drupal:8.2.0 and is removed from drupal:10.0.0. Use                                                                       
           $this->assertSession()->responseContains() instead.                                                                        
  95     Call to deprecated method drupalPostForm() of class Drupal\Tests\BrowserTestBase:                                            
         in drupal:9.1.0 and is removed from drupal:10.0.0. Use                                                                       
           $this->submitForm() instead.                                                                                               
  96     Call to deprecated method assertRaw() of class Drupal\Tests\BrowserTestBase:                                                 
         in drupal:8.2.0 and is removed from drupal:10.0.0. Use                                                                       
           $this->assertSession()->responseContains() instead.                                                                        
  103    Call to deprecated method drupalPostForm() of class Drupal\Tests\BrowserTestBase:                                            
         in drupal:9.1.0 and is removed from drupal:10.0.0. Use                                                                       
           $this->submitForm() instead.                                                                                               
  104    Call to deprecated method assertRaw() of class Drupal\Tests\BrowserTestBase:                                                 
         in drupal:8.2.0 and is removed from drupal:10.0.0. Use                                                                       
           $this->assertSession()->responseContains() instead.                                                                        
  111    Call to deprecated method drupalPostForm() of class Drupal\Tests\BrowserTestBase:                                            
         in drupal:9.1.0 and is removed from drupal:10.0.0. Use                                                                       
           $this->submitForm() instead.                                                                                               
  112    Call to deprecated method assertRaw() of class Drupal\Tests\BrowserTestBase:                                                 
         in drupal:8.2.0 and is removed from drupal:10.0.0. Use                                                                       
           $this->assertSession()->responseContains() instead.                                                                        
  149    Call to deprecated method drupalPostForm() of class Drupal\Tests\BrowserTestBase:                                            
         in drupal:9.1.0 and is removed from drupal:10.0.0. Use                                                                       
           $this->submitForm() instead.                                                                                               
  150    Access to an undefined property Drupal\xnumber\Tests\XnumberFieldTest::$url.                                                 
  152    Call to deprecated method assertText() of class Drupal\Tests\BrowserTestBase:                                                
         in drupal:8.2.0 and is removed from drupal:10.0.0. Use                                                                       
           - $this->assertSession()->responseContains() for non-HTML responses,                                                       
             like XML or Json.                                                                                                        
           - $this->assertSession()->pageTextContains() for HTML responses. Unlike                                                    
             the deprecated assertText(), the passed text should be HTML decoded,                                                     
             exactly as a human sees it in the browser.                                                                               
  189    Call to deprecated method drupalPostForm() of class Drupal\Tests\BrowserTestBase:                                            
         in drupal:9.1.0 and is removed from drupal:10.0.0. Use                                                                       
           $this->submitForm() instead.                                                                                               
  192    Call to deprecated method assertRaw() of class Drupal\Tests\BrowserTestBase:                                                 
         in drupal:8.2.0 and is removed from drupal:10.0.0. Use                                                                       
           $this->assertSession()->responseContains() instead.                                                                        
  235    Call to deprecated method drupalPostForm() of class Drupal\Tests\BrowserTestBase:                                            
         in drupal:9.1.0 and is removed from drupal:10.0.0. Use                                                                       
           $this->submitForm() instead.                                                                                               
  236    Call to deprecated method assertRaw() of class Drupal\Tests\BrowserTestBase:                                                 
         in drupal:8.2.0 and is removed from drupal:10.0.0. Use                                                                       
           $this->assertSession()->responseContains() instead.                                                                        
  253    Call to deprecated method drupalPostForm() of class Drupal\Tests\BrowserTestBase:                                            
         in drupal:9.1.0 and is removed from drupal:10.0.0. Use                                                                       
           $this->submitForm() instead.                                                                                               
  254    Call to deprecated method assertRaw() of class Drupal\Tests\BrowserTestBase:                                                 
         in drupal:8.2.0 and is removed from drupal:10.0.0. Use                                                                       
           $this->assertSession()->responseContains() instead.                                                                        
  293    Call to deprecated method drupalPostForm() of class Drupal\Tests\BrowserTestBase:                                            
         in drupal:9.1.0 and is removed from drupal:10.0.0. Use                                                                       
           $this->submitForm() instead.                                                                                               
  294    Call to deprecated method assertRaw() of class Drupal\Tests\BrowserTestBase:                                                 
         in drupal:8.2.0 and is removed from drupal:10.0.0. Use                                                                       
           $this->assertSession()->responseContains() instead.                                                                        
  324    Call to deprecated method assertRaw() of class Drupal\Tests\BrowserTestBase:                                                 
         in drupal:8.2.0 and is removed from drupal:10.0.0. Use                                                                       
           $this->assertSession()->responseContains() instead.                                                                        
  340    Call to deprecated method drupalPostForm() of class Drupal\Tests\BrowserTestBase:                                            
         in drupal:9.1.0 and is removed from drupal:10.0.0. Use                                                                       
           $this->submitForm() instead.                                                                                               
  341    Call to deprecated method assertRaw() of class Drupal\Tests\BrowserTestBase:                                                 
         in drupal:8.2.0 and is removed from drupal:10.0.0. Use                                                                       
           $this->assertSession()->responseContains() instead.                                                                        
  358    Call to deprecated method drupalPostForm() of class Drupal\Tests\BrowserTestBase:                                            
         in drupal:9.1.0 and is removed from drupal:10.0.0. Use                                                                       
           $this->submitForm() instead.                                                                                               
  359    Call to deprecated method assertRaw() of class Drupal\Tests\BrowserTestBase:                                                 
         in drupal:8.2.0 and is removed from drupal:10.0.0. Use                                                                       
           $this->assertSession()->responseContains() instead.                                                                        
  394    Call to deprecated method drupalPostForm() of class Drupal\Tests\BrowserTestBase:                                            
         in drupal:9.1.0 and is removed from drupal:10.0.0. Use                                                                       
           $this->submitForm() instead.                                                                                               
  395    Call to deprecated method assertRaw() of class Drupal\Tests\BrowserTestBase:                                                 
         in drupal:8.2.0 and is removed from drupal:10.0.0. Use                                                                       
           $this->assertSession()->responseContains() instead.                                                                        
  489    Call to an undefined method Drupal\xnumber\Tests\XnumberFieldTest::drupalPostAjaxForm().                                     
  496    Call to an undefined method Drupal\xnumber\Tests\XnumberFieldTest::drupalPostAjaxForm().                                     
  497    Call to deprecated method drupalPostForm() of class Drupal\Tests\BrowserTestBase:                                            
         in drupal:9.1.0 and is removed from drupal:10.0.0. Use                                                                       
           $this->submitForm() instead.                                                                                               
  502    Call to deprecated method assertRaw() of class Drupal\Tests\BrowserTestBase:                                                 
         in drupal:8.2.0 and is removed from drupal:10.0.0. Use                                                                       
           $this->assertSession()->responseContains() instead.                                                                        
  503    Call to deprecated method assertRaw() of class Drupal\Tests\BrowserTestBase:                                                 
         in drupal:8.2.0 and is removed from drupal:10.0.0. Use                                                                       
           $this->assertSession()->responseContains() instead.                                                                        
  515    Call to an undefined method Drupal\xnumber\Tests\XnumberFieldTest::drupalPostAjaxForm().                                     
  520    Call to an undefined method Drupal\xnumber\Tests\XnumberFieldTest::drupalPostAjaxForm().                                     
  521    Call to deprecated method drupalPostForm() of class Drupal\Tests\BrowserTestBase:                                            
         in drupal:9.1.0 and is removed from drupal:10.0.0. Use                                                                       
           $this->submitForm() instead.                                                                                               
  527    Call to deprecated method assertRaw() of class Drupal\Tests\BrowserTestBase:                                                 
         in drupal:8.2.0 and is removed from drupal:10.0.0. Use                                                                       
           $this->assertSession()->responseContains() instead.                                                                        
  566    Call to deprecated method drupalPostForm() of class Drupal\Tests\BrowserTestBase:                                            
         in drupal:9.1.0 and is removed from drupal:10.0.0. Use                                                                       
           $this->submitForm() instead.                                                                                               
  568    Call to deprecated method assertNoRaw() of class Drupal\Tests\BrowserTestBase:                                               
         in drupal:8.2.0 and is removed from drupal:10.0.0. Use                                                                       
           $this->assertSession()->responseNotContains() instead.                                                                     
  569    Call to deprecated method assertNoRaw() of class Drupal\Tests\BrowserTestBase:                                               
         in drupal:8.2.0 and is removed from drupal:10.0.0. Use                                                                       
           $this->assertSession()->responseNotContains() instead.                                                                     
  571    Call to deprecated method assertRaw() of class Drupal\Tests\BrowserTestBase:                                                 
         in drupal:8.2.0 and is removed from drupal:10.0.0. Use                                                                       
           $this->assertSession()->responseContains() instead.                                                                        
  574    Call to deprecated method assertFieldById() of class Drupal\Tests\BrowserTestBase:                                           
         in drupal:8.2.0 and is removed from drupal:10.0.0. Use                                                                       
           $this->assertSession()->fieldExists() or                                                                                   
           $this->assertSession()->buttonExists() or                                                                                  
           $this->assertSession()->fieldValueEquals() instead.                                                                        
  747    Call to deprecated method assertFieldByName() of class Drupal\Tests\BrowserTestBase:                                         
         in drupal:8.2.0 and is removed from drupal:10.0.0. Use                                                                       
           $this->assertSession()->fieldExists() or                                                                                   
           $this->assertSession()->buttonExists() or                                                                                  
           $this->assertSession()->fieldValueEquals() instead.                                                                        
  754    Call to deprecated method drupalPostForm() of class Drupal\Tests\BrowserTestBase:                                            
         in drupal:9.1.0 and is removed from drupal:10.0.0. Use                                                                       
           $this->submitForm() instead.                                                                                               
  755    Access to an undefined property Drupal\xnumber\Tests\XnumberFieldTest::$url.                                                 
  758    Call to deprecated method assertText() of class Drupal\Tests\BrowserTestBase:                                                
         in drupal:8.2.0 and is removed from drupal:10.0.0. Use                                                                       
           - $this->assertSession()->responseContains() for non-HTML responses,                                                       
             like XML or Json.                                                                                                        
           - $this->assertSession()->pageTextContains() for HTML responses. Unlike                                                    
             the deprecated assertText(), the passed text should be HTML decoded,                                                     
             exactly as a human sees it in the browser.                                                                               
  769    Call to deprecated method assertRaw() of class Drupal\Tests\BrowserTestBase:                                                 
         in drupal:8.2.0 and is removed from drupal:10.0.0. Use                                                                       
           $this->assertSession()->responseContains() instead.                                                                        
  770    Call to deprecated method assertRaw() of class Drupal\Tests\BrowserTestBase:                                                 
         in drupal:8.2.0 and is removed from drupal:10.0.0. Use                                                                       
           $this->assertSession()->responseContains() instead.                                                                        
  771    Call to deprecated method assertRaw() of class Drupal\Tests\BrowserTestBase:                                                 
         in drupal:8.2.0 and is removed from drupal:10.0.0. Use                                                                       
           $this->assertSession()->responseContains() instead.                                                                        
  772    Call to deprecated method assertRaw() of class Drupal\Tests\BrowserTestBase:                                                 
         in drupal:8.2.0 and is removed from drupal:10.0.0. Use                                                                       
           $this->assertSession()->responseContains() instead.                                                                        
  773    Call to deprecated method assertRaw() of class Drupal\Tests\BrowserTestBase:                                                 
         in drupal:8.2.0 and is removed from drupal:10.0.0. Use                                                                       
           $this->assertSession()->responseContains() instead.                                                                        
  775    Call to deprecated method assertText() of class Drupal\Tests\BrowserTestBase:                                                
         in drupal:8.2.0 and is removed from drupal:10.0.0. Use                                                                       
           - $this->assertSession()->responseContains() for non-HTML responses,                                                       
             like XML or Json.                                                                                                        
           - $this->assertSession()->pageTextContains() for HTML responses. Unlike                                                    
             the deprecated assertText(), the passed text should be HTML decoded,                                                     
             exactly as a human sees it in the browser.                                                                               
  778    Call to deprecated method assertText() of class Drupal\Tests\BrowserTestBase:                                                
         in drupal:8.2.0 and is removed from drupal:10.0.0. Use                                                                       
           - $this->assertSession()->responseContains() for non-HTML responses,                                                       
             like XML or Json.                                                                                                        
           - $this->assertSession()->pageTextContains() for HTML responses. Unlike                                                    
             the deprecated assertText(), the passed text should be HTML decoded,                                                     
             exactly as a human sees it in the browser.                                                                               
  788    Call to deprecated method assertNoRaw() of class Drupal\Tests\BrowserTestBase:                                               
         in drupal:8.2.0 and is removed from drupal:10.0.0. Use                                                                       
           $this->assertSession()->responseNotContains() instead.                                                                     
  789    Call to deprecated method assertNoRaw() of class Drupal\Tests\BrowserTestBase:                                               
         in drupal:8.2.0 and is removed from drupal:10.0.0. Use                                                                       
           $this->assertSession()->responseNotContains() instead.                                                                     
  790    Call to deprecated method assertNoRaw() of class Drupal\Tests\BrowserTestBase:                                               
         in drupal:8.2.0 and is removed from drupal:10.0.0. Use                                                                       
           $this->assertSession()->responseNotContains() instead.                                                                     
  791    Call to deprecated method assertNoRaw() of class Drupal\Tests\BrowserTestBase:                                               
         in drupal:8.2.0 and is removed from drupal:10.0.0. Use                                                                       
           $this->assertSession()->responseNotContains() instead.                                                                     
 ------ ----------------------------------------------------------------------------------------------------------------------------- 


                                                                                                                        
 [ERROR] Found 57 errors

Comment #7

kristen pol

she/her

English

Santa Cruz, CA, USA

commented 31 July 2022 at 03:09

Thanks everyone for participating in porting day!

@drugan Thank you for your detailed report on remaining deprecations that need to be addressed.

Comment #8

project update bot commented 22 August 2022 at 21:45

Status:

Needs work

» Needs review

Status	File	Size
new	interdiff-last-bot.6664737.txt	422 bytes
new	xnumber.1.x-dev.rector.patch	15.94 KB

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module this patch makes this module compatible with Drupal 10! 🎉
This patch updates the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #145

This patch was created using these packages:

mglaman/phpstan-drupal: 1.1.25
palantirnet/drupal-rector: 0.13.1

Comment #9

jaydev bhatt commented 26 August 2022 at 10:13

I'll work on this issue as a part of Drupal 10 Global Porting Day.

Comment #10

jaydev bhatt commented 26 August 2022 at 11:21

Status:

Needs review

» Reviewed & tested by the community

need to check moew rhis moving to NR

Comment #11

jaydev bhatt commented 26 August 2022 at 14:26

Assigned:	Unassigned	» jaydev bhatt
Status:	Reviewed & tested by the community	» Needs review

Comment #12

project update bot commented 18 October 2022 at 16:22

Issue summary:

View changes

Updating bot issue summary.See #3313904: Update project bot templates for RTBC status support and human interaction tips

Comment #13

tyler36 commented 18 November 2022 at 02:34

Issue summary:

View changes

This module is dependent on drupal:readmehelp which must also be D10 compatable.

See Readmehelp Drupal 10 compatibility fixes

Comment #14

kristen pol

she/her

English

Santa Cruz, CA, USA

commented 18 November 2022 at 07:02

Assigned:	jaydev bhatt	» Unassigned
Related issues:		+#3289247: Automated Drupal 10 compatibility fixes

Working during porting day.

Thanks for the info. Adding #3289247: Automated Drupal 10 compatibility fixes as related issue.

Comment #15

mvonfrie commented 24 February 2023 at 18:23

The dependency on readmehelp (which is not yet Drupal 10 ready) will be removed by #3133932: Remove dependencies on readmehelp and help module.

Comment #16

24 February 2023 at 18:31

mvonfrie opened merge request !2

Comment #17

mvonfrie commented 24 February 2023 at 19:06

Pending tasks:

PHPstan `--level 0` fixes

Note: Using configuration file /var/www/html/phpstan.neon.
9/9 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

------ ------------------------------------------------------------------------------------------
Line src/Tests/XnumberFieldTest.php
------ ------------------------------------------------------------------------------------------
150 Access to an undefined property Drupal\xnumber\Tests\XnumberFieldTest::$url.
489 Call to an undefined method Drupal\xnumber\Tests\XnumberFieldTest::drupalPostAjaxForm().
496 Call to an undefined method Drupal\xnumber\Tests\XnumberFieldTest::drupalPostAjaxForm().
515 Call to an undefined method Drupal\xnumber\Tests\XnumberFieldTest::drupalPostAjaxForm().
520 Call to an undefined method Drupal\xnumber\Tests\XnumberFieldTest::drupalPostAjaxForm().
756 Access to an undefined property Drupal\xnumber\Tests\XnumberFieldTest::$url.
------ ------------------------------------------------------------------------------------------

Resolve depending issues

#3133932: Remove dependencies on readmehelp and help module

Update core version requirement

Increase minimum core version requirement to ^9.3 || ^10 as 9.3 is the first version supporting PHP 8.1, the minimum for Drupal 10.

Comment #18

mvonfrie commented 24 February 2023 at 19:06

Assigned:

Unassigned

» mvonfrie

Comment #19

mvonfrie commented 24 February 2023 at 19:07

Status:

Needs review

» Needs work

Comment #20

mvonfrie commented 27 February 2023 at 15:57

The Call to an undefined method Drupal\Tests\xnumber\Functional\XnumberFieldTest::drupalPostAjaxForm() occurrences require a major rewrite of the tests, see

Instructions for converting a Simpletest web test

drupalPostAjaxForm() doesn't exist on BrowserTestBase and can usually be replaced with drupalPostForm() this does mean a loss of pseudo-JavaScript coverage, so ideally a follow up should be created to add proper JavaScript coverage using WebdriverTestBase
drupalPostForm() is deprecated and will be removed in Drupal 10

In addition I found used but uninitialized variables in the tests, which also needs to be fixed.

Comment #21

drugan commented 3 March 2023 at 10:31

Version:

8.x-1.x-dev

» 2.0.x-dev

@mvonfrie

Let's make it compatible with the ^9.5 || ^10 versions.

You can commit --amend and then push --force into your MR branch.

Comment #22

11 May 2023 at 11:31

shivam_tiwari made their first commit to this issue’s fork.

Comment #23

11 May 2023 at 11:32

shivam_tiwari opened merge request !6

Comment #24

shivam_tiwari commented 11 May 2023 at 11:33

Status:

Needs work

» Needs review

Comment #25

drugan commented 11 May 2023 at 14:38

Status:

Needs review

» Needs work

Hi @shivam_tiwari,

The readmehelp dependency is already fixed on the 2.0.x branch. Additionally, to make the module fully compatible with the core's ^10 version wee need to rewrite the XnumberFieldTest.php. See #17 comment.

Because we have the Extended number field types so at the very least we need guarantee the Drupal Core functionality for these types.

For the beginning you can just copy two files below into our Tests folder. Then replace 'integer', 'decimal', 'float' field types in the files for our 'xinteger', 'xdecimal' and 'xfloat'.

The same with the field widget type: 'number' -> 'xnumber'. After that just create a list of what we've extended in the core's functionality and add specific test methods for that in the files:

https://git.drupalcode.org/project/drupal/-/blob/10.1.x/core/modules/fie...

Comment #26

30 June 2023 at 09:25

mkalkbrenner made their first commit to this issue’s fork.

Comment #27

drugan commented 24 August 2023 at 15:52

The test is failing:

drugan@my-xnumber-web:/var/www/html$ vendor/bin/phpunit -c web/core/ web/modules/contrib/xnumber/
PHPUnit 9.6.11 by Sebastian Bergmann and contributors.

Testing /var/www/html/web/modules/contrib/xnumber
EREEEE                                                              6 / 6 (100%)E

Time: 00:10.036, Memory: 4.00 MB

There were 6 errors:

1) Drupal\Tests\xnumber\Functional\XnumberFieldTest::testNumberIntegerField
Exception: Drupal\Tests\BrowserTestBase::$defaultTheme is required. See https://www.drupal.org/node/3083055, which includes recommendations on which theme to use.

/var/www/html/web/core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php:427
/var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:556
/var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:367
/var/www/html/web/modules/contrib/xnumber/tests/src/Functional/XnumberFieldTest.php:29
/var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:728

2) Drupal\Tests\xnumber\Functional\XnumberFieldTest::testNumberDecimalField
Exception: Drupal\Tests\BrowserTestBase::$defaultTheme is required. See https://www.drupal.org/node/3083055, which includes recommendations on which theme to use.

/var/www/html/web/core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php:427
/var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:556
/var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:367
/var/www/html/web/modules/contrib/xnumber/tests/src/Functional/XnumberFieldTest.php:29
/var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:728

3) Drupal\Tests\xnumber\Functional\XnumberFieldTest::testNumberFloatField
Exception: Drupal\Tests\BrowserTestBase::$defaultTheme is required. See https://www.drupal.org/node/3083055, which includes recommendations on which theme to use.

/var/www/html/web/core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php:427
/var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:556
/var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:367
/var/www/html/web/modules/contrib/xnumber/tests/src/Functional/XnumberFieldTest.php:29
/var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:728

4) Drupal\Tests\xnumber\Functional\XnumberFieldTest::testNumberFormatter
Exception: Drupal\Tests\BrowserTestBase::$defaultTheme is required. See https://www.drupal.org/node/3083055, which includes recommendations on which theme to use.

/var/www/html/web/core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php:427
/var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:556
/var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:367
/var/www/html/web/modules/contrib/xnumber/tests/src/Functional/XnumberFieldTest.php:29
/var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:728

5) Drupal\Tests\xnumber\Functional\XnumberFieldTest::testCreateNumberFloatField
Exception: Drupal\Tests\BrowserTestBase::$defaultTheme is required. See https://www.drupal.org/node/3083055, which includes recommendations on which theme to use.

/var/www/html/web/core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php:427
/var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:556
/var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:367
/var/www/html/web/modules/contrib/xnumber/tests/src/Functional/XnumberFieldTest.php:29
/var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:728

6) Drupal\Tests\xnumber\Functional\XnumberFieldTest::testCreateNumberDecimalField
Exception: Drupal\Tests\BrowserTestBase::$defaultTheme is required. See https://www.drupal.org/node/3083055, which includes recommendations on which theme to use.

/var/www/html/web/core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php:427
/var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:556
/var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:367
/var/www/html/web/modules/contrib/xnumber/tests/src/Functional/XnumberFieldTest.php:29
/var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:728

--

There was 1 risky test:

1) Drupal\Tests\xnumber\Functional\XnumberFieldTest::testNumberIntegerField
This test did not perform any assertions

/var/www/html/web/core/tests/Drupal/Tests/Listeners/DrupalListener.php:65
/var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:452
/var/www/html/vendor/phpunit/phpunit/src/Framework/TestSuite.php:684
/var/www/html/vendor/phpunit/phpunit/src/Framework/TestSuite.php:684
/var/www/html/vendor/phpunit/phpunit/src/TextUI/TestRunner.php:651
/var/www/html/vendor/phpunit/phpunit/src/TextUI/Command.php:144
/var/www/html/vendor/phpunit/phpunit/src/TextUI/Command.php:97

ERRORS!
Tests: 6, Assertions: 0, Errors: 6, Risky: 1.

Comment #28

drugan commented 24 August 2023 at 19:37

Assigned:

mvonfrie

» drugan

Comment #29

5 September 2023 at 19:31

drugan committed b3c60cfe on 2.0.x authored by mvonfrie

Issue #3299531 by mvonfrie, shivam_tiwari, omkar-pd, drugan: Automated...

Comment #30

drugan commented 5 September 2023 at 19:46

I've ran functional and javascript test on 9.4 and 10.1.2 versions.

I am not sure if there is any sense to merge these changes into 8.x version of the module? If it's true please someone merge upstream and run both tests on the latest 8.x core version to verify that is working there too.

I am going to make 2.0.0-beta1 release tomorrow.

Comment #31

drugan commented 6 September 2023 at 09:22

Status:

Needs work

» Fixed

Done.

Thanks everyone!

Comment #32

6 September 2023 at 14:35

drugan closed merge request !6

Comment #33

drugan commented 13 September 2023 at 12:59

Status:

Fixed

» Closed (fixed)

Automated Drupal 10 compatibility fixes

Problem/Motivation

Proposed resolution

Remaining tasks

Providing feedback

Issue fork xnumber-3299531

Comments

Drupal 10 Compatibility

Debug info

Drupal 10 Compatibility

Debug info

PHPstan --level 0 fixes

Resolve depending issues

Update core version requirement

Related issues

PHPstan `--level 0` fixes