Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects

Patches will periodically be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD10" tag from the issue to stop the bot from posting updates.

The patches will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot patches. The bot will still post new patches then if there is a change in the new generated patch compared to the patch that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated patches, remove the "ProjectUpdateBotD10" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.

CommentFileSizeAuthor
#11 webdam-d10-3299480-11.patch11.17 KBprimsi
#11 webdam-d10-3299480-11.interdiff.txt1.11 KBprimsi
#9 webdam-d10-3299480-9.patch10.49 KBprimsi
#9 webdam-d10-3299480-9.interdiff.txt1.46 KBprimsi
#6 webdam-d10-3299480-6.patch9.02 KBprimsi
#6 webdam-d10-3299480-6.interdiff.txt4.13 KBprimsi
#5 webdam-d10-3299480-5.patch8.72 KBprimsi
#5 webdam-d10-3299480-5.interdiff.txt5.83 KBprimsi
#4 webdam-d10-3299480-4.patch4.44 KBprimsi
#2 webdam.2.x-dev.rector.patch726 bytesproject update bot

Issue fork webdam-3299480

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Project Update Bot created an issue. See original summary.

project update bot’s picture

project update bot commented
Status: Active » Needs review
StatusFileSize
new webdam.2.x-dev.rector.patch726 bytes

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module, even with this patch, this module is not yet compatible with Drupal 10.

Currently Drupal Rector, version 0.13.0, cannot fix all Drupal 10 compatibility problems.

This patch does not update the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #139

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 1.1.24
  2. palantirnet/drupal-rector: 0.13.0
project update bot’s picture

project update bot commented
Issue summary: View changes

Updating bot issue summary.See #3313904: Update project bot templates for RTBC status support and human interaction tips

primsi’s picture

primsi commented
Issue summary: View changes
StatusFileSize
new webdam-d10-3299480-4.patch4.44 KB

Updated patch, but we need to fix upstream first. cweagans/php-webdam-client is in archive mode and composer fails on Guzzle version

primsi’s picture

primsi commented
StatusFileSize
new webdam-d10-3299480-5.interdiff.txt5.83 KB
new webdam-d10-3299480-5.patch8.72 KB
primsi’s picture

primsi commented
StatusFileSize
new webdam-d10-3299480-6.interdiff.txt4.13 KB
new webdam-d10-3299480-6.patch9.02 KB

Namespace change and fixed a remaining .once.

Primsi opened merge request !1

dineshkumarbollu’s picture

dineshkumarbollu commented

Hi Primsi

I Review the MR!1 while running upgarde_status drush command to check the D10 compatible issues found 1 error.

can you please check

vendor/bin/drush upgrade_status:analyze webdam
[notice] Processing /var/www/html/vbd9/web/modules/contrib/webdam-3299480.

================================================================================
Media: Webdam, --
Scanned on Wed, 05/10/2023 - 14:22

FILE:
web/modules/contrib/webdam-3299480/modules/webdam_sns/src/EventSubscriber/Notifi
cationSubscriber.php

STATUS LINE MESSAGE
--------------------------------------------------------------------------------
Check manually 109 Relying on entity queries to check access by default is
deprecated in drupal:9.2.0 and an error will be thrown from
drupal:10.0.0. Call
\Drupal\Core\Entity\Query\QueryInterface::accessCheck() with
TRUE or FALSE to specify whether access should be checked.
--------------------------------------------------------------------------------

primsi’s picture

primsi commented
StatusFileSize
new webdam-d10-3299480-9.interdiff.txt1.46 KB
new webdam-d10-3299480-9.patch10.49 KB

As far as I understand, that's not an issue in this case, because we are processing a notification.

Attaching a patch, that does not show the saved user password in the config form.

Primsi closed merge request !1

primsi’s picture

primsi commented
StatusFileSize
new webdam-d10-3299480-11.interdiff.txt1.11 KB
new webdam-d10-3299480-11.patch11.17 KB

As per discussion, adding the description and supporting test connection with config stored password.

  • Berdir committed 84163f01 on 2.x authored by Primsi 
    Issue #3299480 by Primsi, Project Update Bot, Berdir: Automated Drupal...
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Fixed

#8 was correct, we need that access check, we just didn't test SNS notifications on D10. It's also a problem in bynder, which we apparently haven't updated yet. I'll create an issue yet.

Fixed on commit:

diff --git a/modules/webdam_sns/src/EventSubscriber/NotificationSubscriber.php b/modules/webdam_sns/src/EventSubscriber/NotificationSubscriber.php
index a0fcbc6..c28b04b 100644
--- a/modules/webdam_sns/src/EventSubscriber/NotificationSubscriber.php
+++ b/modules/webdam_sns/src/EventSubscriber/NotificationSubscriber.php
@@ -109,6 +109,7 @@ class NotificationSubscriber implements EventSubscriberInterface {
       $mid = $query
         ->condition($source_field_condition)
         ->range(0, 1)
+        ->accessCheck(FALSE)
         ->execute();
 
       if ($mid) {

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.