Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects

Patches will periodically be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD10" tag from the issue to stop the bot from posting updates.

The patches will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot patches. The bot will still post new patches then if there is a change in the new generated patch compared to the patch that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated patches, remove the "ProjectUpdateBotD10" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.

CommentFileSizeAuthor
#29 automated-drupal-10-compatibility-fixes-3299447-29.patch1.26 KBsilverham
#28 automated-drupal-10-compatibility-fixes-3299447-28.patch1.17 KBsilverham
#14 interdiff_d10patched-drupal-10-compatibility-3299447-14.txt532 bytesmaxmendez
#14 drupal-10-compatibility-3299447-14.patch1.17 KBmaxmendez
#9 d10patched.patch1.23 KBpub497
#4 view_fieldsets.png43.69 KBatul_ghate
#2 views_fieldsets.3.x-dev.rector.patch1.17 KBproject update bot

Issue fork views_fieldsets-3299447

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Project Update Bot created an issue. See original summary.

project update bot’s picture

project update bot commented
Status: Active » Needs review
StatusFileSize
new views_fieldsets.3.x-dev.rector.patch1.17 KB

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module this patch makes this module compatible with Drupal 10! 🎉
This patch updates the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #139

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 1.1.24
  2. palantirnet/drupal-rector: 0.13.0
atul_ghate’s picture

atul_ghate commented
Assigned: Unassigned » atul_ghate
Issue summary: View changes

Hi,
i will review this patch.

atul_ghate’s picture

atul_ghate commented
Assigned: atul_ghate » Unassigned
StatusFileSize
new view_fieldsets.png43.69 KB

Verified patch #2 on Drupal 10 Patch applied successfully with zero recent log messages and looks good to me.

Testing Steps:

1. Install drupal 10
2. clone the branch Vidyard (8.x-3.x) on drupal 9 and checked deprecated code uisng upgrade status module
3. applied patch #2 and again checked deprecated code on drupal 9
4. and then installed module on drupal 10
5. check module installed sucsessfully or not
6. checked recent log message

The module has been successfully installed on Drupal 10, it can now be moved to RTBC.

project update bot’s picture

project update bot commented
Issue summary: View changes

Updating bot issue summary.See #3313904: Update project bot templates for RTBC status support and human interaction tips

smustgrave’s picture

smustgrave commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

All changes flagged by upgrade status have been addressed. Looks good to go.

maxmendez’s picture

maxmendez commented

Tested and seems to work without problems.

bcobin’s picture

bcobin commented

Is there any possibility to post a Drupal 10-ready version? I am completely, utterly lost when it comes to the whole patching thing in Drupal 9|10, which is especially nasty insofar as Drupal 9 is reaching end-of-life in less than a year. I'm racing to get sites done and this is a real speed-bump for me.

Thanks in advance for any help - much appreciated!

pub497’s picture

pub497 commented
StatusFileSize
new d10patched.patch1.23 KB

Here is an updated patch that applies to the latest 8.x-3.x-dev branch

abhinavk’s picture

abhinavk commented

Patch #2 is not getting applied for me. I have checked with Patch #9, it is working fine without error for Drupal 9 (9.5.7) and Drupal 10 (10.0.3).

RTBC +1

marcom2021’s picture

marcom2021 commented

Patch #9 fails with Drupal 10.0.9

codebymikey made their first commit to this issue’s fork.

codebymikey opened merge request !2

maxmendez’s picture

maxmendez commented
StatusFileSize
new drupal-10-compatibility-3299447-14.patch1.17 KB
new interdiff_d10patched-drupal-10-compatibility-3299447-14.txt532 bytes

Updated patch for latest version of branch 8.x-3.x-dev.

chucksimply’s picture

chucksimply commented

Can we get the latest patch merged?!? Need this in d10 asap.

marcaddeo’s picture

marcaddeo commented

Also need this to get merged to D10 compatibility.

As a workaround, you can apply this patch but you will have to make sure to add this to your composer.json:

        "preferred-install": {
            "drupal/views_fieldsets": "source"
        }

However... If you use Pantheon, or another service which runs the composer install command for you, the --prefer-dist flag will override that workaround and you won't be able to patch the .info.yml file because Drupal adds packaging information to that file (https://www.drupal.org/project/drupalorg/issues/3066468).

So... Would be really nice to get this merged!

codebymikey’s picture

codebymikey commented

@marcaddeo, I haven't tested this myself, but this composer plugin might help https://packagist.org/packages/orakili/composer-drupal-info-file-patch-h...

That being said, it definitely shouldn't be used as an excuse to delay this issue being merged and released.

It's a little cumbersome to work with issue forks at the moment.

marcaddeo’s picture

marcaddeo commented

@codebymikey: THANK YOU! That's super helpful.

I was just 85% through re-hosting a fork of this repo on GitHub with the patches applied to get around this, but your solution is easier haha.

maxmendez’s picture

maxmendez commented

Another temporal option is the plugin https://packagist.org/packages/mglaman/composer-drupal-lenient

chucksimply’s picture

chucksimply commented
Status: Reviewed & tested by the community » Needs work

Used Lenient as mentioned in #19... looks like the best solution for patching D9 modules to D10.

Although patch #14 didn't apply to 8.x-3.4 on core 10.0.9.

marcaddeo’s picture

marcaddeo commented
Status: Needs work » Reviewed & tested by the community

@chucksimply: The patch applies cleanly. The problem is Drupal adds packaging info to the info file when downloading the dist version.

Checkout #16 and #17 for more info and solutions.

maxmendez’s picture

maxmendez commented

Hi @chucksimply,

The patch requires the dev version.

Under composer require:

    "require": {
         "drupal/views_fieldsets": "3.x-dev@dev",

And under drupal-lenient:

        "drupal-lenient": {
            "allowed-list": [
                "drupal/pdf",
                "drupal/views_fieldsets"
            ]
        }

Note: the last one if you use Lenient.

chucksimply’s picture

chucksimply commented

Okay, switched to dev and worked fine. Thanks

nickrhymes’s picture

nickrhymes commented

Have also just given this a test. The patch from #14 applies and works correctly with 10.0.9 for both the dev and dist versions.

Please can this be rolled in to a release as we are awaiting this for a D10 project.

Thanks.

dinazaur’s picture

dinazaur commented

+1 RTBC

jday’s picture

jday commented

+1 RTBC

thidd made their first commit to this issue’s fork.

silverham’s picture

silverham commented
StatusFileSize
new automated-drupal-10-compatibility-fixes-3299447-28.patch1.17 KB

Compose wouldn't apply #14, so regenerated the same patch (no changes).

silverham’s picture

silverham commented
StatusFileSize
new automated-drupal-10-compatibility-fixes-3299447-29.patch1.26 KB

Oops patch only appiles for dev version due to different info.yml, attached patch for 3.4 module version for composer runs.

matas.k’s picture

matas.k commented

#29 works.

smustgrave’s picture

smustgrave commented
Version: 8.x-3.x-dev » 4.0.x-dev
Parent issue: » #3384586: Meta 4.0.0 release

smustgrave closed merge request !2

smustgrave reopened merge request !2

smustgrave’s picture

smustgrave commented
Status: Reviewed & tested by the community » Fixed

Okay had some issues because 8.x-3.4 tag was ahead of the 8.x-3.x dev branch.

Merged into 4.0.x but will ask if some testing could be done and posted on https://www.drupal.org/project/views_fieldsets/issues/3384586#comment-15... before a release is made

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.