Problem/Motivation

Found working on #3245770: Create a service to composer install via package_manager from Automatic Updates
Drupal 9.4 and above require php 7.4 for new installs and recommends php 7.4

AutoUpdates requires 7.4 #3293866: Update minimum PHP version requirement for Automatic Updates to 7.4

So to use Automatic Updates's sub module you would need to require php 7.4.

You could probably just change the automated testing to use 7.4 instead of 7.3 on drupalCi

Proposed resolution

  1. Run automated tests on 7.4 instead of 7.3
  2. Require PHP 7.4 in the Composer json

I think you could get with just 1) as long you just add drupal/automatic_updates to require-dev for testing. Because maybe some users of Project Browser just want browsing and not the actual composer installs and a lot of hosting won't support installs on Production anyways.

Remaining tasks

  • ✅ File an issue about this project
  • ☐ Manual Testing
  • ☐ Code Review
  • ☐ Accessibility Review
  • ☐ Automated tests needed/written?

Issue fork project_browser-3299285

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

tedbow created an issue. See original summary.

bnjmnm made their first commit to this issue’s fork.

bnjmnm opened merge request !212

bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented
Status: Active » Needs review

I'm fine requiring a minimum of 7.4. 7.3 isn't supported anymore and PB won't get into core until 10.0 at the earliest, which doesn't support 7.3 at all. If there's agreement, the MR that bumps the requirement up is there waiting for ya.

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Parent issue: » #3300309: [Meta] Use Package Manger(From AutoUpdates) API to install via Composer
fjgarlin’s picture

fjgarlin commented

Happy with the change. It makes sense to require at least 7.4. We cannot use some of the new features of PHP7.4+ as tests fail, like in this issue or here #3296494: Dynamic properties deprecated in PHP8.2, where I was trying to add a type to a public class property (ie: public bool $is_covered;).

I'd mark it RTBC but I don't know what needs to change for tests to be set as default to 7.4 in the CI tool.

bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented

Looks like the default test version is in the project config on D.O.

I made that change and based on 👆 it looks like the default PHP for testing is now 7.4.

fjgarlin’s picture

fjgarlin commented
Status: Needs review » Reviewed & tested by the community

In that case and based on the green pass, marking this as RTBC.
I guess this is now affecting all issues (testing on 7.4) even if this is not yet merged, which I guess should be ok if we merge it soon :-)

tim.plunkett made their first commit to this issue’s fork.

  • tim.plunkett committed 12d3ff9 on 1.0.x authored by bnjmnm 
    Issue #3299285 by bnjmnm: Change automated tests to use 7.4 and maybe...
tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Reviewed & tested by the community » Fixed

Merged, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.