Problem/Motivation
found in #3277830: [DrupalCon] Automatic Updates beta test result by @AjitS
The temporary directory write issue in the container. It seems like the automatic_updates module tried to create a directory in the /tmp directory in the container and it was not able to do that. As a workaround, I changed the temporary directory for the Drupal site in settings.php using
$settings['file_temp_path'] = 'sites/default/files/tmp';
Proposed resolution
We should at least see what a problem like this would look like to the user. If there error is very hard to understand we might want create a validator
I suspect we probably will need to add some kind of check in Package Manager to ensure that the temporary directory (or "staging root" in Package Manager's jargon) is writable, to prevent folks from running into this error without recourse.
Remaining tasks
User interface changes
API changes
Data model changes
Issue fork automatic_updates-3299093
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
tedbowComment #4
phenaproximaComment #7
phenaproximaThis is now blocked by #3303143: Move getStagingRoot() to PathLocator.
Comment #8
phenaproximaBlocker is in.
Comment #9
phenaproximaUn-assigning from myself. HEAD is finally in a state where we can proceed with this issue in a more focused way.
The code itself looks like it works, but will need automated test coverage.
Comment #10
phenaproximaComment #11
kunal.sachdev commentedComment #12
phenaproximaThis looks pretty good to me. I think we could do some light rephrasing of certain parts to make it (IMHO) clearer, but I really don't have much to complain about here. Nice work!
Comment #13
kunal.sachdev commentedComment #14
phenaproximaGreat work, @kunal.sachdev. I changed some very minor nitpicks (mostly comments) and I think this is ready to go. Assigning to @tedbow for final review and commit.
Comment #16
tedbowGreat work! Thanks! 🎉