Problem/Motivation

found in #3277830: [DrupalCon] Automatic Updates beta test result by @AjitS

The temporary directory write issue in the container. It seems like the automatic_updates module tried to create a directory in the /tmp directory in the container and it was not able to do that. As a workaround, I changed the temporary directory for the Drupal site in settings.php using
$settings['file_temp_path'] = 'sites/default/files/tmp';

Proposed resolution

We should at least see what a problem like this would look like to the user. If there error is very hard to understand we might want create a validator

I suspect we probably will need to add some kind of check in Package Manager to ensure that the temporary directory (or "staging root" in Package Manager's jargon) is writable, to prevent folks from running into this error without recourse.

Remaining tasks

User interface changes

API changes

Data model changes

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

tedbow created an issue. See original summary.

tedbow credited AjitS.

tedbow’s picture

phenaproxima’s picture

Assigned: Unassigned » phenaproxima

kunal.sachdev made their first commit to this issue’s fork.

phenaproxima’s picture

Title: Add validation that staging directory is writable » [PP-1] Add validation that staging directory is writable
Status: Active » Postponed
Related issues: +#3303143: Move getStagingRoot() to PathLocator
phenaproxima’s picture

Title: [PP-1] Add validation that staging directory is writable » Add validation that staging directory is writable
Status: Postponed » Needs work

Blocker is in.

phenaproxima’s picture

Assigned: phenaproxima » Unassigned
Issue tags: +Needs tests

Un-assigning from myself. HEAD is finally in a state where we can proceed with this issue in a more focused way.

The code itself looks like it works, but will need automated test coverage.

phenaproxima’s picture

Component: Code » Package Manager
kunal.sachdev’s picture

Status: Needs work » Needs review
phenaproxima’s picture

Category: Bug report » Feature request
Status: Needs review » Needs work
Issue tags: -Needs tests

This looks pretty good to me. I think we could do some light rephrasing of certain parts to make it (IMHO) clearer, but I really don't have much to complain about here. Nice work!

kunal.sachdev’s picture

Status: Needs work » Needs review
phenaproxima’s picture

Assigned: Unassigned » tedbow
Status: Needs review » Reviewed & tested by the community

Great work, @kunal.sachdev. I changed some very minor nitpicks (mostly comments) and I think this is ready to go. Assigning to @tedbow for final review and commit.

  • tedbow committed ae931e4 on 8.x-2.x authored by phenaproxima
    Issue #3299093 by phenaproxima, kunal.sachdev, AjitS: Add validation...
tedbow’s picture

Status: Reviewed & tested by the community » Fixed

Great work! Thanks! 🎉

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.