Problem/Motivation

So #3299093: Add validation that staging directory is writable necessitates that we be able to access the staging root even without a stage having been created. That means we gotta move getStagingRoot() to the path locator.

This is actually a good thing because it simplifies a bunch of stuff. It's a bad thing because the movement of that method has outsized implications on the rest of the code (which is why, indeed, it's a good idea to move it in the first place).

API changes

PathLocator will get a new getStagingRoot() method.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

phenaproxima created an issue. See original summary.

phenaproxima’s picture

Assigned: phenaproxima » tedbow
Status: Active » Needs review

There's a lot of work to do, so I think this would be a good start. Assigning to @tedbow for review.

tedbow’s picture

Assigned: tedbow » Unassigned
Status: Needs review » Reviewed & tested by the community

  • phenaproxima committed 2fd5f31 on 8.x-2.x
    Issue #3303143 by phenaproxima: Move getStagingRoot() to PathLocator
    
phenaproxima’s picture

Assigned: Unassigned » tedbow
Status: Reviewed & tested by the community » Fixed

Merged into 8.x-2.x. Thanks!

phenaproxima’s picture

Assigned: tedbow » Unassigned

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.