Automated Drupal 10 compatibility fixes [#3298089]

Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects

Patches will periodically be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD10" tag from the issue to stop the bot from posting updates.

The patches will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

Accept automated patches until this issue is closed
If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot patches. The bot will still post new patches then if there is a change in the new generated patch compared to the patch that the bot posted last. Those changes are then up to humans to integrate.
Leave open but stop new automated patches.
If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated patches, remove the "ProjectUpdateBotD10" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.
Close it and don't use it
If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated patches will be posted here.

If the issue is reopened, then new automated patches will be posted.

If you are using another issue(s) to work on Drupal 10 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.

Comment	File	Size	Author
#11	Screenshot 2022-11-19 at 13.55.37.png	9.23 KB	fathima.asmat
#11	Screenshot 2022-11-19 at 13.55.19.png	19.01 KB	fathima.asmat
#11	Screenshot 2022-11-19 at 13.55.11.png	77.81 KB	fathima.asmat
#11	Screenshot 2022-11-19 at 13.55.06.png	43.08 KB	fathima.asmat
#11	Screenshot 2022-11-19 at 13.54.57.png	66.84 KB	fathima.asmat
#11	Screenshot 2022-11-19 at 13.54.53.png	34.98 KB	fathima.asmat
#11	interdiff_9-11.txt	1.33 KB	fathima.asmat
#11	site_settings-d10-compatibility-3298089-11.patch	8.67 KB	fathima.asmat
#9	site_settings.1.x-dev.rector.patch	6.94 KB	project update bot
#9	interdiff-last-bot.6659740.txt	368 bytes	project update bot
#7	site_settings.png	118.09 KB	atul_ghate
#5	interdiff_3_4.txt	518 bytes	fathima.asmat
#5	site_settings-d10-compatibility-3298089-4.patch	23.9 KB	fathima.asmat
#3	site_settings-d10-compatibility-3298089-3.patch	24.1 KB	fathima.asmat
#2	site_settings.1.x-dev.rector.patch	6.68 KB	project update bot

Comments

Comment #1

18 July 2022 at 18:29

Project Update Bot created an issue. See original summary.

Comment #2

project update bot commented 18 July 2022 at 18:29

Status:

Active

» Needs review

Status	File	Size
new	site_settings.1.x-dev.rector.patch	6.68 KB

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module, even with this patch, this module is not yet compatible with Drupal 10.

Currently Drupal Rector, version 0.13.0, cannot fix all Drupal 10 compatibility problems.

This patch does not update the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #139

This patch was created using these packages:

mglaman/phpstan-drupal: 1.1.24
palantirnet/drupal-rector: 0.13.0

Comment #3

fathima.asmat commented 31 July 2022 at 17:09

Issue summary:

View changes

Status	File	Size
new	site_settings-d10-compatibility-3298089-3.patch	24.1 KB

I have tested the rector patch on D9.4 an dD10-alpha6 and it doesn't resolve all the compatibility issues. It also just replaces deprecated methods with static service methods instead of using dependency injections where relevant.

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 59   Call to deprecated method assertRaw() of class              
                    Drupal\Tests\BrowserTestBase. Deprecated in drupal:8.2.0 and
                    is removed from drupal:10.0.0. Use                          
                    $this->assertSession()->responseContains() instead.         
--------------------------------------------------------------------------------
Check manually 60   Call to deprecated method assertRaw() of class              
                    Drupal\Tests\BrowserTestBase. Deprecated in drupal:8.2.0 and
                    is removed from drupal:10.0.0. Use                          
                    $this->assertSession()->responseContains() instead.         
--------------------------------------------------------------------------------
Check manually 63   Call to deprecated method assertText() of class             
                    Drupal\Tests\BrowserTestBase. Deprecated in drupal:8.2.0 and
                    is removed from drupal:10.0.0. Use -                        
                    $this->assertSession()->responseContains() for non-HTML     
                    responses, like XML or Json. -                              
                    $this->assertSession()->pageTextContains() for HTML         
                    responses. Unlike the deprecated assertText(), the passed   
                    text should be HTML decoded, exactly as a human sees it in  
                    the browser.                                                
--------------------------------------------------------------------------------
Check manually 66   Call to deprecated method assertText() of class             
                    Drupal\Tests\BrowserTestBase. Deprecated in drupal:8.2.0 and
                    is removed from drupal:10.0.0. Use -                        
                    $this->assertSession()->responseContains() for non-HTML     
                    responses, like XML or Json. -                              
                    $this->assertSession()->pageTextContains() for HTML         
                    responses. Unlike the deprecated assertText(), the passed   
                    text should be HTML decoded, exactly as a human sees it in  
                    the browser.                                                
--------------------------------------------------------------------------------
Check manually 69   Call to deprecated method assertText() of class             
                    Drupal\Tests\BrowserTestBase. Deprecated in drupal:8.2.0 and
                    is removed from drupal:10.0.0. Use -                        
                    $this->assertSession()->responseContains() for non-HTML     
                    responses, like XML or Json. -                              
                    $this->assertSession()->pageTextContains() for HTML         
                    responses. Unlike the deprecated assertText(), the passed   
                    text should be HTML decoded, exactly as a human sees it in  
                    the browser.                                                
--------------------------------------------------------------------------------
Check manually 70   Call to deprecated method assertText() of class             
                    Drupal\Tests\BrowserTestBase. Deprecated in drupal:8.2.0 and
                    is removed from drupal:10.0.0. Use -                        
                    $this->assertSession()->responseContains() for non-HTML     
                    responses, like XML or Json. -                              
                    $this->assertSession()->pageTextContains() for HTML         
                    responses. Unlike the deprecated assertText(), the passed   
                    text should be HTML decoded, exactly as a human sees it in  
                    the browser.                                                
--------------------------------------------------------------------------------
Check manually 73   Call to deprecated method assertText() of class             
                    Drupal\Tests\BrowserTestBase. Deprecated in drupal:8.2.0 and
                    is removed from drupal:10.0.0. Use -                        
                    $this->assertSession()->responseContains() for non-HTML     
                    responses, like XML or Json. -                              
                    $this->assertSession()->pageTextContains() for HTML         
                    responses. Unlike the deprecated assertText(), the passed   
                    text should be HTML decoded, exactly as a human sees it in  
                    the browser.                                                
--------------------------------------------------------------------------------
Check manually 74   Call to deprecated method assertText() of class             
                    Drupal\Tests\BrowserTestBase. Deprecated in drupal:8.2.0 and
                    is removed from drupal:10.0.0. Use -                        
                    $this->assertSession()->responseContains() for non-HTML     
                    responses, like XML or Json. -                              
                    $this->assertSession()->pageTextContains() for HTML         
                    responses. Unlike the deprecated assertText(), the passed   
                    text should be HTML decoded, exactly as a human sees it in  
                    the browser.                                                
--------------------------------------------------------------------------------
Check manually 77   Call to deprecated method assertText() of class             
                    Drupal\Tests\BrowserTestBase. Deprecated in drupal:8.2.0 and
                    is removed from drupal:10.0.0. Use -                        
                    $this->assertSession()->responseContains() for non-HTML     
                    responses, like XML or Json. -                              
                    $this->assertSession()->pageTextContains() for HTML         
                    responses. Unlike the deprecated assertText(), the passed   
                    text should be HTML decoded, exactly as a human sees it in  
                    the browser.                                                
--------------------------------------------------------------------------------
Check manually 80   Call to deprecated method assertText() of class             
                    Drupal\Tests\BrowserTestBase. Deprecated in drupal:8.2.0 and
                    is removed from drupal:10.0.0. Use -                        
                    $this->assertSession()->responseContains() for non-HTML     
                    responses, like XML or Json. -                              
                    $this->assertSession()->pageTextContains() for HTML         
                    responses. Unlike the deprecated assertText(), the passed   
                    text should be HTML decoded, exactly as a human sees it in  
                    the browser.                                                
--------------------------------------------------------------------------------
Check manually 81   Call to deprecated method assertText() of class             
                    Drupal\Tests\BrowserTestBase. Deprecated in drupal:8.2.0 and
                    is removed from drupal:10.0.0. Use -                        
                    $this->assertSession()->responseContains() for non-HTML     
                    responses, like XML or Json. -                              
                    $this->assertSession()->pageTextContains() for HTML         
                    responses. Unlike the deprecated assertText(), the passed   
                    text should be HTML decoded, exactly as a human sees it in  
                    the browser.                                                
--------------------------------------------------------------------------------
Check manually 82   Call to deprecated method assertText() of class             
                    Drupal\Tests\BrowserTestBase. Deprecated in drupal:8.2.0 and
                    is removed from drupal:10.0.0. Use -                        
                    $this->assertSession()->responseContains() for non-HTML     
                    responses, like XML or Json. -                              
                    $this->assertSession()->pageTextContains() for HTML         
                    responses. Unlike the deprecated assertText(), the passed   
                    text should be HTML decoded, exactly as a human sees it in  
                    the browser.                                                
--------------------------------------------------------------------------------
Check manually 97   Call to deprecated method assertText() of class             
                    Drupal\Tests\BrowserTestBase. Deprecated in drupal:8.2.0 and
                    is removed from drupal:10.0.0. Use -                        
                    $this->assertSession()->responseContains() for non-HTML     
                    responses, like XML or Json. -                              
                    $this->assertSession()->pageTextContains() for HTML         
                    responses. Unlike the deprecated assertText(), the passed   
                    text should be HTML decoded, exactly as a human sees it in  
                    the browser.                                                
--------------------------------------------------------------------------------
Check manually 98   Call to deprecated method assertText() of class             
                    Drupal\Tests\BrowserTestBase. Deprecated in drupal:8.2.0 and
                    is removed from drupal:10.0.0. Use -                        
                    $this->assertSession()->responseContains() for non-HTML     
                    responses, like XML or Json. -                              
                    $this->assertSession()->pageTextContains() for HTML         
                    responses. Unlike the deprecated assertText(), the passed   
                    text should be HTML decoded, exactly as a human sees it in  
                    the browser.                                                
--------------------------------------------------------------------------------
Check manually 102  Call to deprecated method drupalPostForm() of class         
                    Drupal\Tests\BrowserTestBase. Deprecated in drupal:9.1.0 and
                    is removed from drupal:10.0.0. Use $this->submitForm()      
                    instead.                                                    
--------------------------------------------------------------------------------
Check manually 105  Call to deprecated method assertText() of class             
                    Drupal\Tests\BrowserTestBase. Deprecated in drupal:8.2.0 and
                    is removed from drupal:10.0.0. Use -                        
                    $this->assertSession()->responseContains() for non-HTML     
                    responses, like XML or Json. -                              
                    $this->assertSession()->pageTextContains() for HTML         
                    responses. Unlike the deprecated assertText(), the passed   
                    text should be HTML decoded, exactly as a human sees it in  
                    the browser.                                                
--------------------------------------------------------------------------------
Check manually 106  Call to deprecated method assertText() of class             
                    Drupal\Tests\BrowserTestBase. Deprecated in drupal:8.2.0 and
                    is removed from drupal:10.0.0. Use -                        
                    $this->assertSession()->responseContains() for non-HTML     
                    responses, like XML or Json. -                              
                    $this->assertSession()->pageTextContains() for HTML         
                    responses. Unlike the deprecated assertText(), the passed   
                    text should be HTML decoded, exactly as a human sees it in  
                    the browser.                                                
--------------------------------------------------------------------------------
Check manually 120  Call to deprecated method assertText() of class             
                    Drupal\Tests\BrowserTestBase. Deprecated in drupal:8.2.0 and
                    is removed from drupal:10.0.0. Use -                        
                    $this->assertSession()->responseContains() for non-HTML     
                    responses, like XML or Json. -                              
                    $this->assertSession()->pageTextContains() for HTML         
                    responses. Unlike the deprecated assertText(), the passed   
                    text should be HTML decoded, exactly as a human sees it in  
                    the browser.                                                
--------------------------------------------------------------------------------
Check manually 121  Call to deprecated method assertText() of class             
                    Drupal\Tests\BrowserTestBase. Deprecated in drupal:8.2.0 and
                    is removed from drupal:10.0.0. Use -                        
                    $this->assertSession()->responseContains() for non-HTML     
                    responses, like XML or Json. -                              
                    $this->assertSession()->pageTextContains() for HTML         
                    responses. Unlike the deprecated assertText(), the passed   
                    text should be HTML decoded, exactly as a human sees it in  
                    the browser.                                                
--------------------------------------------------------------------------------
Check manually 125  Call to deprecated method drupalPostForm() of class         
                    Drupal\Tests\BrowserTestBase. Deprecated in drupal:9.1.0 and
                    is removed from drupal:10.0.0. Use $this->submitForm()      
                    instead.                                                    
--------------------------------------------------------------------------------
Check manually 128  Call to deprecated method assertText() of class             
                    Drupal\Tests\BrowserTestBase. Deprecated in drupal:8.2.0 and
                    is removed from drupal:10.0.0. Use -                        
                    $this->assertSession()->responseContains() for non-HTML     
                    responses, like XML or Json. -                              
                    $this->assertSession()->pageTextContains() for HTML         
                    responses. Unlike the deprecated assertText(), the passed   
                    text should be HTML decoded, exactly as a human sees it in  
                    the browser.                                                
--------------------------------------------------------------------------------
Check manually 129  Call to deprecated method assertText() of class             
                    Drupal\Tests\BrowserTestBase. Deprecated in drupal:8.2.0 and
                    is removed from drupal:10.0.0. Use -                        
                    $this->assertSession()->responseContains() for non-HTML     
                    responses, like XML or Json. -                              
                    $this->assertSession()->pageTextContains() for HTML         
                    responses. Unlike the deprecated assertText(), the passed   
                    text should be HTML decoded, exactly as a human sees it in  
                    the browser.                                                
--------------------------------------------------------------------------------
Check manually 145  Call to deprecated method drupalPostForm() of class         
                    Drupal\Tests\BrowserTestBase. Deprecated in drupal:9.1.0 and
                    is removed from drupal:10.0.0. Use $this->submitForm()      
                    instead.                                                    
--------------------------------------------------------------------------------
Check manually 148  Call to deprecated method assertText() of class             
                    Drupal\Tests\BrowserTestBase. Deprecated in drupal:8.2.0 and
                    is removed from drupal:10.0.0. Use -                        
                    $this->assertSession()->responseContains() for non-HTML     
                    responses, like XML or Json. -                              
                    $this->assertSession()->pageTextContains() for HTML         
                    responses. Unlike the deprecated assertText(), the passed   
                    text should be HTML decoded, exactly as a human sees it in  
                    the browser.                                                
--------------------------------------------------------------------------------
Check manually 156  Call to deprecated method drupalPostForm() of class         
                    Drupal\Tests\BrowserTestBase. Deprecated in drupal:9.1.0 and
                    is removed from drupal:10.0.0. Use $this->submitForm()      
                    instead.                                                    
--------------------------------------------------------------------------------
Check manually 160  Call to deprecated method drupalPostForm() of class         
                    Drupal\Tests\BrowserTestBase. Deprecated in drupal:9.1.0 and
                    is removed from drupal:10.0.0. Use $this->submitForm()      
                    instead.                                                    
--------------------------------------------------------------------------------
Check manually 163  Call to deprecated method assertText() of class             
                    Drupal\Tests\BrowserTestBase. Deprecated in drupal:8.2.0 and
                    is removed from drupal:10.0.0. Use -                        
                    $this->assertSession()->responseContains() for non-HTML     
                    responses, like XML or Json. -                              
                    $this->assertSession()->pageTextContains() for HTML         
                    responses. Unlike the deprecated assertText(), the passed   
                    text should be HTML decoded, exactly as a human sees it in  
                    the browser.                                                
--------------------------------------------------------------------------------
Check manually 164  Call to deprecated method assertText() of class             
                    Drupal\Tests\BrowserTestBase. Deprecated in drupal:8.2.0 and
                    is removed from drupal:10.0.0. Use -                        
                    $this->assertSession()->responseContains() for non-HTML     
                    responses, like XML or Json. -                              
                    $this->assertSession()->pageTextContains() for HTML         
                    responses. Unlike the deprecated assertText(), the passed   
                    text should be HTML decoded, exactly as a human sees it in  
                    the browser.                                                
--------------------------------------------------------------------------------
Check manually 171  Call to deprecated method assertText() of class             
                    Drupal\Tests\BrowserTestBase. Deprecated in drupal:8.2.0 and
                    is removed from drupal:10.0.0. Use -                        
                    $this->assertSession()->responseContains() for non-HTML     
                    responses, like XML or Json. -                              
                    $this->assertSession()->pageTextContains() for HTML         
                    responses. Unlike the deprecated assertText(), the passed   
                    text should be HTML decoded, exactly as a human sees it in  
                    the browser.                                                
--------------------------------------------------------------------------------
Check manually 175  Call to deprecated method drupalPostForm() of class         
                    Drupal\Tests\BrowserTestBase. Deprecated in drupal:9.1.0 and
                    is removed from drupal:10.0.0. Use $this->submitForm()      
                    instead.                                                    
--------------------------------------------------------------------------------
Check manually 178  Call to deprecated method assertText() of class             
                    Drupal\Tests\BrowserTestBase. Deprecated in drupal:8.2.0 and
                    is removed from drupal:10.0.0. Use -                        
                    $this->assertSession()->responseContains() for non-HTML     
                    responses, like XML or Json. -                              
                    $this->assertSession()->pageTextContains() for HTML         
                    responses. Unlike the deprecated assertText(), the passed   
                    text should be HTML decoded, exactly as a human sees it in  
                    the browser.                                                
--------------------------------------------------------------------------------
Check manually 179  Call to deprecated method assertText() of class             
                    Drupal\Tests\BrowserTestBase. Deprecated in drupal:8.2.0 and
                    is removed from drupal:10.0.0. Use -                        
                    $this->assertSession()->responseContains() for non-HTML     
                    responses, like XML or Json. -                              
                    $this->assertSession()->pageTextContains() for HTML         
                    responses. Unlike the deprecated assertText(), the passed   
                    text should be HTML decoded, exactly as a human sees it in  
                    the browser.                                                
--------------------------------------------------------------------------------

FILE:
web/modules/contrib/site_settings/tests/modules/site_settings_sample_data/site_s
ettings_sample_data.install

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Fix later      105  Call to deprecated function file_save_data(). Deprecated in 
                    drupal:9.3.0 and is removed from drupal:10.0.0. Use         
                    Drupal\file\FileRepositoryInterface::writeData() instead.   
--------------------------------------------------------------------------------
Fix later      143  Call to deprecated function file_save_data(). Deprecated in 
                    drupal:9.3.0 and is removed from drupal:10.0.0. Use         
                    Drupal\file\FileRepositoryInterface::writeData() instead.   
--------------------------------------------------------------------------------

FILE: web/modules/contrib/site_settings/src/Tests/SiteSettingsLoaderTest.php

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 61   The 'site_settings_sample_data/test_site_settings_loader'   
                    library is not defined because the defining extension is not
                    installed. Cannot decide if it is deprecated or not.        
--------------------------------------------------------------------------------

FILE: web/modules/contrib/site_settings/site_settings.info.yml

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 0    Value of core_version_requirement: ^8 || ^9 is not          
                    compatible with the next major version of Drupal core. See  
                    https://drupal.org/node/3070687.                            
--------------------------------------------------------------------------------

FILE:
web/modules/contrib/site_settings/modules/site_settings_type_permissions/site_se
ttings_type_permissions.info.yml

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 0    Value of core_version_requirement: ^8 || ^9 is not          
                    compatible with the next major version of Drupal core. See  
                    https://drupal.org/node/3070687.                            
--------------------------------------------------------------------------------

FILE:
web/modules/contrib/site_settings/tests/modules/site_settings_sample_data/site_s
ettings_sample_data.info.yml

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 0    Value of core_version_requirement: ^8 || ^9 is not          
                    compatible with the next major version of Drupal core. See  
                    https://drupal.org/node/3070687.                            
--------------------------------------------------------------------------------

The attached patch resolves all those issues. The module is enabled successfully on both D9.4 and D10-alpha6 without any issues and is working as expected.

Comment #4

fathima.asmat commented 31 July 2022 at 17:11

Issue tags:

+Drupal 10 porting day

Comment #5

fathima.asmat commented 31 July 2022 at 17:56

Status	File	Size
new	site_settings-d10-compatibility-3298089-4.patch	23.9 KB
new	interdiff_3_4.txt	518 bytes

1 file was hidden/shown/deleted

Status	File	Size
hidden	site_settings-d10-compatibility-3298089-3.patch	24.1 KB

Removed unused class FileRepositoryInterface.

Comment #6

atul_ghate commented 1 August 2022 at 05:59

Assigned:

Unassigned

» atul_ghate

Hi,
i will review this patch.

Comment #7

atul_ghate commented 1 August 2022 at 07:59

Assigned:

atul_ghate

» Unassigned

Status	File	Size
new	site_settings.png	118.09 KB

Hi @fathima.asmat
I am unable to apply this patch ,I am getting some error messages see imge.
what i did
1 clone the branch 8.x-1.x
2 apply patch using "git apply "

Comment #8

fathima.asmat commented 1 August 2022 at 08:35

Thanks for checking Atul. It seems like composer require -W drupal/site_settings:@dev (as given in https://www.drupal.org/community-initiatives/contribution-events-initiat...) has got 8.x-1.x-dev which seems like outdated and not up-to-date with latest stable. The patch was based on the dev release as per the porting instructions. I'll update the patch using the stable version. soon.

Comment #9

project update bot commented 22 August 2022 at 21:03

Status	File	Size
new	interdiff-last-bot.6659740.txt	368 bytes
new	site_settings.1.x-dev.rector.patch	6.94 KB

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module, even with this patch, this module is not yet compatible with Drupal 10.

Currently Drupal Rector, version 0.13.1, cannot fix all Drupal 10 compatibility problems.

This patch does not update the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #145

This patch was created using these packages:

mglaman/phpstan-drupal: 1.1.25
palantirnet/drupal-rector: 0.13.1

Comment #10

project update bot commented 17 October 2022 at 19:03

Issue summary:

View changes

Updating bot issue summary.See #3313904: Update project bot templates for RTBC status support and human interaction tips

Comment #11

fathima.asmat commented 19 November 2022 at 13:57

Issue summary:

View changes

Status	File	Size
new	site_settings-d10-compatibility-3298089-11.patch	8.67 KB
new	interdiff_9-11.txt	1.33 KB
new	Screenshot 2022-11-19 at 13.54.53.png	34.98 KB
new	Screenshot 2022-11-19 at 13.54.57.png	66.84 KB
new	Screenshot 2022-11-19 at 13.55.06.png	43.08 KB
new	Screenshot 2022-11-19 at 13.55.11.png	77.81 KB
new	Screenshot 2022-11-19 at 13.55.19.png	19.01 KB
new	Screenshot 2022-11-19 at 13.55.37.png	9.23 KB

Tested Rector patch from #9 and couldn't apply due to missing info yml changes.
Amended the patch to include those changes and patch applied cleanly. Patch attached.
Upgrade status doesn't flag any more issues

 [notice] Processing /var/www/html/web/modules/contrib/site_settings.

================================================================================
Site Settings and Labels, --
Scanned on Sat, 11/19/2022 - 13:41

No known issues found.

Tested the module manually on both D9 and D10 beta.
Could successfully create a site setting with a field set.
Could render the site setting successfully on the front-end tempalte.
Screenshots of test results attached.

Comment #12

fathima.asmat commented 19 November 2022 at 13:59

Reworked on D10 porting Day November :)

Comment #13

30 November 2022 at 06:40

scott_euser committed 8ac1cf2 on 8.x-1.x

Issue #3298089 by fathima.asmat, Project Update Bot: Automated Drupal 10...

Comment #14

scott_euser commented 30 November 2022 at 06:41

Status:

Needs review

» Fixed

Thanks @fathima.asmat , much appreciated!
Scott

Comment #15

14 December 2022 at 06:44

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Automated Drupal 10 compatibility fixes

Problem/Motivation

Proposed resolution

Remaining tasks

Providing feedback

Comments

Comment #1

Comment #2

Drupal 10 Compatibility

Debug info

Comment #3

Comment #4

Comment #5

Comment #6

Comment #7

Comment #8

Comment #9

Drupal 10 Compatibility

Debug info

Comment #10

Comment #11

Comment #12

Comment #13

Comment #14

Comment #15

News items

Our community

Documentation

Drupal code base

Governance of community