Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects

Patches will periodically be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD10" tag from the issue to stop the bot from posting updates.

The patches will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot patches. The bot will still post new patches then if there is a change in the new generated patch compared to the patch that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated patches, remove the "ProjectUpdateBotD10" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.

CommentFileSizeAuthor
#14 interdiff-9-14.txt24.71 KBtaran2l
#14 d10-compatibility-3298015-14.patch56.96 KBtaran2l
#13 interdiff-9-13.txt25.11 KBtaran2l
#13 d10-compatibility-3298015-13.patch57.35 KBtaran2l
#11 Search_autocomplete_D10_compatibility.png68.51 KBtushar1
#10 search_autocomplete.3298015-10.png189.14 KBkuhikar
#10 interdiff_9_10.txt43.55 KBkuhikar
#10 search_autocomplete.3298015-10.patch59.06 KBkuhikar
#10 search_autocomplete.3298015-9.png500.48 KBkuhikar
#9 interdiff_6-9.txt376 bytesmrinalini9
#9 d10-compatibility-3298015-9.patch36.13 KBmrinalini9
#2 search_autocomplete.2.0.2.rector.patch34.19 KBproject update bot
#3 interdiff-last-bot.6659665.txt535 bytesproject update bot
#3 search_autocomplete.2.0.2.rector.patch33.7 KBproject update bot
#4 interdiff-last-bot.6675778.txt2.76 KBproject update bot
#4 search_autocomplete.2.0.2.rector.patch35.63 KBproject update bot
#6 d10-compatibility.patch36.31 KBmahesh bandhiya

Issue fork search_autocomplete-3298015

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

    About issue forks

    Comments

    Project Update Bot created an issue. See original summary.

    project update bot’s picture

    project update bot commented
    Status: Active » Needs review
    StatusFileSize
    new search_autocomplete.2.0.2.rector.patch34.19 KB

    This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

    It is important that any automated tests available are run with this patch and that you manually test this patch.

    Drupal 10 Compatibility

    According to the Upgrade Status module this patch makes this module compatible with Drupal 10! 🎉
    This patch updates the info.yml file for Drupal 10 compatibility.

    Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

    Debug info

    Bot run #139

    This patch was created using these packages:

    1. mglaman/phpstan-drupal: 1.1.24
    2. palantirnet/drupal-rector: 0.13.0
    project update bot’s picture

    project update bot commented
    StatusFileSize
    new interdiff-last-bot.6659665.txt535 bytes
    new search_autocomplete.2.0.2.rector.patch33.7 KB

    This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

    It is important that any automated tests available are run with this patch and that you manually test this patch.

    Drupal 10 Compatibility

    According to the Upgrade Status module, even with this patch, this module is not yet compatible with Drupal 10.

    Currently Drupal Rector, version 0.13.0, cannot fix all Drupal 10 compatibility problems.

    This patch does not update the info.yml file for Drupal 10 compatibility.

    Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

    Debug info

    Bot run #143

    This patch was created using these packages:

    1. mglaman/phpstan-drupal: 1.1.25
    2. palantirnet/drupal-rector: 0.13.0
    project update bot’s picture

    project update bot commented
    StatusFileSize
    new interdiff-last-bot.6675778.txt2.76 KB
    new search_autocomplete.2.0.2.rector.patch35.63 KB

    This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

    It is important that any automated tests available are run with this patch and that you manually test this patch.

    Drupal 10 Compatibility

    According to the Upgrade Status module, even with this patch, this module is not yet compatible with Drupal 10.

    Currently Drupal Rector, version 0.13.1, cannot fix all Drupal 10 compatibility problems.

    This patch does not update the info.yml file for Drupal 10 compatibility.

    Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

    Debug info

    Bot run #145

    This patch was created using these packages:

    1. mglaman/phpstan-drupal: 1.1.25
    2. palantirnet/drupal-rector: 0.13.1
    project update bot’s picture

    project update bot commented
    Issue summary: View changes

    Updating bot issue summary.See #3313904: Update project bot templates for RTBC status support and human interaction tips

    mahesh bandhiya’s picture

    mahesh bandhiya commented
    Issue summary: View changes
    StatusFileSize
    new d10-compatibility.patch36.31 KB

    to make the module compatible with drupal 10

    lugir’s picture

    lugir commented
    Status: Needs review » Reviewed & tested by the community

    #2 works

    poker10’s picture

    poker10 commented
    Status: Reviewed & tested by the community » Needs work

    The patch #6 is not RTBC.

    At least this should not be present in the .yml file, as it is added automatically by the Drupal.org packaging script:

    +++ b/search_autocomplete.info.yml
@@ -1,8 +1,13 @@
+
+# Information added by Drupal.org packaging script on 2022-04-09
+version: '2.0.2'
+project: 'search_autocomplete'
+datestamp: 1649542390
    mrinalini9’s picture

    mrinalini9 commented
    Status: Needs work » Needs review
    StatusFileSize
    new d10-compatibility-3298015-9.patch36.13 KB
    new interdiff_6-9.txt376 bytes

    Updated patch #6 by addressing #8, please review it.

    Thanks!

    kuhikar’s picture

    kuhikar commented
    Assigned: Unassigned » kuhikar
    StatusFileSize
    new search_autocomplete.3298015-9.png500.48 KB
    new search_autocomplete.3298015-10.patch59.06 KB
    new interdiff_9_10.txt43.55 KB
    new search_autocomplete.3298015-10.png189.14 KB

    Patch: #9 is not resolving the of the Console error. Kindly check: search_autocomplete.3298015-9.png

    Created a new Patch: search_autocomplete.3298015-10.patch

    Added: Interdiff: interdiff_9_10.txt

    Post applying search_autocomplete.3298015-10.patch patch: Kindly check: search_autocomplete.3298015-10.png

    tushar1’s picture

    tushar1 commented
    Status: Needs review » Reviewed & tested by the community
    StatusFileSize
    new Search_autocomplete_D10_compatibility.png68.51 KB

    Applied patch #10 on latest 2.0.2 version which is applied cleany and functionality is also working fine as expected.making it RTBC..

    taran2l’s picture

    taran2l
    Primary language Ukrainian
    Location Lviv
    commented
    Status: Reviewed & tested by the community » Needs work

    I don't think code stye changes are in the scope of this issue, let's not scope creep, we should get back to patch from #9 and fix issues without any code style changes

    taran2l’s picture

    taran2l
    Primary language Ukrainian
    Location Lviv
    commented
    Status: Needs work » Needs review
    StatusFileSize
    new d10-compatibility-3298015-13.patch57.35 KB
    new interdiff-9-13.txt25.11 KB

    Hmm, so there is no way to run tests against 2.x branch ?

    So, I took patch from #9 and combined things from #10 (without code style fixes) + added a few fixes so tests are green (locally) on D9/10

    taran2l’s picture

    taran2l
    Primary language Ukrainian
    Location Lviv
    commented
    StatusFileSize
    new d10-compatibility-3298015-14.patch56.96 KB
    new interdiff-9-14.txt24.71 KB

    Huh, now patch pass D9 :D

    bob.hinrichs’s picture

    bob.hinrichs commented

    Any word on a D10 release?

    gurbakshish’s picture

    gurbakshish commented

    #2 Patch worked for me Thanks

    dom.’s picture

    dom. commented
    Version: 2.0.2 » 3.x-dev

    • Dom. committed af7266e3 on 3.x 
      Issue #3298015 by Project Update Bot, Taran2L, kuhikar, mrinalini9,...
    dom.’s picture

    dom. commented
    Status: Needs review » Fixed

    I have committed that twice but none triggers the Drupal Bot. Hopefully your contribution will be counted.
    I really want to thanks you all for your time. This is much appreciated.

    @bob.hinrichs : I am working on it as of my spare time. I pledge a full release at worth for the DDD Vienna this July where I will spend my time on contributing for my modules.

    This is pushed to 3.x branch and will be included of course in the next release.

    Status: Fixed » Closed (fixed)

    Automatically closed - issue fixed for 2 weeks with no activity.

    rgnyldz’s picture

    rgnyldz commented

    Hello, is this issue fixed? Do we have a release for drupal 10?

    dom.’s picture

    dom. commented

    This issue is fixed indeed (also, it closed itself!)
    A 3.x branch is available.

    I have some little adjustments to do regarding other tickets but I plan to release a stable D10 version during the Drupal Dev Days Vienna, meaning by the end of the week.