Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects

Patches will periodically be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD10" tag from the issue to stop the bot from posting updates.

The patches will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot patches. The bot will still post new patches then if there is a change in the new generated patch compared to the patch that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated patches, remove the "ProjectUpdateBotD10" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.

Issue fork name-3297718

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

Project Update Bot created an issue. See original summary.

project update bot’s picture

Status: Active » Needs review
StatusFileSize
new30.78 KB

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module, even with this patch, this module is not yet compatible with Drupal 10.

Currently Drupal Rector, version 0.13.0, cannot fix all Drupal 10 compatibility problems.

This patch does not update the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #139

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 1.1.24
  2. palantirnet/drupal-rector: 0.13.0
project update bot’s picture

StatusFileSize
new2.17 KB
new32.23 KB

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module, even with this patch, this module is not yet compatible with Drupal 10.

Currently Drupal Rector, version 0.13.1, cannot fix all Drupal 10 compatibility problems.

This patch does not update the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #145

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 1.1.25
  2. palantirnet/drupal-rector: 0.13.1

  • webflo committed 8a2af73 on 8.x-1.x
    Issue #3297718 by Project Update Bot: Automated Drupal 10 compatibility...
webflo’s picture

Issue summary: View changes
Status: Needs review » Active
akshaydalvi212’s picture

Issue summary: View changes
Status: Active » Needs work
StatusFileSize
new95.51 KB

Hello,

while reviewing the patch and module compatible with drupal 10 using upgrade-status module.
got some errors as below:

I will work on the errors and provide the patch which will solve the errors and make the module compatible with drupal 10.

Thanks and regards.

akshaydalvi212’s picture

Issue summary: View changes
Status: Needs work » Needs review
StatusFileSize
new1.48 KB
new50.99 KB

Hello,

Providing the patch which will make the module compatible with drupal 10.
After applying the patch as per the upgrade-status scan report the module is compatible with drupal 10.

The module gets install on drupal 10 and can configure the name field.

Shifting the issue status to Needs review.

Thanks and regards.

Status: Needs review » Needs work

The last submitted patch, 7: name_3297718-7.patch, failed testing. View results

reenaraghavan’s picture

Assigned: Unassigned » reenaraghavan
reenaraghavan’s picture

Assigned: reenaraghavan » Unassigned
Status: Needs work » Needs review
StatusFileSize
new13.69 KB
new11.09 KB

I have tested the latest patch. It is compatible with Drupal 10 and no errors were found.
Installed it in Drupal 10 and the module is working fine.
I have attached the screenshots of Drupal 10 name field.

Aamir M’s picture

Assigned: Unassigned » Aamir M
Aamir M’s picture

Assigned: Aamir M » Unassigned
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new61.65 KB
new54.67 KB
new346.48 KB

Verified patch #7 on Drupal 9.4.x, 10.0.x and 10.1.x. The patch was applied successfully and looks good to me.
The module can be installed after applying the patch.
I have tested the module manually it's worked properly

During the Drupal 10 Readiness Initiative meeting, it was discussed whether or not to mark bot issues "RTBC" when humans have successfully tested them and the decision was "yes". So, moving this from to "RTBC" based on the successful testing above. If the maintainer prefers to move this back to "Active" or "Needs review", please just add a note explaining this preference so new contributors leave the issue alone.

Screenshots are attached for reference:
Hence moved to RTBC

project update bot’s picture

MrDaleSmith made their first commit to this issue’s fork.

mrdalesmith’s picture

Issue summary: View changes

Applied patch to fork branch to make testing easier.

megachriz’s picture

Status: Reviewed & tested by the community » Needs work

This needs work because of the failing test in the patch from #7.

megachriz’s picture

I've made some adjustments but the tests still need work. The tests depended on the theme "stable" which no longer exists in Drupal 10. And some tests fail when switching to the theme "stark".

megachriz’s picture

Status: Needs work » Needs review

Tests are passing on both D9 and D10. So this can get back to "Needs review". I think only a code review is perhaps needed, because for manual testing of this module, this was already marked as RTBC.

Manoj Raj.R’s picture

StatusFileSize
new6.04 KB

Reviewed the patch.

Looks like good catch from MegaChriz.

Everything looks good from Drupal standards.

The specifix and good review.

heddn’s picture

Status: Needs review » Fixed

Thanks everyone for your contributions! A tagged release to support D10 should come shortly.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.