Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects

Patches will periodically be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD10" tag from the issue to stop the bot from posting updates.

The patches will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot patches. The bot will still post new patches then if there is a change in the new generated patch compared to the patch that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated patches, remove the "ProjectUpdateBotD10" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.

CommentFileSizeAuthor
#12 like_dislike_patch.png8.87 KBrahul17
#12 like_dislike.png18.19 KBrahul17
#9 like_and_dislike-3297527-9.patch1.89 KBabhinavk
#9 interdiff-6-9.txt417 bytesabhinavk
#9 like_and_dislike-drupal-check.txt3.16 KBabhinavk
#7 After applying patch.PNG8.41 KBabhinavk
#6 like_and_dislike-3297527-6.patch1.89 KBarisen
#2 like_and_dislike.1.x-dev.rector.patch10.72 KBproject update bot

Issue fork like_and_dislike-3297527

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Project Update Bot created an issue. See original summary.

project update bot’s picture

project update bot commented
Status: Active » Needs review
StatusFileSize
new like_and_dislike.1.x-dev.rector.patch10.72 KB

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module, even with this patch, this module is not yet compatible with Drupal 10.

Currently Drupal Rector, version 0.13.0, cannot fix all Drupal 10 compatibility problems.

This patch does not update the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #139

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 1.1.24
  2. palantirnet/drupal-rector: 0.13.0

project update bot’s picture

project update bot commented
Issue summary: View changes

Updating bot issue summary.See #3313904: Update project bot templates for RTBC status support and human interaction tips

arisen’s picture

arisen
Location Goa, GMT +5:30
commented
Assigned: Unassigned » arisen
Issue summary: View changes
Status: Needs review » Needs work

Since the patch has been already merged with the dev branch, tried installing the dev release through composer.

Encountered the following issue.

Info from https://repo.packagist.org: #StandWithUkraine
./composer.json has been updated
Running composer update drupal/like_and_dislike
Loading composer repositories with package information
Updating dependencies
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - drupal/like_and_dislike dev-1.x requires drupal/core ^8.7.7 || ^9.0 -> found drupal/core[8.7.7, ..., 8.9.x-dev, 9.0.0-alpha1, ..., 9.5.x-dev] but the package is fixed to 10.0.0 (lock file version) by a partial update and that version does not match. Make sure you list it as an argument for the update command.
    - drupal/like_and_dislike 1.x-dev is an alias of drupal/like_and_dislike dev-1.x and thus requires it to be installed too.
    - Root composer.json requires drupal/like_and_dislike 1.x-dev@dev -> satisfiable by drupal/like_and_dislike[1.x-dev (alias of dev-1.x)].

Use the option --with-all-dependencies (-W) to allow upgrades, downgrades and removals for packages currently locked to specific versions.

Installation failed, reverting ./composer.json and ./composer.lock to their original content.
composer [require drupal/like_and_dislike:1.x-dev@dev] failed, composer command failed: exit status 2. stderr=
arisen’s picture

arisen
Location Goa, GMT +5:30
commented
Assigned: arisen » Unassigned
Status: Needs work » Needs review
StatusFileSize
new like_and_dislike-3297527-6.patch1.89 KB

As mentioned in comment #2 of Project Update Bot, the patch is not fully covering the Drupal 10 compatibility.

Since the patch has already been merged with the development branch submitting a new patch with only the additional changes required.

Changes:

Note:
This module is dependent on https://www.drupal.org/project/votingapi.
VotingApi module doesn’t have a drupal 10 release yet. Manually installed drupal 10 compatible dev version using
composer require 'drupal/votingapi:3.x-dev@dev’

Manually fixed query issue with voting api module as per https://www.drupal.org/node/3201242

Testing Steps:

  1. Clone the 8.x-1.x branch of the module.
  2. Install the voting api module by using composer require 'drupal/votingapi:3.x-dev@dev’.
  3. Apply the patch.
  4. Install the module.
  5. Configure like and dislike feature on any content type.
  6. There will be error thrown from the voting api module. Fix it as per https://www.drupal.org/node/3201242.
  7. Clear the cache and review the like and dislike functionality.

P.S. - New developement branch for drupal 10 would be better.

abhinavk’s picture

abhinavk commented
Status: Needs review » Needs work
StatusFileSize
new After applying patch.PNG8.41 KB

When I was Installing this module in Drupal 10.0.3, it shows incompatible with 10.0.3.

Attached image.

shivam_tiwari’s picture

shivam_tiwari commented
Assigned: Unassigned » shivam_tiwari
abhinavk’s picture

abhinavk commented
Status: Needs work » Needs review
StatusFileSize
new like_and_dislike-drupal-check.txt3.16 KB
new interdiff-6-9.txt417 bytes
new like_and_dislike-3297527-9.patch1.89 KB

I have created a new patch which makes this module D10 compatible and is working fine for me in my local.

I have also run drupal-check for this and as the errors were ignorable, no fixes were added in this patch.
Adding file with drupal-check errors.

shivam_tiwari opened merge request !6

shivam_tiwari’s picture

shivam_tiwari commented
Assigned: shivam_tiwari » Unassigned
rahul17’s picture

rahul17 commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new like_dislike.png18.19 KB
new like_dislike_patch.png8.87 KB

I have tested patch #9 in drupal 9.5.7 and 10.0.3 which applied cleanly and makes module Drupal 10 compatible. Functionality is working as expected. So, moving this to RTBC.

  • adriancid committed 79dbd29b on 8.x-1.x 
    Issue #3297527 by shivam_tiwari, AbhinavK, Project Update Bot, arisen,...
adriancid’s picture

adriancid
Primary language Spanish
Location Qc, Canada 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Thanks

adriancid’s picture

adriancid
Primary language Spanish
Location Qc, Canada 🇨🇦
commented
Status: Fixed » Active
lobodakyrylo’s picture

lobodakyrylo commented

@adriancid why you set status to Active? If it's fixed, then the status should be Fixed.

adriancid’s picture

adriancid
Primary language Spanish
Location Qc, Canada 🇨🇦
commented
Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.