Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects

Patches will periodically be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD10" tag from the issue to stop the bot from posting updates.

The patches will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot patches. The bot will still post new patches then if there is a change in the new generated patch compared to the patch that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated patches, remove the "ProjectUpdateBotD10" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.

CommentFileSizeAuthor
#11 interdiff-3297471-4-11.txt943 byteskevin.dutra
#11 3297471-drupal-10-compatibility-11.patch24.72 KBkevin.dutra
#4 3297471-automated-drupal-10-compatibility-fixes-4.patch23.76 KBshamir.vs
#3 jw_player.1.x-dev.rector.patch23.03 KBproject update bot
#3 interdiff-last-bot.6659098.txt654 bytesproject update bot
#2 jw_player.1.x-dev.rector.patch22.59 KBproject update bot

Issue fork jw_player-3297471

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Project Update Bot created an issue. See original summary.

project update bot’s picture

project update bot commented
Status: Active » Needs review
StatusFileSize
new jw_player.1.x-dev.rector.patch22.59 KB

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module, even with this patch, this module is not yet compatible with Drupal 10.

Currently Drupal Rector, version 0.13.0, cannot fix all Drupal 10 compatibility problems.

This patch does not update the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #139

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 1.1.24
  2. palantirnet/drupal-rector: 0.13.0
project update bot’s picture

project update bot commented
StatusFileSize
new interdiff-last-bot.6659098.txt654 bytes
new jw_player.1.x-dev.rector.patch23.03 KB

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module, even with this patch, this module is not yet compatible with Drupal 10.

Currently Drupal Rector, version 0.13.1, cannot fix all Drupal 10 compatibility problems.

This patch does not update the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #145

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 1.1.25
  2. palantirnet/drupal-rector: 0.13.1
shamir.vs’s picture

shamir.vs commented
Issue summary: View changes
StatusFileSize
new 3297471-automated-drupal-10-compatibility-fixes-4.patch23.76 KB

Hi, Patch #3 applied successfully, but the patch was still incompatible with Drupal 10.
Providing a patch to make the module compatible with Drupal 10.
Please review

project update bot’s picture

project update bot commented
Issue summary: View changes

Updating bot issue summary.See #3313904: Update project bot templates for RTBC status support and human interaction tips

emircanerkul opened merge request !4

emircanerkul closed merge request !4

emircanerkul made their first commit to this issue’s fork.

emircanerkul opened merge request !5

emircanerkul’s picture

emircanerkul commented
Issue summary: View changes

#4 patches were used and thank you. After that, Seems this module and its documentation really old. Some links were broken I couldn't find JWPlayer as is written in the documentation but I found an official repository and used that. But manual compilation is needed after installation. I documented all of these in the readme.md file.

https://www.drupal.org/project/jw_player/issues/2904779 Reason for this issue is probably different but I also faced a similar problem when enabling caches. I solved it in this too.

For my changes review is needed.

kevin.dutra’s picture

kevin.dutra commented
StatusFileSize
new 3297471-drupal-10-compatibility-11.patch24.72 KB
new interdiff-3297471-4-11.txt943 bytes

The patch in #4 is missing the necessary JS changes to accommodate the replacement for the jQuery.once library. The MR is missing the required change to the library definition, and scope creeps beyond the Drupal 10 compatibility changes that this issue is for.

This patch should (hopefully) bridge all the gaps.

  • Berdir committed 48837718 on 8.x-1.x authored by kevin.dutra 
    Issue #3297471 by kevin.dutra: Automated Drupal 10 compatibility fixes
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Fixed 
+++ b/jw_player.info.yml
@@ -1,7 +1,7 @@
 description:  Adds a theme function which allows theme developers to use the JW Player
-core_version_requirement: ^8.8 || ^9
+core_version_requirement: ^8.8 || ^9 || ^10
 configure: jw_player.admin

some of the conversions here require at least 9.3, like file_create_url(), so changing the minimum version to that.

Fixed a few more problems in the tests, they pass now.

Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

pandurengan.jegadeesan’s picture

pandurengan.jegadeesan commented

The latest version of Drupal core, module has the following message on the 'Available updates' page:
Project not supported: This project is no longer supported, and is no longer available for download. Disabling everything included by this project is strongly recommended!
Can you please provide updated module that supports Drupal 10

pandurengan.jegadeesan’s picture

pandurengan.jegadeesan commented

Thanks for providing stable release for Drupal 10