Hello project maintainers,
This is an automated issue to help make this module compatible with Drupal 10.
To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects
Patches will periodically be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD10" tag from the issue to stop the bot from posting updates.
The patches will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.
You have a few options for how to use this issue:
If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.
As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.
Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot patches. The bot will still post new patches then if there is a change in the new generated patch compared to the patch that the bot posted last. Those changes are then up to humans to integrate.
If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated patches, remove the "ProjectUpdateBotD10" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.
If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated patches will be posted here.
If the issue is reopened, then new automated patches will be posted.
If you are using another issue(s) to work on Drupal 10 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.
Using the patches
If there are problems with one of the patches posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.
| Comment | File | Size | Author |
|---|---|---|---|
| #12 | imagepopuperrors.PNG | 43.95 KB | sidharth_soman |
| #6 | 3297406-5.patch | 8.45 KB | kunalgautam |
| #4 | image_popup-3297406-4.patch | 4.26 KB | prudloff |
| #2 | image_popup.2.x-dev.rector.patch | 3.32 KB | project update bot |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
project update bot commentedThis is an automated patch generated by Drupal Rector. Please see the issue summary for more details.
It is important that any automated tests available are run with this patch and that you manually test this patch.
Drupal 10 Compatibility
According to the Upgrade Status module, even with this patch, this module is not yet compatible with Drupal 10.
Currently Drupal Rector, version 0.13.0, cannot fix all Drupal 10 compatibility problems.
This patch does not update the
info.ymlfile for Drupal 10 compatibility.Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.
Debug info
This patch was created using these packages:
Comment #3
project update bot commentedUpdating bot issue summary.See #3313904: Update project bot templates for RTBC status support and human interaction tips
Comment #4
prudloff commentedIf anyone needs to start using this module on Drupal 10, here is a patch that applies cleanly on 2.0.0.
(Reviewers should review the patch that targets 2.x-dev instead.)
Comment #5
gaëlgThis module also includes a CKEditor plugin. If you use it, note that it's not yet compatible with CKEditor5, the version bundled in D10 core.
Comment #6
kunalgautam commentedupdate Dependency injection.
Comment #7
cobadger commentedI tested the patch in comment #6 against 2.x-dev and it resolved the issues that upgrade_status reports, however the ckeditor plugin throws ajax errors:
Comment #9
shivam_tiwari commentedComment #11
shivam_tiwari commentedComment #12
sidharth_soman commented@shivam_tiwari Your MR appears to resolve all the issues according to my upgrade status module. The only error remaining is to add the Drupal 11 version into core_version_requirement but that obviously isn't a requirement since this issue is for Drupal 10.
However, it seems that you've applied your commit directly to the 2.x branch instead of the 3297406 issue branch. I'm guessing this probably isn't desirable.
Moving the status to RTBC for now but let's see what the maintainers have to say about the branches and so forth.
Attaching the screenshot of upgrade status scan for reference.
Comment #13
gordon commentedI have also been testing this as a part of Drupal 10 upgrade. So far everything is looking fine, and it would be great if we can get this committed so it will make it easier to test.
Thanks.
Comment #14
jaykandariThank you for all the efforts & comments on the issue.
Merged the changes to 2.x.
Will be releasing a new D10 compatible release.