Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects

Periodically patches will be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted simply close this issue (any status besides Active, Needs review or Needs work) or remove the "ProjectUpdateBotD10" tag from the issue.

The patches will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review or Needs work) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but don't want new automated patches simply leave this issue open but remove the "ProjectUpdateBotD10" tag from the issue.

    You can use Drupal Rector yourself to make these patches.

    If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review or Needs work) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it may be useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the patch in the comment by Project Update Bot.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Infrastructure project issue queue using the component “Bot: Drupal Rector”.

CommentFileSizeAuthor
#12 3296614-12.patch3 KBsakthi_dev
#10 cart_view.png52.08 KBaniketj
#9 basic_cart.6x-D10_compatibility_3296614-9.patch2.99 KBabhinavk
#4 Screenshot-basic-cart.png52.32 KBrahul17
#3 interdiff.txt878 bytestushar1
#3 basic_cart.6x-D10_compatibility.patch2.54 KBtushar1
#2 basic_cart.6.x-dev.rector.patch1.87 KBproject update bot

Issue fork basic_cart-3296614

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Project Update Bot created an issue. See original summary.

project update bot’s picture

project update bot commented
Status: Active » Needs review
StatusFileSize
new basic_cart.6.x-dev.rector.patch1.87 KB

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module, even with this patch, this module is not yet compatible with Drupal 10.

Currently Drupal Rector, version 0.13.0, cannot fix all Drupal 10 compatibility problems.

This patch does not update the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #139

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 1.1.24
  2. palantirnet/drupal-rector: 0.13.0
tushar1’s picture

tushar1 commented
Assigned: Unassigned » tushar1
Issue summary: View changes
StatusFileSize
new basic_cart.6x-D10_compatibility.patch2.54 KB
new interdiff.txt878 bytes

Updating bot patch by removing some deprications and adding core_version_requirement for D10 compatibility, its wotking as expected to me, kindly review and make it RTBC...

rahul17’s picture

rahul17 commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Screenshot-basic-cart.png52.32 KB

I have tested patch #3 on Drupal 9.5.7 and 10.0.3 which applied cleanly and working as expected. So, moving it to RTBC.

kallado’s picture

kallado commented

Any idea of when a Drupal 10 release is expected?

l-laziz’s picture

l-laziz commented
Status: Reviewed & tested by the community » Needs work

Checking with upgrade status, gives this error:

The 'basic_cart' library is depending on a deprecated
library. The "core/jquery.ui" asset library is deprecated in
drupal:9.2.0 and is removed from drupal:10.0.0. See
https://www.drupal.org/node/3067969

kuhikar made their first commit to this issue’s fork.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Assigned: tushar1 » Unassigned
abhinavk’s picture

abhinavk commented
Status: Needs work » Needs review
StatusFileSize
new basic_cart.6x-D10_compatibility_3296614-9.patch2.99 KB

I have fixed core/jquery.ui issue and created new patch, please review this patch.

aniketj’s picture

aniketj commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new cart_view.png52.08 KB

I have tested patch #9 on Drupal 9 and Drupal 10 which applied cleanly and functionality working as expected added screenshot for same. Moving it to RTBC.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Reviewed & tested by the community » Needs work 
-core_version_requirement: ^8 || ^9
+core_version_requirement: ^8 || ^9 || ^10

core_version_requirement is not recognized by every Drupal 8 release. the correct value for core_version_requirement is core_version_requirement: ^8.8 || ^9 || ^10.

sakthi_dev’s picture

sakthi_dev commented
Status: Needs work » Needs review
StatusFileSize
new 3296614-12.patch3 KB

Updated as per comment #11. Please review.

rahul17’s picture

rahul17 commented
Status: Needs review » Reviewed & tested by the community

Tested patch #12 in Drupal 9 and 10, patch applied cleanly and functionality is working as expected. Hence, moving this to RTBC.

norman.lol’s picture

norman.lol
he/him
Primary language German
Location Berlin
commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.