Problem/Motivation
Hello project maintainers,
This is an automated issue to help make this module compatible with Drupal 10.
To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects
Periodically patches will be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted simply close this issue (any status besides Active, Needs review or Needs work) or remove the "ProjectUpdateBotD10" tag from the issue.
The patches will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.
Proposed resolution
You have a few options for how to use this issue:
- Accept automated patches until this issue is closed
If this issue is left open (status of Active, Needs review or Needs work) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.
As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.
- Leave open but stop new automated patches.
If you want to use this issue as a starting point to remove deprecated API uses but don't want new automated patches simply leave this issue open but remove the "ProjectUpdateBotD10" tag from the issue.
You can use Drupal Rector yourself to make these patches.
If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.
- Close it and don't use it
If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review or Needs work) and no more automated patches will be posted here.
If the issue is reopened, then new automated patches will be posted.
If you are using another issue(s) to work on Drupal 10 compatibility it may be useful to other contributors to add those issues as "Related issues" when closing this issue.
Remaining tasks
Using the patches
- Apply the patch in the comment by Project Update Bot.
- Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
Providing feedback
If there are problems with one of the patches posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Infrastructure project issue queue using the component “Bot: Drupal Rector”.
Issue fork audiofield-3296591
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
project update bot commentedThis is an automated patch generated by Drupal Rector. Please see the issue summary for more details.
It is important that any automated tests available are run with this patch and that you manually test this patch.
Drupal 10 Compatibility
According to the Upgrade Status module, even with this patch, this module is not yet compatible with Drupal 10.
Currently Drupal Rector, version 0.13.0, cannot fix all Drupal 10 compatibility problems.
This patch does not update the
info.ymlfile for Drupal 10 compatibility.Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.
Debug info
This patch was created using these packages:
Comment #3
daniel.moberly commentedRerolling this patch to use dependency injection where possible and also to catch an additional instance of file_create_url missed by the original
Comment #4
meeni_dhobale commentedReviewed patch mentioned in #2 and #3, both are working fine for me on Drupal 10 instance after adding the line "core_version_requirement: ^8 || ^9 || ^10" in audiofield.info.yml file.
Issue can be move in RTBC.
Comment #5
daniel.moberly commentedRerolling with the version update as mentioned in #4Ignore this. Don't want to add this line until we're Drupal 10 ready
Comment #6
daniel.moberly commentedComment #8
daniel.moberly commentedComment #11
daniel.moberly commentedComment #12
daniel.moberly commentedI get the following issues on this update
Comment #13
geoffreyr commentedThanks for the feedback. I've run audiofield.libraries.yml through dos2unix, and while it's blown out the size of the change, it should hopefully resolve those whitespace issues.
Comment #14
geoffreyr commentedComment #15
daniel.moberly commentedI think you need to mark your new changes as ready for the merge request
Merge blocked: merge request must be marked as ready. It's still marked as draft.Comment #16
tjtj commentedPlease release this for D10.
Comment #18
daniel.moberly commentedMerged. Thanks for the work!
Comment #20
juc1 commented@danielmoberly is there any news on a D10 release please?
Comment #21
heddn@Daniel.Moberly can we get a tagged D10 stable release?
Comment #22
daniel.moberly commentedSure.