Use drush pm:install in Download instructions

Trying to include all the changed files after compiling, sorry about the noise.

Closing my Merge Request, since my compiled svelte-files didn't match the test ...

Trying a patch file in stead.

... which also fails. I can't figure out how to run commit-code-check.sh against contrib module, which I think would shed some light on the reason. I found https://www.drupal.org/docs/develop/development-tools/running-core-devel..., but it seems to be focused on core, and not a module.

Anyway, it looks like the problem is that "Svelte compiled files do not match." so if anyone else can make them match, feel free to create a patch :-)

Thanks for pointing me to the README file, I hadn't seen the info there. But I get the same result ...

By the way, I am using Ubuntu 20.04.3 and yarn 1.22.19 (I tried 1.22.17 also, but it made no difference).

It would be great if I could run commit-code-check.sh locally, before uploading the patch to drupal.org. Do you know if it's documented somewhere how to run it against a module? Or maybe simpler, how can I run the command, which finds that Svelte compiled files do not match, to perhaps get some more details?

Perhaps you can try to make the three changes in sveltejs/src/Project/ActionButton.svelte, compile the files, and see if you get a better result?

-      'To use the module you must next install/enable it. Visit the !module_page_open modules page !close to install the module using your web browser!close',
+      'To use the module you must next install it. Visit the !module_page_open modules page !close to install the module using your web browser!close',

-      'Alternatively, you can use !drush_openDrush!close to enable it via the command line.',
+      'Alternatively, you can use !drush_openDrush!close to install it via the command line',

-                <input id="${project.field_project_machine_name}-install-command" value="drush pm-enable ${project.field_project_machine_name}"/>
+                <input id="${project.field_project_machine_name}-install-command" value="drush pm:install ${project.field_project_machine_name}"/>

... and yes, I also appreciated commiting and changs :-)

I created #3296324: Update Contributing section in README, to add yarn build.

Is it because you need to change Status to "Needs review", to trigger the test?

Or maybe just "Create new branch" and start fresh?

Ah yes, marking it as "Needs review" is probably only required for the old patch method, where you attach a file, as in #6. Great that you got it created together with @omkar-pd, and that the test passes.

This issue is about changing from using "enable" to "install" as can be read in the summary. Also, please see as an example from the plain diff one of the changes:

- <input id="${project.field_project_machine_name}-install-command" value="drush pm-enable ${project.field_project_machine_name}"/>
+ <input id="${project.field_project_machine_name}-install-command" value="drush pm:install ${project.field_project_machine_name}"/>

From https://git.drupalcode.org/project/project_browser/-/merge_requests/202....

Maybe you can give it another go, check with 202.diff exactly what changes should happen after patching, and check if it works?

Thanks @aarti zikre, that looks better. (though your text still says "Alternatively, you can use Drush to enable ..." ?)

Good catch with the punctuation mark. Actually, we just need to get rid of it like this:

-      'Alternatively, you can use !drush_openDrush!close to enable it via the command line.',
+      'Alternatively, you can use !drush_openDrush!close to install it via the command line',

Since it might involve generating new files after updating the ActionButton.svelte file, and I failed miserably with mysteriously failing tests last time I tried, perhaps someone else can do that?

Thanks everybody, it looks good!