Problem/Motivation

Following #2473877: Views UI progress indicator styled as pager and placed on strange location. the .views-progress-indicator CSS class is no longer used.

Steps to reproduce

Proposed resolution

Remove it.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#11 3295709-11.patch4.6 KBravi.shankar

Issue fork drupal-3295709

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

longwave created an issue. See original summary.

immaculatexavier’s picture

immaculatexavier commented
Assigned: Unassigned » immaculatexavier
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Component: views.module » views_ui.module

immaculatexavier opened merge request !2503

immaculatexavier’s picture

immaculatexavier commented
Assigned: immaculatexavier » Unassigned
Status: Active » Needs review
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Needs work

Thanks, I think we can also remove the related CSS from these files:

core/themes/stable/css/views_ui/views_ui.admin.theme.css
core/themes/claro/css/theme/views_ui.admin.theme.pcss.css
core/themes/claro/css/theme/views_ui.admin.theme.css
core/themes/stable9/css/views_ui/views_ui.admin.theme.css

immaculatexavier’s picture

immaculatexavier commented
Assigned: Unassigned » immaculatexavier

@longwave ! sure, will work on this

immaculatexavier’s picture

immaculatexavier commented
Status: Needs work » Needs review
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Reviewed & tested by the community

Thanks, this looks correct to me. No instances of "views-progress-indicator" remain in the codebase after this patch.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs reroll

This doesn't apply to 10.1.x, might need a separate patch/MR.

ravi.shankar’s picture

ravi.shankar commented
Status: Needs work » Needs review
Issue tags: -Needs reroll
StatusFileSize
new 3295709-11.patch4.6 KB

Added a patch for Drupal 10.1.x., and removed the needs reroll tag.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Reviewed & tested by the community

Thanks, back to RTBC.

  • catch committed 284ebff on 10.0.x 
    Issue #3295709 by immaculatexavier, ravi.shankar, longwave: .views-...
  • catch committed 70246d1 on 10.1.x
    Issue #3295709 by immaculatexavier, ravi.shankar, longwave: .views-...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 10.1.x, 10.0.x and 9.5.x, respectively, thanks!

  • catch committed 5725a15 on 9.5.x 
    Issue #3295709 by immaculatexavier, ravi.shankar, longwave: .views-...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.