Add helptext for quiz grade range feedback

I do not have the "Override administrator review options" set on /admin/quiz/config/quiz. I'm configuring the feedback on the Quiz feedback tab on quiz/1/edit. On the Question feedback tab, I currently have every option checked under After the quiz. I'm happy to provide more info, but I'm not sure what other configuration options would be relevant here.

I don't think QuizFeedbackTest tests quiz feedback, it looks like it only tests question feedback.

We want to show the result options, not the pass/fail options. I wonder if there is something I step through during runtime to get a better picture of what's happening, I think the tests are a little inconclusive in this case.

Thanks for the video, that definitely helps to confirm that my configuration is correct. I'm afraid that testing this on a fresh Drupal installation won't help to uncover what's happening in this case, where the module is living in a complex application together with other modules, which is of course a normal use for it. The site where this is failing is a multi-lingual site, and although I'm not seeing anything logged with regard to the quiz results or feedback, I am able to throw an error here /admin/quiz/reports/results

Drupal\Core\Entity\Sql\SqlContentEntityStorageException: Table information not available for the 'langcode' field. in Drupal\Core\Entity\Sql\DefaultTableMapping->getFieldTableName() (line 391 of /app/web/core/lib/Drupal/Core/Entity/Sql/DefaultTableMapping.php).

I don't think this is related, but I started to think that there may be something else that is conflicting with showing the feedback. The important thing for me to really look at is where the possible places could be that would prevent the feedback from being passed finally to the template. In fact, with only Quiz feedback checked for after the quiz, only the fieldsets using quiz-question-score.html.twig are displayed, which are empty of any results.

I noticed that the getRangeFeedback method on the the QuizResultViewBuilder class was not returning values, because the $score variable was always 50, well outside of the ranges that are set in config. In fact, the combined max score of the questions is only 8, so I need to track down where the score is getting set to 50.

That's definitely going to be a problem, since the getRangeFeedback method is comparing an N/100 value with straight range values i.e. 1, 2, 3 etc.

function getRangeFeedback($quiz, $score) {    
     foreach ($quiz->get('result_options')->referencedEntities() as $paragraph) {                                                                                                                                                                                                                    
       $range = $paragraph->get('quiz_feedback_range')->get(0)->getValue();    
       if ($score >= $range['from'] && $score <= $range['to']) {    
          return $paragraph;    
        }    
      }    
    }

The $range['from'] and $range['to'] values are 0-1, or similar, not calculated based on a score that is N/100. If you step through the script, you will see the same.

I can see now after re-watching your video, that you have entered percentages for range values on the form, but there isn't any indication to users that these values should be percentages of 100%. For the passing rate, that's indicated, so maybe this can be corrected by simply updating the form to indicate that ranges should be entered as percentages.

I agree, that's much more clear on the Drupal 7 form.