Problem/Motivation

Implenent batch export for https://www.drupal.org/project/google_analytics_reports module.

This also needs an addition to google_analytics_reports from #3294348: Support for views_data_export batch exports.

CommentFileSizeAuthor
#5 3294349-support_batch_for_google_analytics_reports-5.patch1.61 KBandriic
#3 3294349-batch_for_google_analytics_reports-2.patch1.6 KBandriic
#2 3294348-views_data_export_batch-implementation-2.patch2.73 KBandriic

Comments

andriic created an issue. See original summary.

andriic’s picture

andriic commented
StatusFileSize
new 3294348-views_data_export_batch-implementation-2.patch2.73 KB
andriic’s picture

andriic commented
StatusFileSize
new 3294349-batch_for_google_analytics_reports-2.patch1.6 KB
klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Issue summary: View changes

Thanks, I think this makes sense, I just have very minor comments:

  1. +++ b/plugins/views_data_export_plugin_display_export.inc
@@ -549,6 +549,15 @@ class views_data_export_plugin_display_export extends views_plugin_display_feed
+            $this->view->built = TRUE;

    any reason why we need this line? Please add a code comment. 

  2. +++ b/plugins/views_data_export_plugin_display_export.inc
@@ -658,6 +667,18 @@ class views_data_export_plugin_display_export extends views_plugin_display_feed
+      $query_class = 'google_analytics_reports_plugin_query_google_analytics_batched';
+      $query = new $query_class();

    instead of using a string before you can just write new google_analytics_reports_plugin_query_google_analytics_batched() ?

andriic’s picture

andriic commented
Title: google_analytics_reports batch export implementation » Support google_analytics_reports batch export
StatusFileSize
new 3294349-support_batch_for_google_analytics_reports-5.patch1.61 KB

@klausi Thanks for notices.
patch was updated

steven jones’s picture

steven jones commented
Status: Needs review » Closed (won't fix)

Sorry for the lack of attention to your issue, please accept my apologies.

Drupal 7 is going to be end-of-life'd by the community in approximately 1 month.

As such, I am closing all non-critical looking, non-PHP compatibility issues for Views Data Export to tidy up the issue queues and reduce the noise. You can read about this on #3492246: Close down Drupal 7 issues.

If you feel like this issue has been closed by mistake, please do comment about re-opening it.
If you feel like the ticket is still relevant for the 8.x-1.x version of the module, then please search for a duplicate issue first, and if there really isn't one (and you've looked properly) then change the version on the ticket and re-open.

Thanks to everyone involved in this issue: for reporting it, and moving it along, it is truly appreciated.
The Drupal community wouldn't be what it is today without your involvement and effort, so I'm sorry that we couldn't get this issue resolved. Hopefully we'll work together in a future issue though, and get that one resolved :)