Refactor Claro's autocomplete-loading.module stylesheet

Ignore this patch because it not contains IE blocks

Please ignore this patch, By-mistake i placed different patch here

Needs improvement, ignore this patch

No proper nesting done. Ignore this patch

Proper nesting done.

Nesting is done. rtl statement is normalized & css logical property is used.

consider #8 and #9 patches

Noted.

Refactored the patch for 10.1.x, as the patch failed to apply in #12.

Fixed CCF of #17

If this is suppose to use nesting shouldn't

[dir="rtl"] .claro-autocomplete__message {

.js .form-autocomplete {

be nested?

Updated few selectors and improved nesting. Please review

Nesting appears to be correct.

Checking that the .css file is unchanged, to show nothing actually changed, and only change

+.js[dir="rtl"] .form-autocomplete {
+  background-image: url("data:image/svg+xml,%3csvg width='40' height='20' viewBox='0 0 20 20' xmlns='http://www.w3.org/2000/svg'%3e%3cpath d='M12 1c4.54-.173 8.188 4.787 6.687 9.068-1.176 4.384-6.993 6.417-10.637 3.7-.326-.39-.565.276-.846.442l-3.74 3.739-1.413-1.414 4.35-4.35C3.59 8.717 5.25 2.938 9.462 1.475A7.003 7.003 0 0112 1zm0 2c-3.242-.123-5.849 3.42-4.777 6.477.842 3.132 4.994 4.58 7.6 2.65 2.745-1.73 2.9-6.125.285-8.044A5.006 5.006 0 0012 3z' fill='%23868686'/%3e%3c/svg%3e");
+  background-position: 0 50%;
+}

Seems to just have moved which I don't see as an issue.

+++ b/core/themes/claro/css/components/autocomplete-loading.module.pcss.css
@@ -61,7 +68,9 @@
+[dir="rtl"] {
+  & .claro-autocomplete__message {
+    right: auto;
+    left: 0;
+  }

One of the requests of this issue is to use logical properties where possible. This RTL styling can be removed entirely by changing the LTR version to use inset-inline-end instead of right https://developer.mozilla.org/en-US/docs/Web/CSS/inset-inline

Addressed #22. Please review

There are still other references to [dir="rtl"] should they not be removed?

And this was previously tagged for a follow up if that can be addressed? Think there was something in the #frontend channel but not sure.

There are still other references to [dir="rtl"] should they not be removed?

here RTL is adding a new icon, so I don't think so we should remove it.
I have added a patch with some more css refactor. Added before and after patch screenshot. Please review

[dir="rtl"] {
   & .form-autocomplete {
     background-image: url(../../images/icons/868686/magnifier-rtl.svg);

Don't think the follow up is needed anymore.

Thanks.

Unrelated failure. restoring status

new patch for D11.

#25 still applied to 11.x branch.

The Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

I've converted the #35 patch to a MR.

Need to know what was changed in #35, no interdiff was provided or comment

#25 was previously RTBC not #35.

Patch #25 still applies; there is no need for new patches. I have added an interdiff between Patch #25 and #35. In Patch #35, logical properties that are not needed here are being removed.

Agreed, hiding the MRs and patches after 25. If there is something wrong with it then it should be noted.

Used #25 for commit.

Committed 8ab1f3c and pushed to 11.x. Thanks!