Be consistent in using origin_url (and consider making it easier to include)

I will work on this.

okay. I will updated the requested changes.

Hi @Libbna, you can take reference from https://www.drupal.org/project/project_browser/issues/3293937 and use same constants (ORIGIN_URL and MODULE_PATH) and replace all references to drupalSettings.project_browser.origin_url and drupalSettings.project_browser.module_path

Hi @Libbna, you can take reference from https://www.drupal.org/project/project_browser/issues/3293937 and use same constants (ORIGIN_URL and MODULE_PATH) and replace all references to drupalSettings.project_browser.origin_url and drupalSettings.project_browser.module_path

thank you @narendraR I will look into it.

There are still some usage of drupalSettings.project_browser.origin_url and drupalSettings .project_browser.module_path in Project.Svelte, Filter.svelte, ProjectBrowser.svelte check other files as well.

@tim.plunkett there are places for e.g. in ActionButton.svelte where .origin_url is used alone.
Either we can create 3 variables, one for origin_url, and 2nd for module_path and 3rd variable will be the concatenate of both of them or have 2 separate variables like now.

Also I have just noticed that there are few areas left to change. I will work on that asap.

still there are couple of usage of drupalSettings.project_browser.origin_url and drupalSettings .project_browser.module_path in Project.svelte.

src="{drupalSettings.project_browser.origin_url}/{drupalSettings
            .project_browser.module_path}/images/blue-security-shield-icon.svg"

src="{drupalSettings.project_browser.origin_url}/{drupalSettings
              .project_browser.module_path}/images/triangle-alert.svg"

And as suggested in #13. We can concatenate ORIGIN_URL and MODULE_PATH.

Maybe something like this.

export const FULL_URL = 
  `${ORIGIN_URL}/${drupalSettings.project_browser.module_path}`;

and use like this

src="{FULL_URL}/images/project-usage-icon.svg"

instead of

src="{ORIGIN_URL}/{MODULE_PATH}/images/project-usage-icon.svg"

Yes we can use one variable for whole url. Ok will work on this.

There seems unwanted code from other MR. Can you please either remove those or create a new MR with only required changes? Also there are still some references of drupalSettings.project_browser.modules in ActionButton.svelte, so please create constant for that also.
Constants can be ORIGIN_URL, MODULE_PATH and FULL_MODULE_PATH

I will make the necessary changes, thanks @tim.plunkett for reviewing.