Frontend (Olivero + Claro) - June 28 2022 Meeting in Slack

This frontend meeting is a combo meeting for the Olivero and Claro themes. This meeting takes place every Tuesday at 3pm UTC (8:30pm IST, 5pm CEST, 11am EST, 8am PST). See Time.is to see what that is in your timezone.

The meetings are held using Slack threads in the #frontend Slack channel on drupal.slack.com.

UPDATE (transcript added)

Introductions (Please include your drupal.org name to make crediting easier!)
9 replies

katannshaw
lauriii
ckrina
cindytwilliams
rkoller
mherchel
UjjwalAhluwalia
saschaeggi
markie

***

What agenda items would you like to discuss today?
1 reply

lauriii
Would like to discuss https://www.drupal.org/project/drupal/issues/3070558
Implement bulk operation designs

***

Any further general updates from the maintainers or product managers?
2 replies

lauriii
Sprinted on couple of issues with @mherchel today and some issues got committed. I also saw demo from @mherchel on his refactoring of the off-canvas CSS which was super exciting!

mherchel
Yeah! Tons of work are going into that

***

Where can contributors help this week? (Note: If you want your item added to a new topic thread, add a thread icon with it)
5 replies

lauriii
We’re still working on https://www.drupal.org/project/drupal/issues/3085219. @mherchel updated the MR and we could now use a review
Installer is not very usable in Claro

lauriii
I posted some minor feedback on https://www.drupal.org/project/drupal/issues/3251976 which would be easy for almost anyone to address
Claro datetime range min/max-width

lauriii
We also have quite a few issues needing review: https://www.drupal.org/project/issues/search/drupal?project_issue_follow...…]D=Claro+theme&component%5B%5D=Olivero+theme&issue_tags_op=%3D. Would be great if folks could help with reviewing some of these

mherchel
This is a small CSS tweak that needs review https://www.drupal.org/project/drupal/issues/3291100
Nested details element within content type's "manage display" UI changes width when opened

mherchel
and this is a more involved CSS issues for Drupal 10 that refactors the CSS to use --drupal-dispace CSS custom properties. I've included testing instructions in the summary https://www.drupal.org/project/drupal/issues/3291729
Refactor Olivero styles to use new --drupal-displace variables and ensure that toolbar/buttons are always visible

***

TOPIC 1: Implement bulk operation designs https://www.drupal.org/project/drupal/issues/3070558
25 replies

lauriii
Would be great to revive this old issue which got blocked on addressing some accessibility concerns

lauriii
"Most importantly, this really doesn’t belong in Claro. In the “content vs. presentation” separation-of-concerns, form semantics, labels, and instructions are most definitely content."
I’m wondering what do folks think about implementing this in Claro vs in core

lauriii
IMO what we’re doing there is pretty opinionated and as such should be fine for Claro to implement

lauriii
or am I misunderstanding the feedback from the issue that only parts of it should be moved outside of Claro?

rkoller
isn't it meant the other way around based on comment #45
"If the information from Views module is deemed inadequate, it should be addressed in Views module, so that all sites can benefit regardless of what theme is used. By putting this in Claro, all we're doing is making it harder for other themes to keep up; they'll have to duplicate this effort. And while Claro is lovely, I don't expect distros to ditch their own admin themes. So I'm strongly against theme-specific information overrides like this in the name of accessibility."
at least that is how i understand it

lauriii
I agree that any accessibility improvements to the markup that are not specific to the Claro designs should be done outside the theme

lauriii
But other than that what we’re doing there, is fine in my opinion

mherchel
Would other themes want to implement this? Does Gin? If so, we may want to abstract it out.

lauriii
Gin extends Claro

mherchel
I guess from my point of view, what matters is the ability to actually get the task completed. If it's quicker to do it in Claro, I'm all for it

mherchel
I don't want to spend too much time bikeshedding

saschaeggi
@mherchel this is actually a feature we try to port from Gin to Claro :smile:

mherchel
that would be awesome :slightly_smiling_face:

saschaeggi
From that perspective it would make sense to have it in core rather than Claro

saschaeggi
but either way is fine

mherchel
yeah, thats exactly my attitude. Themes probably shouldn't have to re-create that functionality. But, if there's less friction by putting it in Claro, then lets do it there.

mherchel
Perfect is the enemy of good

lauriii
I think this compares to the menus implementation in Olivero

lauriii
It’s a highly opinionated approach which we should at least first explore in a single theme

mherchel
That's a good point... however, I'd argue that some of the Olivero menu markup could be abstracted out of it

lauriii
yeah totally, but it was also a multistep process which was easier to iterate on in Olivero with specific use case in mind

mherchel
like the BEM stuff and the custom CSS classes for elements

mherchel
exactly

lauriii
so I think we should first do this in Claro, but if it starts looking like there are pieces that could be abstracted out, we could totally do that

mherchel
Sounds good to me

***

Continue the conversation in Slack. Thank you for showing up and contributing!
If you have additional questions or comments, please post them here or on the meeting agenda issue: https://www.drupal.org/project/drupal/issues/3293123