Problem/Motivation

Using the puzzle-placeholder while images load is more performant than the "waiting..." text as the browser does not force a reflow. Based on some manual testing, circumventing the reflow results in a much faster perceived loading time, and often the placeholder isn't even visible.

Steps to reproduce

Proposed resolution

Remaining tasks

  • ✅ File an issue about this project
  • ☐ Manual Testing
  • ☐ Code Review
  • ☐ Accessibility Review
  • ☐ Automated tests needed/written?

Issue fork project_browser-3292019

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

bnjmnm created an issue. See original summary.

bnjmnm opened merge request !170

bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented
Status: Active » Needs review
fjgarlin’s picture

fjgarlin commented
Status: Needs review » Reviewed & tested by the community

Code looks good and I agree it's a nicer experience for the user too.
It might need rebasing with the latest fixes but marking as RTBC.

bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented
Status: Reviewed & tested by the community » Fixed

Merged as it's a one line change that got 👍 from @fjgarlin and will benefit a demo I'll be doing shortly.

  • bnjmnm committed 3bffee7 on 1.0.x 
    Issue #3292019 by bnjmnm, fjgarlin: Use puzzle-placeholder instead of "...
bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.