Problem/Motivation

In #3291893: Stub release for 10.1.x breaks 10.0.x tests in HEAD. we discovered that the stub release of 10.1.x messed with the installer test on 10.0.x.
We excluded dev-releases without a date to be processed to get around this problem.

To get HEAD of 10.0.x into a happy state as soon as possible we proceeded with that issue without a valid test case for the above.

This issue exists to get that valid test case in.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#7 interdiff.txt590 bytesquietone
#7 3291904-7.patch1.92 KBquietone
#7 3291904-7-fail.patch2.69 KBquietone

Issue fork drupal-3291904

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Spokje created an issue. See original summary.

spokje’s picture

spokje
Primary language Dutch
commented
Issue summary: View changes
spokje’s picture

spokje
Primary language Dutch
commented
Title: Create a test for a dev release without a date » [PP-1] Create a test for a dev release without a date
Status: Active » Postponed

Postponing on #3291893: Stub release for 10.1.x breaks 10.0.x tests in HEAD. actually being committed.

spokje’s picture

spokje
Primary language Dutch
commented
Title: [PP-1] Create a test for a dev release without a date » Create a test for a dev release without a date
Status: Postponed » Active

Aaand...back to active since #3291893: Stub release for 10.1.x breaks 10.0.x tests in HEAD. just got in.

spokje’s picture

spokje
Primary language Dutch
commented
Assigned: spokje » Unassigned
quietone’s picture

quietone commented
Version: 10.0.x-dev » 11.x-dev
Component: phpunit » update.module

Found this will trying to update #3100110: Convert update_calculate_project_update_status() into a class. Moving to update.module where other such tests live.

quietone’s picture

quietone commented
Status: Active » Needs review
StatusFileSize
new 3291904-7-fail.patch2.69 KB
new 3291904-7.patch1.92 KB
new interdiff.txt590 bytes

This may do for the test. The fail patch include a revert of the commit in #3291893: Stub release for 10.1.x breaks 10.0.x tests in HEAD. to show that failure.

The last submitted patch, 7: 3291904-7-fail.patch, failed testing. View results

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Thanks for including the fail-test @quietone! Made the review easy.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 7: 3291904-7.patch, failed testing. View results

quietone’s picture

quietone commented
Status: Needs work » Needs review

Unrelated failure. retesting

1) Drupal\Tests\media\FunctionalJavascript\MediaSourceOEmbedVideoTest::testMediaOEmbedVideoSource
Failed asserting that 480 is equal to 240 or is less than 240.
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Reran tests are all green.

needs-review-queue-bot’s picture

needs-review-queue-bot commented
Status: Reviewed & tested by the community » Needs work

The Needs Review Queue Bot tested this issue.

While you are making the above changes, we recommend that you convert this patch to a merge request. Merge requests are preferred over patches. Be sure to hide the old patch files as well. (Converting an issue to a merge request without other contributions to the issue will not receive credit.)

smustgrave opened merge request !5338

smustgrave’s picture

smustgrave commented
Status: Needs work » Reviewed & tested by the community

Hiding files and converted #7 to an MR.

Please do not credit me if I did not other wise earn it as all I did was convert this.

Restoring status

  • catch committed 8a22b456 on 10.2.x 
    Issue #3291904 by quietone, Spokje: Create a test for a dev release...

  • catch committed 81b746b5 on 11.x 
    Issue #3291904 by quietone, Spokje: Create a test for a dev release...
catch’s picture

catch
he/him
Primary language English
commented
Version: 11.x-dev » 10.2.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x and cherry-picked to 10.2.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.