Problem/Motivation

When filtering the redirects based on multiple filters they need to be reset manually by deselecting them.
Default

Proposed resolution

Enable the reset button for Redirect View.
Reset Button

CommentFileSizeAuthor
#7 Screen Shot 2023-08-09 at 2.10.38 AM.png123.78 KBkristen pol
#7 Screen Shot 2023-08-09 at 2.10.24 AM.png931.67 KBkristen pol
#7 Screen Shot 2023-08-09 at 2.07.30 AM.png454.27 KBkristen pol
#4 Redirect reset.png88.83 KBameymudras
#3 Screenshot 2022-06-22 at 2.14.14 PM.png50.05 KBjoshua1234511
Screenshot 2022-06-22 at 2.08.38 PM.png56.93 KBjoshua1234511

Issue fork redirect-3291885

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

joshua1234511 created an issue. See original summary.

joshua1234511 opened merge request !34

joshua1234511’s picture

joshua1234511
Primary language English
Location Goa
commented
Issue summary: View changes
Status: Active » Needs review
Issue tags: +Needs manual testing
StatusFileSize
new Screenshot 2022-06-22 at 2.14.14 PM.png50.05 KB

Enabled the reset button for Redirect View.

ameymudras’s picture

ameymudras commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Redirect reset.png88.83 KB

Tested on Drupal 9.5 and redirect 8.x-1.x

- Issue summary is clear and explains the problem
- Change is relevant and could be very helpful
- The MR solves the issue and after filtering the reset button appears
- Fix also takes care of already installed modules
- Did a code review no issues found

Marking this issue as RTBC

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented
Assigned: Unassigned » kristen pol

Assigning to myself as I'm triaging all RTBC issues.

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented
Issue tags: -Needs manual testing

Thanks for the issue, patch, and review. I think this is a nice UX improvement (and was literally just thinking about this earlier today when testing).

This was tested in #4 so removing tag. I reviewed the code as well and it seemed fine. I'll try a quick test before merging.

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented
StatusFileSize
new Screen Shot 2023-08-09 at 2.07.30 AM.png454.27 KB
new Screen Shot 2023-08-09 at 2.10.24 AM.png931.67 KB
new Screen Shot 2023-08-09 at 2.10.38 AM.png123.78 KB

Seems to work fine. I already had it installed so ran drush updb and the update hook fired as expected.

Kristens-MacBook-Pro:redirect kristenpol$ gits
On branch 8.x-1.x
Your branch is up to date with 'origin/8.x-1.x'.

nothing to commit, working tree clean
Kristens-MacBook-Pro:redirect kristenpol$ wget https://git.drupalcode.org/project/redirect/-/merge_requests/34.diff
--2023-08-09 02:04:50--  https://git.drupalcode.org/project/redirect/-/merge_requests/34.diff
Resolving git.drupalcode.org (git.drupalcode.org)... 151.101.2.217, 151.101.66.217, 151.101.130.217, ...
Connecting to git.drupalcode.org (git.drupalcode.org)|151.101.2.217|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 1262 (1.2K) [text/plain]
Saving to: ‘34.diff’

34.diff                                   100%[====================================================================================>]   1.23K  --.-KB/s    in 0s      

2023-08-09 02:04:51 (25.1 MB/s) - ‘34.diff’ saved [1262/1262]

Kristens-MacBook-Pro:redirect kristenpol$ patch -p1 < 34.diff 
patching file config/install/views.view.redirect.yml
patching file redirect.install
Kristens-MacBook-Pro:redirect kristenpol$ ddupdb
 ---------- ----------- --------------- ----------------------------------------------- 
  Module     Update ID   Type            Description                                    
 ---------- ----------- --------------- ----------------------------------------------- 
  redirect   8109        hook_update_n   8109 - Enable reset button for Redirect View.  
 ---------- ----------- --------------- ----------------------------------------------- 


 Do you wish to run the specified pending updates? (yes/no) [yes]:
 > 

>  [notice] Update started: redirect_update_8109
>  [notice] Update completed: redirect_update_8109
 [success] Finished performing updates.
Kristens-MacBook-Pro:redirect kristenpol$ ddcr
 [success] Cache rebuild complete.

  • Kristen Pol committed be7ec21a on 8.x-1.x 
    Issue #3291885 by joshua1234511, Kristen Pol, ameymudras: Enable the...
kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented
Assigned: kristen pol » Unassigned
Status: Reviewed & tested by the community » Fixed

Merged. This will be in the next release. Thanks, everyone!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.