I have used the latest version and it works correctly but in the README file indicates an old version.

Issue fork ckeditor_advanced_tab-3291760

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

dpineda created an issue. See original summary.

dpineda opened merge request !5

dpineda’s picture

dpineda commented
Issue summary: View changes
Status: Active » Reviewed & tested by the community
smulvih2’s picture

smulvih2
Location Canada 🍁
commented

@dpineda thanks for submitting this issue! Will look at testing the latest version in the next few days and cut a new version of the module with this change as well as Drupal 10 compatibility so people can start testing in D10.

dpineda’s picture

dpineda commented

Great!

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Reviewed & tested by the community » Needs work

Drupal 9.3.x comes with CKEditor release 4.18.0. Only the Advanced Tab for Dialogs plugin release 4.18 is compatible with that release.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Title: Update version of the library in the README » The documentation suggests to use a release of the plugin that isn't compatible with the CKEditor release used by Drupal 9.3.x
Category: Task » Bug report
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented

Drupal 10 will use CKEditor 5. If there isn't a release of the Advanced Tab for Dialogs plugin for CKEditor 5, this module cannot have a release compatible with Drupal 10.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Title: The documentation suggests to use a release of the plugin that isn't compatible with the CKEditor release used by Drupal 9.3.x » The documentation suggests to use a release of the plugin that isn't compatible with the CKEditor release used by Drupal
dpineda’s picture

dpineda commented

hi! The problem I reported has to do with the current documentation for D8 and D9 being out of date. I think when it's ready for CKEditor 5 it will have to be updated again. For Drupal 10 there are still a few months left.

Right now the important thing is Drupal 8/9 and that people can easily download the latest library. It is my opinion.

Greetings.

  • apaderno committed fa68a35 on 2.0.x 
    Issue #3291760 by dpineda, apaderno: The documentation suggests to use a...

  • apaderno committed ec1959e on 8.x-1.x 
    Issue #3291760 by dpineda, apaderno: The documentation suggests to use a...
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Version: 2.0.x-dev » 8.x-1.x-dev
Assigned: dpineda » Unassigned
Status: Needs work » Fixed

I have updated the release shown in the README.md file and added a note about installing a more recent plugin release.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

julien closed merge request !5