Problem/Motivation

CKEditor schema has the wrong label associated for ckeditor5.plugin.media_media. Should say 'Media' instead of 'Label'? https://git.drupalcode.org/project/drupal/-/blob/9.5.x/core/modules/cked...

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#6 Screenshot from 2022-06-20 17-22-23.png39.69 KBdikshi suthar
#3 incorrect-ckeditor-schema-label-3291295-3.patch548 bytesishani patel

Comments

Webbeh created an issue. See original summary.

ishani patel’s picture

ishani patel commented
Assigned: Unassigned » ishani patel
ishani patel’s picture

ishani patel commented
StatusFileSize
new incorrect-ckeditor-schema-label-3291295-3.patch548 bytes

Hello @Webbeh

I have updated the CKEditor schema label.

Kindly check the patch and let me know if any changes.

Thanks

ishani patel’s picture

ishani patel commented
Assigned: ishani patel » Unassigned
Status: Active » Needs review
dikshi suthar’s picture

dikshi suthar commented
Assigned: Unassigned » dikshi suthar

i will review this.

dikshi suthar’s picture

dikshi suthar commented
StatusFileSize
new Screenshot from 2022-06-20 17-22-23.png39.69 KB

Hi @Ishani ,
I have reviewed patch and it is applied correctly.

dikshi suthar’s picture

dikshi suthar commented
Assigned: dikshi suthar » Unassigned
dikshi suthar’s picture

dikshi suthar commented
Status: Needs review » Reviewed & tested by the community
Webbeh’s picture

Webbeh
he/him/his
Location Georgia, USA
commented

Thanks, y'all. Looks good to me.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

Yes! Great catch! 👍😊

  • catch committed 0419368 on 10.0.x 
    Issue #3291295 by Ishani Patel, Webbeh: Incorrect ckeditor5.plugin....
  • catch committed c60c4fc on 10.1.x
    Issue #3291295 by Ishani Patel, Webbeh: Incorrect ckeditor5.plugin....
  • catch committed 985a8fe on 9.4.x
    Issue #3291295 by Ishani Patel, Webbeh: Incorrect ckeditor5.plugin....
  • catch committed d02015f on 9.5.x
    Issue #3291295 by Ishani Patel, Webbeh: Incorrect ckeditor5.plugin....
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

@Dikshi Suthar just a note that there's no need to post a screenshot that the patch applies cleanly - the automated test run against the patch already confirms this. More important to check that what the patch itself does is correct.

Committed/pushed to 10.1.x, and cherry-picked back through to 9.4.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.