Hello project maintainers,
This is an automated issue to help make this module compatible with Drupal 10.
To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects
Patches will periodically be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD10" tag from the issue to stop the bot from posting updates.
The patches will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.
You have a few options for how to use this issue:
If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.
As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.
Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot patches. The bot will still post new patches then if there is a change in the new generated patch compared to the patch that the bot posted last. Those changes are then up to humans to integrate.
If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated patches, remove the "ProjectUpdateBotD10" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.
If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated patches will be posted here.
If the issue is reopened, then new automated patches will be posted.
If you are using another issue(s) to work on Drupal 10 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.
Using the patches
If there are problems with one of the patches posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.
| Comment | File | Size | Author |
|---|---|---|---|
| #18 | upgrade_status.3.x-dev.rector.patch | 7.41 KB | project update bot |
| #18 | interdiff-last-bot.6675916.txt | 2.41 KB | project update bot |
| #8 | upgrade_status.3.x-dev.rector.patch | 7.41 KB | project update bot |
| #8 | interdiff-last-bot.6664426.txt | 72 bytes | project update bot |
| #6 | 3290244-6.patch | 7.87 KB | sharayurajput |
Comments
Comment #2
project update bot commentedThis is an automated patch generated by Drupal Rector. Please see the issue summary for more details.
It is important that any automated tests available are run with this patch and that you manually test this patch.
Drupal 10 Compatibility
According to the Upgrade Status module, even with this patch, this module is not yet compatible with Drupal 10.
Currently Drupal Rector, version 0.12.0, cannot fix all Drupal 10 compatibility problems.
This patch does not update the
info.ymlfile for Drupal 10 compatibility.Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.
Debug info
This patch was created using these packages:
Comment #3
project update bot commentedThis is an automated patch generated by Drupal Rector. Please see the issue summary for more details.
It is important that any automated tests available are run with this patch and that you manually test this patch.
Drupal 10 Compatibility
According to the Upgrade Status module, even with this patch, this module is not yet compatible with Drupal 10.
Currently Drupal Rector, version 0.13.0, cannot fix all Drupal 10 compatibility problems.
This patch does not update the
info.ymlfile for Drupal 10 compatibility.Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.
Debug info
This patch was created using these packages:
Comment #4
gábor hojtsyThe main question is does this break Drupal 8 compatibility? We currently support Drupal 8 as the key tool to get out of Drupal 8 :) Having two separate banches to support Drupal 8 and 9/10 would be sad, if we can avoid it.
Comment #5
sharayurajput commentedI will work on this
Comment #6
sharayurajput commentedComment #8
project update bot commentedThis is an automated patch generated by Drupal Rector. Please see the issue summary for more details.
It is important that any automated tests available are run with this patch and that you manually test this patch.
Drupal 10 Compatibility
According to the Upgrade Status module, even with this patch, this module is not yet compatible with Drupal 10.
Currently Drupal Rector, version 0.13.0, cannot fix all Drupal 10 compatibility problems.
This patch does not update the
info.ymlfile for Drupal 10 compatibility.Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.
Debug info
This patch was created using these packages:
Comment #9
pasquallehttps://www.drupal.org/node/2940438
drupal_get_path() replacement service was introduced in Drupal 9.3.0, so the patch does break the compatibility with D8.
Comment #10
gábor hojtsyYeah I was avoiding commiting this for that reason. We don't yet need the module to work on Drupal 10, but then we'll need some UI element to tell people to uninstall upgrade status before moving to Drupal 10. Alternatively we should have conditional code for Drupal 8 support, if its only about drupal_get_path(). What about the rest of the patch?
Comment #11
pasqualleI have updated my site to Drupal 10, and removed some incompatible modules in the process.
Can I use upgrade status with this patch on D10, to test/prepare those modules for D10?
Comment #12
pasqualleThe report page seems to be working.
The following error is displayed when trying to scan:
Fatal error: Declaration of Drupal\upgrade_status\CookieJar::withCookieHeader(Psr\Http\Message\RequestInterface $request) must be compatible with GuzzleHttp\Cookie\CookieJarInterface::withCookieHeader(Psr\Http\Message\RequestInterface $request): Psr\Http\Message\RequestInterface in /var/www/html/web/modules/contrib/upgrade_status/src/CookieJar.php on line 284Comment #13
gábor hojtsy@Pasqualle: no, on Drupal 10 the deprecated APIs are removed, so they will not be detected with code analysis due to the missing definitions. The definitions are in core and modules not in Upgrade Status. That means you cannot use Upgrade Status on Drupal 10 to get ready for Drupal 10. You will be using it to get ready for Drupal 11, but that is not yet timely :)
Comment #14
pasqualleAfter fixing the function return types in upgrade_status/src/CookieJar.php the scan seems to be working.
But to my question: the scan is checking against Drupal 11, the next major Drupal version. To scan against Drupal 10, the ProjectCollector::getDrupalCoreMajorVersion() needs to be hacked to return 9.
Comment #15
pasquallehmm, ok, so my try to make it useful was futile..
Thanks Gabor
Comment #16
gábor hojtsyYeah hacking
ProjectCollector::getDrupalCoreMajorVersion()would not make the removed APIs magically appear :)Comment #17
project update bot commentedUpdating bot issue summary.See #3313904: Update project bot templates for RTBC status support and human interaction tips
Comment #18
project update bot commentedThis is an automated patch generated by Drupal Rector. Please see the issue summary for more details.
It is important that any automated tests available are run with this patch and that you manually test this patch.
Drupal 10 Compatibility
According to the Upgrade Status module, even with this patch, this module is not yet compatible with Drupal 10.
Currently Drupal Rector, version 0.13.1, cannot fix all Drupal 10 compatibility problems.
Therefore this patch does not update the
info.ymlfile for Drupal 10 compatibility.Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.
Debug info
This patch was created using these packages:
Comment #19
gábor hojtsyComment #20
gábor hojtsyThere are also further considerations in #3328786: Upgrade status must be uninstalled before upgrading to Drupal 10, including dependencies that would need to be updated/reevaluated, so its not even limited to just the code of the module itself apparently.
Comment #21
gábor hojtsySort of merged in the patch from #3328786: Upgrade status must be uninstalled before upgrading to Drupal 10, where I don't agree with the directional change, but its not productive IMHO to go argue there. I updated the info file to NOT be Drupal 8 compatible anymore. We can't test Upgrade Status anymore on Drupal 8 on d.o so we can't quite make sure it will work. I opened a new branch, so we have a branch that keeps Drupal 8 compatibility.
I also added BC layers for drupal_get_path() so the info file is true that it works on any version of Drupal 9.