Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects

Patches will periodically be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD10" tag from the issue to stop the bot from posting updates.

The patches will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot patches. The bot will still post new patches then if there is a change in the new generated patch compared to the patch that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated patches, remove the "ProjectUpdateBotD10" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.

Issue fork typogrify-3290195

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

Project Update Bot created an issue. See original summary.

project update bot’s picture

Status: Active » Needs review
StatusFileSize
new378 bytes

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module this patch makes this module compatible with Drupal 10! 🎉
This patch updates the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #127

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 1.1.9
  2. palantirnet/drupal-rector: 0.12.0
project update bot’s picture

StatusFileSize
new1.37 KB
new927 bytes

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module, even with this patch, this module is not yet compatible with Drupal 10.

Currently Drupal Rector, version 0.13.1, cannot fix all Drupal 10 compatibility problems.

This patch does not update the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #145

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 1.1.25
  2. palantirnet/drupal-rector: 0.13.1
neffets’s picture

Issue summary: View changes

Patch seems OK, please merge.

For "core"-line discussion see issue #3126073

neffets’s picture

project update bot’s picture

prudloff’s picture

Issue summary: View changes
StatusFileSize
new2.22 KB

Here is patch combining #2 and #3 with some additional fixes.

Dmitriy.trt made their first commit to this issue’s fork.

dmitriy.trt’s picture

Created an MR with the patch of #7.

  • benjifisher committed 06a4e01a on 8.x-1.x authored by prudloff
    Issue #3290195 by Project Update Bot, Dmitriy.trt, prudloff, neffets,...
benjifisher’s picture

Status: Needs review » Fixed

Thanks to all: I credited everyone who commented on this issue.

@neffets: next time, please give more detail. Did you review? Did you test? What steps did you use?

I credited @Dmitriy.trt because having the MR is helpful for users to install the module before there is a compatible release.

I installed the module on Drupal 9.5 and tested with the upgrade_status module. It recommended the changes in #7 for the Twig filter. Does anyone have a reference for these changes?

Class Drupal\typogrify\TwigExtension\Typogrify extends deprecated class Twig_Extension: since Twig 2.7, use "Twig\Extension\AbstractExtension" instead

and

Instantiation of deprecated class Twig_SimpleFilter: since Twig 2.7, use "Twig\TwigFilter" instead

Unfortunately, I never added test coverage for the Twig filters, so I tested manually. Still using Drupal 9.5, I used the typogrify Twig filter in a view, then added this text to a node:

Test Typogrify: 'single quotes', "double quotes", CAPS & t.l.a. and--don't forget---dashes.

Looking at the page source, that was converted like this:

Test Typogrify: ‘single quotes’, “double quotes”, <span class="caps">CAPS</span> <span class="amp">&amp;</span> t.l.a. and — don’t&nbsp;forget — -dashes.

Then I upgraded Drupal core to 10.1.x, applied the patch from #7, executed database updates, and reloaded the page. I saw exactly the same processed text in the page source.

I will create a new release with just this update, then maybe add another issue or two to the 8.x-1.x branch.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.