Automated Drupal 10 compatibility fixes [#3288984]

Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects

Patches will periodically be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD10" tag from the issue to stop the bot from posting updates.

The patches will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

Accept automated patches until this issue is closed
If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot patches. The bot will still post new patches then if there is a change in the new generated patch compared to the patch that the bot posted last. Those changes are then up to humans to integrate.
Leave open but stop new automated patches.
If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated patches, remove the "ProjectUpdateBotD10" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.
Close it and don't use it
If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated patches will be posted here.

If the issue is reopened, then new automated patches will be posted.

If you are using another issue(s) to work on Drupal 10 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.

Comment	File	Size	Author
#18	paragraphs_ee-3288984-18.patch	1010 bytes	deciphered
#12	3288984-12.patch	3.37 KB	stomusic
#10	3288984-10.patch	48.13 KB	stomusic
#9	3288984-9.patch	35.05 KB	jeroent
#8	3288984-8.patch	3.08 KB	jeroent
#7	drupal10-3288984-7.patch	2.08 KB	realityloop
#6	Screen Shot 2022-12-29 at 7.44.31 PM.png	142 KB	sahil.goyal
#3	paragraphs_ee.2.0.x-dev.rector.patch	1.07 KB	project update bot
#3	interdiff-last-bot.6644542.txt	551 bytes	project update bot
#2	paragraphs_ee.2.0.x-dev.rector.patch	578 bytes	project update bot

Issue fork paragraphs_ee-3288984

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

1 hidden branch

feature/3288984-d10

changes, plain diff MR !14

Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

16 June 2022 at 04:18

Project Update Bot created an issue. See original summary.

Comment #2

project update bot commented 16 June 2022 at 04:18

Status:

Active

» Needs review

Status	File	Size
new	paragraphs_ee.2.0.x-dev.rector.patch	578 bytes

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module, even with this patch, this module is not yet compatible with Drupal 10.

Currently Drupal Rector, version 0.12.0, cannot fix all Drupal 10 compatibility problems.

This patch does not update the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #127

This patch was created using these packages:

mglaman/phpstan-drupal: 1.1.9
palantirnet/drupal-rector: 0.12.0

Comment #3

project update bot commented 23 July 2022 at 17:28

Status	File	Size
new	interdiff-last-bot.6644542.txt	551 bytes
new	paragraphs_ee.2.0.x-dev.rector.patch	1.07 KB

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module, even with this patch, this module is not yet compatible with Drupal 10.

Currently Drupal Rector, version 0.13.0, cannot fix all Drupal 10 compatibility problems.

This patch does not update the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #139

This patch was created using these packages:

mglaman/phpstan-drupal: 1.1.24
palantirnet/drupal-rector: 0.13.0

Comment #4

project update bot commented 17 October 2022 at 17:32

Issue summary:

View changes

Updating bot issue summary.See #3313904: Update project bot templates for RTBC status support and human interaction tips

Comment #5

drupalmatts commented 21 December 2022 at 20:07

Issue summary:

View changes

Is there any progress on Drupal 10 fixes being released? This is a dependent module for one of mine...

Comment #6

sahil.goyal commented 30 December 2022 at 05:04

Status	File	Size
new	Screen Shot 2022-12-29 at 7.44.31 PM.png	142 KB

Hi @DrupalMattS, i have successfully tested the patch for the drupal 10 it is compatible with it and working seamlessly and as expected after applying the Auto-bot Created patch, i'm also attaching the Screenshot along with the comment.

It is being ready to +1 RTBC.

Comment #7

realityloop commented 19 January 2023 at 00:18

Status	File	Size
new	drupal10-3288984-7.patch	2.08 KB

re-rolled to include info file compatibility updates

Comment #8

jeroent

Dutch

🇧🇪

commented 21 January 2023 at 21:42

Status	File	Size
new	3288984-8.patch	3.08 KB

I've added 2 extra changes:

I updated the composer.json to allow Drupal 10 and paragraph_features V2, since that version supports Drupal 10.

The 2nd change: #drupal-off-canvas is updated.
See https://www.drupal.org/node/3305664

Comment #9

jeroent

Dutch

🇧🇪

commented 21 January 2023 at 21:47

Status	File	Size
new	3288984-9.patch	35.05 KB

And run yarn compile ...

Comment #10

stomusic

Ukraine

commented 23 January 2023 at 20:41

Status	File	Size
new	3288984-10.patch	48.13 KB

I've re-check patch #9 and see that it not work at Drupal 10. So I've reviewed deprecated hooks and js functions

Comment #11

stborchert

he/him

German

commented 24 January 2023 at 14:12

Version:

2.0.x-dev

» 2.1.x-dev

Wow, thanks for your work. This looks great so far. Using the settings tray for the paragraphs tiles/list is broken, but that hasn't worked for quite a while :/.

I've created a new branch (2.1.x) containing the compatibility fixes. Please review and test.

Comment #12

stomusic

Ukraine

commented 25 January 2023 at 11:46

Status	File	Size
new	3288984-12.patch	3.37 KB

I've re-checked, looks like it works well, but I've added few fixes more(patch).

Comment #13

26 January 2023 at 20:53

stomusic authored 2f4e6016 on 2.1.x

Issue #3288984 by Project Update Bot, stomusic, JeroenT, realityloop:...

Comment #14

stborchert

he/him

German

commented 26 January 2023 at 20:54

Thanks, Aleksander. I've committed your changes and updated Paragraphs Sets also so it seems to work now :)

Comment #15

jeroent

Dutch

🇧🇪

commented 6 February 2023 at 16:57

Great to see progress on this issue!

Is there a plan for a new release? e.g. a 2.1.0-alpha?

Comment #16

deciphered

English

Ballarat, Victoria, Australia

commented 7 February 2023 at 03:20

@stomusic

I ran into the following issue when using the 2.1.x-dev release:

PHP message: Uncaught PHP Exception Drupal\Core\Extension\InfoParserException: "The 'core_version_requirement' constraint (^9 || ^10) requires the 'core' key not be set in modules/contrib/paragraphs_ee/modules/paragraphs_ee_sets/paragraphs_ee_sets.info.yml" at /var/www/html/web/core/lib/Drupal/Core/Extension/InfoParserDynamic.php line 88" while reading response header from upstream, client: 172.21.0.6, server: , request: "GET /admin/reports HTTP/1.1", upstream:

I found both the main and sub-module still had the core: key set. MR incoming.

Comment #17

7 February 2023 at 03:23

Deciphered opened merge request !14

Comment #18

deciphered

English

Ballarat, Victoria, Australia

commented 7 February 2023 at 03:25

Status	File	Size
new	paragraphs_ee-3288984-18.patch	1010 bytes

Comment #19

realityloop commented 9 February 2023 at 22:48

So that I could use it in composer without the need for the patch, allowing me to upgrade to Drupal 10.

The following (or similar) is required in your projects composer.json:

    "repositories": {
        "drupal": {
            "type": "composer",
            "url": "https://packages.drupal.org/8",
            "exclude": [
                "drupal/paragraphs_ee"
            ]
        },
        "drupal/paragraphs_ee": {
            "type": "git",
            "url": "https://git.drupalcode.org/issue/paragraphs_ee-3288984.git"
        }
    },

Then add the module using: composer require drupal/paragraphs_ee:dev-feature/3288984-d10

I hope this is helpful to others.

Comment #20

10 February 2023 at 08:50

Deciphered authored 7982cd84 on 2.1.x

Issue #3288984 by Deciphered: Automated Drupal 10 compatibility fixes

Comment #21

stborchert

he/him

German

commented 10 February 2023 at 08:56

I've removed the "core" key (I don't know why the module installed without problems on my machine ...) and created a release for 2.1.
Thanks all!

Comment #22

stborchert

he/him

German

commented 24 February 2023 at 18:11

Status:

Needs review

» Fixed

Comment #23

10 March 2023 at 18:14

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Comment #24

20 July 2023 at 14:23

stBorchert closed merge request !14

Automated Drupal 10 compatibility fixes

Problem/Motivation

Proposed resolution

Remaining tasks

Providing feedback

Issue fork paragraphs_ee-3288984

Comments

Drupal 10 Compatibility

Debug info

Drupal 10 Compatibility

Debug info

Referenced by