Problem/Motivation

The links in the status message force horizontal scrolling on narrow viewports which violates Success Criterion 1.4.10: Reflow

Steps to reproduce

Proposed resolution

Remaining tasks

  • ✅ File an issue about this project
  • ☐ Manual Testing
  • ☐ Code Review
  • ☐ Accessibility Review
  • ☐ Automated tests needed/written?
CommentFileSizeAuthor
#9 after.png43.27 KBomkar-pd
#8 image (22).png67.44 KBlibbna
links-status-message.png115.95 KBbnjmnm

Issue fork project_browser-3285443

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

bnjmnm created an issue. See original summary.

libbna’s picture

libbna commented
Assigned: Unassigned » libbna

I will work on this.

libbna’s picture

libbna commented

I have found the solution but wanted to confirm should I make the changes specifically for project browser by adding classes in svelte or for a claro theme? Because the issue is in the claro theme.

bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented

Project Browser currently has a seven.css stylesheet for fixes specific to Seven. I'd say do the same for Claro. I assume both of them will get moved to the actual themes when Project Browser is added to core, but this is a good way to keep them sorted until that can happen.

libbna’s picture

libbna commented

So you're saying like seven.css, I should create claro.css for Project Browser and do the changes in that, right or I can add a class in svelte and then do the changes?

bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented

Create claro.css and add the styles necessary for Claro. Try not to alter the Svelte app unless it's absolutely necessary. This way, when Project Browser gets moved to core, we can move the claro.css styles to Claro (and seven.css to seven). Ideally we'd change the themes right now but we can't add styles in core for contrib modules.

Libbna opened merge request !165

libbna’s picture

libbna commented
Status: Active » Needs review
StatusFileSize
new image (22).png67.44 KB

added word-break css attribute to solve this issue.

omkar-pd’s picture

omkar-pd commented
Assigned: libbna » Unassigned
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new after.png43.27 KB

As per #6, claro.css is created and it fixes the issue. hence, Moving this to RTBC.

  • bnjmnm committed 46d4910 on 1.0.x authored by Libbna 
    Issue #3285443 by Libbna, bnjmnm, omkar-pd: Links in status message...
bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented
Status: Reviewed & tested by the community » Fixed

Looks good! Merged.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.