Since the module depends on Drupal Commerce, we should have a composer.json file that would ensure the required modules are installed when installing this module.

Issue fork magento-3285286

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

gaurav.kapoor created an issue. See original summary.

vighneshh’s picture

vighneshh commented
Assigned: Unassigned » vighneshh

Vighnesh. opened merge request !4

vighneshh’s picture

vighneshh commented
Status: Active » Needs review
vighneshh’s picture

vighneshh commented
Assigned: vighneshh » Unassigned
elber’s picture

elber
Primary language Portuguese, Brazil
Location Brazil
commented
Assigned: Unassigned » elber
elber’s picture

elber
Primary language Portuguese, Brazil
Location Brazil
commented
Assigned: elber » Unassigned
Status: Needs review » Needs work

Hi I revised you patch my unique suggestion is to add the "authors" at file.

Drupal shows how you can to do it.

https://www.drupal.org/docs/creating-custom-modules/add-a-composerjson-file

Follow this example bellow:

"authors": [
{
"name": "Matthew Donadio (mpdonadio)",
"homepage": "https://www.drupal.org/u/mpdonadio",
"role": "Maintainer"
}

vighneshh’s picture

vighneshh commented
Status: Needs work » Needs review
elber’s picture

elber
Primary language Portuguese, Brazil
Location Brazil
commented
Assigned: Unassigned » elber

I will review it.

elber’s picture

elber
Primary language Portuguese, Brazil
Location Brazil
commented
Assigned: elber » Unassigned
Status: Needs review » Reviewed & tested by the community

Hi I revised your patch and it follow the patterns of this document.

https://www.drupal.org/docs/creating-custom-modules/add-a-composerjson-file

omkar-pd made their first commit to this issue’s fork.

  • omkar-pd committed d582044 on 2.0.x authored by Vighnesh-VS 
    Issue #3285286 by Vighnesh-VS, elber, gaurav.kapoor: Add composer.json...
omkar-pd’s picture

omkar-pd commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.