CommentFileSizeAuthor
#8 dipendancy-injection-updated-3284638-8.patch2.46 KBatul_ghate
#3 implemented-dipendancy-injection-3284638-3.patch2.34 KBatul_ghate

Comments

atul ghate created an issue. See original summary.

atul_ghate’s picture

atul_ghate commented
Assigned: Unassigned » atul_ghate

will work on that issue

atul_ghate’s picture

atul_ghate commented
Assigned: atul_ghate » Unassigned
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new implemented-dipendancy-injection-3284638-3.patch2.34 KB
jatingupta40’s picture

jatingupta40 commented
Assigned: Unassigned » jatingupta40

I will review this patch.

jatingupta40’s picture

jatingupta40 commented
Status: Needs review » Needs work 
+++ b/src/Form/LanguageDropdownForm.php
@@ -82,12 +90,13 @@ class LanguageDropdownForm extends FormBase {
    */

Can you please add the @param comment for the new added $renderer parameter after line number 91.

atul_ghate’s picture

atul_ghate commented

thank you , will work requested changes

atul_ghate’s picture

atul_ghate commented
Assigned: jatingupta40 » atul_ghate
atul_ghate’s picture

atul_ghate commented
Assigned: atul_ghate » Unassigned
Status: Needs work » Needs review
StatusFileSize
new dipendancy-injection-updated-3284638-8.patch2.46 KB

i have attached updated patch please review.

indrapatil’s picture

indrapatil commented
Status: Needs review » Reviewed & tested by the community

Hi,
I have reviewed you are patch working for me.

kala4ek’s picture

kala4ek
Primary language Russian
Location 🇷🇺 Novosibirsk
commented
Assigned: Unassigned » kala4ek

  • kala4ek committed 9343b57 on 8.x-2.x authored by atul ghate 
    Issue #3284638 by atul ghate, JatinGupta40, Indra patil, kala4ek:...
kala4ek’s picture

kala4ek
Primary language Russian
Location 🇷🇺 Novosibirsk
commented
Assigned: kala4ek » Unassigned
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

rajab natshah’s picture

rajab natshah
he/him
commented
Issue tags: +lang_dropdown-8.x-2.1
rajab natshah’s picture

rajab natshah
he/him
commented

✅ Released lang_dropdown-8.x-2.1