Problem/Motivation

As seen in exaggerated form in this video (it's on a throttled connection), the load process is already significantly underway before a "loading" spinner even appears. This is because the spinner doesn't show up until Svelte has initialized. That can take a while sometimes! If \Drupal\project_browser\Controller\BrowserController provides a no-js spinner that is removed once PB is fully initialized, users will have a better sense of what is going on and things will feel less laggy (even if they take the same amount of time).

Right now, even on a fast connection, there's a laggy white screen of nothing before PB kicks in. This should help address that.

Steps to reproduce

Proposed resolution

Remaining tasks

  • ✅ File an issue about this project
  • ☐ Manual Testing
  • ☐ Code Review
  • ☐ Accessibility Review
  • ☐ Automated tests needed/written?
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

bnjmnm created an issue. See original summary.

narendrar’s picture

Assigned: Unassigned » narendrar

narendrar’s picture

Assigned: narendrar » Unassigned

Used html of Loading.svelte for loader.

narendrar’s picture

Status: Active » Needs review
bnjmnm’s picture

Status: Needs review » Needs work

This is a great improvement. However, it requires Claro in order to appear. I left details in the MR how to potentially address.

narendrar’s picture

Status: Needs work » Needs review
fjgarlin’s picture

Status: Needs review » Needs work

I added some feedback in the MR. It's mostly about moving the HTML markup from the controller and into a template.

narendrar’s picture

Status: Needs work » Needs review
fjgarlin’s picture

Status: Needs review » Reviewed & tested by the community

Code looks good and the functionality too. Marking RTBC, thanks!

  • bnjmnm committed 312cdad on 1.0.x authored by narendraR
    Issue #3284341 by narendraR: BrowserController render array should...
bnjmnm’s picture

Status: Reviewed & tested by the community » Fixed

This is a great improvement. Merged!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.