Problem/Motivation
As seen in exaggerated form in this video (it's on a throttled connection), the load process is already significantly underway before a "loading" spinner even appears. This is because the spinner doesn't show up until Svelte has initialized. That can take a while sometimes! If \Drupal\project_browser\Controller\BrowserController provides a no-js spinner that is removed once PB is fully initialized, users will have a better sense of what is going on and things will feel less laggy (even if they take the same amount of time).
Right now, even on a fast connection, there's a laggy white screen of nothing before PB kicks in. This should help address that.
Steps to reproduce
Proposed resolution
Remaining tasks
- ✅ File an issue about this project
- ☐ Manual Testing
- ☐ Code Review
- ☐ Accessibility Review
- ☐ Automated tests needed/written?
Issue fork project_browser-3284341
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
narendrarComment #4
narendrarUsed html of
Loading.sveltefor loader.Comment #5
narendrarComment #6
bnjmnmThis is a great improvement. However, it requires Claro in order to appear. I left details in the MR how to potentially address.
Comment #7
narendrarComment #8
fjgarlin commentedI added some feedback in the MR. It's mostly about moving the HTML markup from the controller and into a template.
Comment #9
narendrarComment #10
fjgarlin commentedCode looks good and the functionality too. Marking RTBC, thanks!
Comment #12
bnjmnmThis is a great improvement. Merged!