Problem/Motivation

There are several @todos in the current svelte code that point to unused components. This issue is for removing them. Also would probably be good to go through each svelte file and just remove other potential unused components/variables.

Steps to reproduce

Proposed resolution

Remaining tasks

  • ✅ File an issue about this project
  • ☐ Manual Testing
  • ☐ Code Review
  • ☐ Accessibility Review
  • ☐ Automated tests needed/written?

Issue fork project_browser-3284092

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

hooroomoo created an issue. See original summary.

hooroomoo’s picture

hooroomoo
they/them
Location nyc🗽
commented
Title: Remove unused svelte components » Remove unused svelte components and variables
hooroomoo’s picture

hooroomoo
they/them
Location nyc🗽
commented
Assigned: Unassigned » hooroomoo

hooroomoo opened merge request !142

hooroomoo’s picture

hooroomoo
they/them
Location nyc🗽
commented
Assigned: hooroomoo » Unassigned
Status: Active » Needs review
hooroomoo’s picture

hooroomoo
they/them
Location nyc🗽
commented
Issue tags: +Project Browser MVP

i dont think this is an MVP requirement but adding the tag for board visibility

narendraR made their first commit to this issue’s fork.

narendrar’s picture

narendrar
He/Him
Primary language English
Location Jaipur, India
commented
Status: Needs review » Reviewed & tested by the community

All the @todo's are removed except state.closeButton which is handled in https://www.drupal.org/project/project_browser/issues/3284094.
Tested manually and all functionality is working as expected, hence marking as RTBC.

bnjmnm made their first commit to this issue’s fork.

  • bnjmnm committed 111487a on 1.0.x authored by hooroomoo 
    Issue #3284092 by hooroomoo, narendraR: Remove unused svelte components...
bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented
Status: Reviewed & tested by the community » Fixed

A nice grab bag of cruft removal. Merged!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.