Problem/Motivation

We've got a client who needs to be able to add users and also add the IP range. But they shouldn't be able to change the configuration. We've got configuration saved in the git repo where we deploy config changes from development to production. We want to avoid overwriting changes our client makes on production.

The other advantage of storing it in the database is that it can better handle users being added/removed.

Issue fork restrict_by_ip-3283846

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

nubeli created an issue. See original summary.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Related issues: +#3419590: Option for including a IP Database?

This sounds similar to #3419590: Option for including a IP Database??

Maybe it would be better to NOT change the module regarding this and instead allow third party modules to interact through service replacement or hooks?

darvanen’s picture

darvanen
he/him
Primary language English
Location Sydney, Australia
commented
Version: 8.x-4.x-dev » 9.x-dev

I agree on the duplication, I've closed the other issue as this one is older.

I also agree that this requires an extension point rather than a change to this module.

darvanen’s picture

darvanen
he/him
Primary language English
Location Sydney, Australia
commented

Hm... Specifically per-user might be better served in the DB where users live... I'll give this some more thought.

darvanen’s picture

darvanen
he/him
Primary language English
Location Sydney, Australia
commented

Yeah after consideration I think this is a reasonable request. Users can change from environment to environment, matching that with config is a pain.

I'll reopen the other issue for the extension point work.

darvanen’s picture

darvanen
he/him
Primary language English
Location Sydney, Australia
commented
Assigned: Unassigned » darvanen

darvanen opened merge request !27

darvanen’s picture

darvanen
he/him
Primary language English
Location Sydney, Australia
commented
Assigned: darvanen » Unassigned
Status: Active » Needs review

I'll leave this for a few days, but I'm keen to keep going on the backlog and most things overlap so I want to merge this before doing much more.

  • darvanen committed 595da516 on 9.x 
    feat: #3283846 Store per user IP range in database instead of config

By...
darvanen’s picture

darvanen
he/him
Primary language English
Location Sydney, Australia
commented
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.