Problem/Motivation

Releases endpoint and information is not really used anywhere in the frontend. We should simplify the backend and the plugins as there is a lot of logic that can go into managing and querying this.

It might still be needed for the mock and for generating fixtures, but there is definitely some code that can and should go away.

Steps to reproduce

Releases endpoint is never queried by the front end.

Proposed resolution

Clean up unused code related to releases.

Remaining tasks

  • ✅ File an issue about this project
  • ☐ Manual Testing
  • ☐ Code Review
  • ☐ Accessibility Review
  • ☐ Automated tests needed/written?

Issue fork project_browser-3283825

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

fjgarlin created an issue. See original summary.

fjgarlin opened merge request !132

chrisfromredfin’s picture

chrisfromredfin
he/him/his
Primary language English
Location Portland, Maine
commented

Instructions for regenerating the fixture can be found in the _hacky_fixture function in the .install file.

fjgarlin’s picture

fjgarlin commented
Status: Active » Needs review

bnjmnm made their first commit to this issue’s fork.

bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented
Status: Needs review » Reviewed & tested by the community

Because so much is being removed, I tried to find anywhere there might be issue, but manual tests, running fixture updates and (obviously) automated tests all seem to work fine. I did some grepping to see if anything else could be removed but didn't find anything additional.

I started remembering how this endpoint was used from my week on Project Browser in 2021. It added a ton of additional requests to every Project Browser load. If we start incorporating release data into our queries again hopefully there's a way to minimize the number of additional requests, either via optimizations in the Project Browser module or via the capabilities of the new D.O. endpoint.

Anyway, looks like a good cleanup!

bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented
Assigned: fjgarlin » Unassigned
chrisfromredfin’s picture

chrisfromredfin
he/him/his
Primary language English
Location Portland, Maine
commented
Status: Reviewed & tested by the community » Fixed

Good cleanup! Manually tested again just to try and spot regressions. Shipping it!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.