Problem/Motivation
See #2045.
Steps to reproduce
Proposed resolution
- Update
core/package.json cd coreyarn installyarn buildyarn build:ckeditor5-types
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
The version of CKEditor 5 has been updated from 35.3.1 to 35.3.2. This fixed the last known CKEditor 5 accessibility issue: #3283802: Update CKEditor 5 to 35.3.2 to fix voice control/IME on some platforms.
| Comment | File | Size | Author |
|---|---|---|---|
| #24 | 3283802-24-D9.4.patch | 1.34 MB | wim leers |
| #24 | 3283802-24-D9.5.patch | 1.34 MB | wim leers |
| #24 | 3283802-24-D10.patch | 1.34 MB | wim leers |
Comments
Comment #3
wim leersBased on analysis of https://github.com/ckeditor/ckeditor5/labels/domain%3Aaccessibility by @bnjmnm ~2 weeks ago. @bnjmnm is an accessibility maintainer of Drupal core.
Crediting @bnjmnm.
Comment #4
wim leersFix copy/paste error resulting in the wrong upstream issue being linked 🙈
Comment #5
xjmComment #6
wim leersChecked the status of this together with @nod_ and @lauriii.
No movement upstream yet. Will ask the CKE5 team in the next meeting.
Comment #7
wim leersUpdate: there is massive movement actually, it's just that there's one final huge roadblock: dictation (and IME) work fine everywhere, with one exception: Android.
Apparently every Android keyboard does things in its own way, there's no standardization whatsoever. They're working very hard on finding a work-around.
They absolutely need this for their customers too though, so it's 100% certain a solution will ship before mid-December (they don't do releases at the end of December). Worst case, they'll create a forked implementation: one specifically for Android, one for every other platform.
Best case is that they can finalize their current approach (and get it working on Android). They estimate it's ~30% likely they'll ship it in the September release.
So a solution is in progress! 😊
@bnjmnm will post a comment with his recommendations on how to proceed.
Comment #8
bnjmnmSo we have to decide if this stable-blocks CKEditor 5, thus not allowing it to be stable in the D10 beta
Because I've worked so closely with Drupal's CKEditor 5 integration, it would be ideal if another accessibility maintainer could provide a recommendation. I have my own thoughts on how to address, but I'd like to yield to anyone that isn't influenced by many months working on this.
Some highlights to consider
With the above in mind, is it acceptable to mark the CKEditor 5 as stable before the Beta release in early Sept, knowing that the Dictation / IME fix will not be ready by then, but is highly likely to exist before the D10 rc (+ knowing there is a workaround that makes dictation/IME work with some additioal effort)
Comment #9
bnjmnmRegarding this being a beta blocker: I spoke to @mgifford about this and his suggestion was one I like better than any of the options I'd thought of.
Given the following:
It would be acceptable to mark this stable IF the CKSource agrees to continue supporting CKEditor 4 until the dictation/IME problems are addressed in CKEditor 5, even if this means having to delay EOL.
(I'd also add that I'd like to make the likely-to-be-fixed-soon dictation problem very evident in release notes, etc. so site owners can test their D10 sites with the CKEditor 4 module in case that becomes necessary.)
Comment #10
bnjmnmComment #11
mgiffordI'd love to see CKSource commit to maintaining CKEditor 4 as long as there are accessibility errors in 5 that weren't in 4. Authors are depending on using CKEditor and we don't want to suddenly give authors no ability to create content through our WYSIWYG. Any reversion in accessibility is serious!
I am also hopeful that this will be fixed in CKEditor 5 before it goes into production. We absolutely want to have users with disabilities testing the beta, but my main concern is that sites start upgrading to Drupal 10 and we start blocking folks off from editing their content.
I would also want to ensure that if CKEditor 5 isn't fixed in time that we include this work around to reverting to CKEditor 4 in our release notes until it is fixed.
I was not able to replicate this bug on my Mac's Voice Control tool & Edge.
Comment #12
wim leers👍 Yes, so are we! See #7 & #9!
👍 That's already the case — see https://www.drupal.org/node/3304481.
Are you saying that dictation worked fine in that combination? 😊
Comment #13
xjmComment #15
wim leersJust met with @Reinmar from CKSource … great news! 😊
They've made a ton of progress! 👍
This is highly likely to be fixed by the November release of CKEditor 5, and quite possibly already in the October release (code freeze October 26, actual release on November 2 — see https://github.com/ckeditor/ckeditor5/issues/12565). 🤞
Comment #16
effulgentsia commentedFYI that there's some recent discussion about this bug in https://github.com/ckeditor/ckeditor5/issues/2045#issuecomment-1295134733 and later comments. I don't know what the conclusion is yet from those comments, but just linking to it in case anyone following this issue wants to follow that one.
Comment #17
bnjmnmIn the issue mentioned in #16 there was evidence that iOS dictation did not work in CKEditor4, suggesting that CKEditor 5 may not be experiencing a regression. However, after meeting with CK source, we established that this was due to testing with the iOS keyboard substitute dictation feature, as opposed to the voice control feature, which is how I had been testing this feature. With voice control, there is no problem in CKEditor 4. With the current CKEditor5 release, this is still a problem. I have also confirmed that once the changes here have landed, this will be fixed.
Comment #18
wim leersAlso:
It's the first that @bnjmnm has been reviewing, in his role as a Drupal core accessibility maintainer.
🥳 That means the upstream bugfix has happened, we're now just awaiting a release!
The CKEditor 5 team has indicated that they will do an interim patch release, around the 23rd of November.
Comment #19
effulgentsia commented@catch, @bnjmnm, @Gábor Hojtsy, and I discussed this. Given #18, we're not going to block Drupal 10's RC1 on this, and will instead target it for RC2, or whichever RC number we're on when that CKE5 patch release is ready.
Comment #20
wim leersUpdate from the CKE5 team:
35.3.2will be released on Nov 22 to unblock this issue! 🥳I propose we repurpose this issue to do the actual update, since it'll be the last CKE5 update prior to
10.0.0for sure and it will allow us to close this issue :)Comment #21
wim leersFYI previous update was #3321191: update ckeditor5 to v35.3.1.
Comment #22
effulgentsia commentedComment #23
wim leershttps://github.com/ckeditor/ckeditor5/releases/tag/v35.3.2 is out!
Comment #24
wim leersI applied the steps in the issue summary three times: once on
10.0.x(applies to10.1.xcleanly), once for9.5.xand once for9.4.x— just like in the previous CKEditor 5 update in #3321191: update ckeditor5 to v35.3.1.Comment #25
longwaveI get the same changes locally, patch looks good to me, this is good to go if the tests pass.
Comment #27
alexpottCommitted and pushed 279faa2e26 to 10.1.x and 4c16b09caa to 10.0.x. Thanks!
Committed ce4429b and pushed to 9.5.x. Thanks!
Committed 810f211 and pushed to 9.4.x. Thanks!