Problem/Motivation

Right now it's a custom element that assitive tech doesn't know how to process. A <select> does the same thing as a native element that is well recognized.

We need to determine if it's accessible for the sorting to change upon changing the sort value, or if it needs to be accompanied by a button to submit the new sort value. I think the former is fine as long as the new value is conveyed to AT via Drupal.announce(), but it's worth investigating a bit.

Steps to reproduce

Proposed resolution

Remaining tasks

  • ✅ File an issue about this project
  • ☐ Addition/Change/Update/Fix to this project
  • ☐ Testing to ensure no regression
  • ☐ Automated unit/functional testing coverage
  • ☐ Developer Documentation support on feature change/addition
  • ☐ User Guide Documentation support on feature change/addition
  • ☐ Code review from 1 Drupal core team member
  • ☐ Full testing and approval
  • ☐ Credit contributors
  • ☐ Review with the product owner
  • ☐ Release

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork project_browser-3282709

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

hooroomoo created an issue. See original summary.

bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented
Title: Focus needs to be updated when dropdowns are open/closed » The sort dropdown should be a <select> element
Issue summary: View changes

It function

srishtiiee made their first commit to this issue’s fork.

srishtiiee’s picture

srishtiiee commented
Assigned: Unassigned » srishtiiee

srishtiiee opened merge request !138

srishtiiee’s picture

srishtiiee commented
Assigned: srishtiiee » Unassigned
Status: Active » Needs review
narendrar’s picture

narendrar
He/Him
Primary language English
Location Jaipur, India
commented
Status: Needs review » Needs work

Overall looks good to me. 👍
Small nit: select name and label are missing.

srishtiiee’s picture

srishtiiee commented
Status: Needs work » Needs review
narendrar’s picture

narendrar
He/Him
Primary language English
Location Jaipur, India
commented
Status: Needs review » Reviewed & tested by the community
bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented
Status: Reviewed & tested by the community » Needs work

One bit of feedback in the MR to address.

bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented
Issue tags: +Project Browser MVP
srishtiiee’s picture

srishtiiee commented
Status: Needs work » Needs review
bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented
Status: Needs review » Needs work

Left a comment in the MR. The unwanted 'selected' is no longer there 👍, but logic still needs to be added to find the correct option that should get the selected attribute.

bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented
Status: Needs work » Reviewed & tested by the community

The solution results in a more accessible UI and makes it possible to remove a good amount of CSS as well. Win win!

chrisfromredfin made their first commit to this issue’s fork.

chrisfromredfin’s picture

chrisfromredfin
he/him/his
Primary language English
Location Portland, Maine
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.