Problem/Motivation

Moving to categories checkbox by tab does not let the user know it is part of a group of related checkboxes. Although it's apparent visually, assistive tech sees these as unrelated form elements despite them being clearly related. Maybe Fieldset and legend can be used to logically group them together.

Steps to reproduce

Proposed resolution

Remaining tasks

  • ✅ File an issue about this project
  • ☐ Addition/Change/Update/Fix to this project
  • ☐ Testing to ensure no regression
  • ☐ Automated unit/functional testing coverage
  • ☐ Developer Documentation support on feature change/addition
  • ☐ User Guide Documentation support on feature change/addition
  • ☐ Code review from 1 Drupal core team member
  • ☐ Full testing and approval
  • ☐ Credit contributors
  • ☐ Review with the product owner
  • ☐ Release

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork project_browser-3282700

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

hooroomoo created an issue. See original summary.

srishtiiee made their first commit to this issue’s fork.

srishtiiee opened merge request !127

srishtiiee’s picture

srishtiiee commented
Status: Active » Needs review
narendrar’s picture

narendrar
He/Him
Primary language English
Location Jaipur, India
commented
Status: Needs review » Needs work
srishtiiee’s picture

srishtiiee commented
Status: Needs work » Needs review
narendrar’s picture

narendrar
He/Him
Primary language English
Location Jaipur, India
commented
Status: Needs review » Reviewed & tested by the community
bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented
Status: Reviewed & tested by the community » Needs work

Good call on wrapping this in a fieldset! I left a comment in the MR of an optimization, but overall this looks good.

bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented
Title: Moving to categories checkbox by tab does not let the user know what it is for » Categories checkboxes are not logically grouped together
Issue summary: View changes
bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented
Issue tags: +Project Browser MVP
srishtiiee’s picture

srishtiiee commented
Status: Needs work » Needs review
bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented
Status: Needs review » Needs work

This is already good work, but I found an additional optimization that will reduce the amount of markup and styling needed. I commented in the MR.

srishtiiee’s picture

srishtiiee commented
Status: Needs work » Needs review
bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented
Status: Needs review » Needs work

Left comment in MR - small change needed to ensure the logical grouping also works on mobile.

srishtiiee’s picture

srishtiiee commented
Status: Needs work » Needs review
fjgarlin’s picture

fjgarlin commented
Status: Needs review » Reviewed & tested by the community

Checked the code and tested. All functionality remains the same and the categories are now inside a fieldset element. Marking RTBC.

  • bnjmnm committed b526200 on 1.0.x authored by srishtiiee 
    Issue #3282700 by srishtiiee, narendraR, hooroomoo, fjgarlin: Categories...
bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented
Status: Reviewed & tested by the community » Fixed

Looks good!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.