Agenda items
Standing items
- Who is here
- Any other suggested topics
- Wins / Thanks / Blockers
- Statistics and functionality update. X new bugs created in last two weeks. Y closed by the initiative.
- The bug I would most like to see fixed
- Update on target items from last meeting
- What should be the initiative focus for the next 2 weeks?
Statistics
0️⃣ Who is here today? Comment in the thread to introduce yourself. We’ll keep the meeting open for 24 hours to allow for all timezones.
| quietone | Hi |
| larowlan | lee, sorry late :sad-panda: |
| ambermatz | Hi, Amber, Portland, OR |
| Kristen Pol (she/her) | Kristen, California |
| lendude | Len, Amsterdam |
| Tinto | Hi from Amsterdam, The Netherlands :wave: |
| dipakmdhrm | Dipak, Pune, India :wave::skin-tone-5: |
| dww | Derek from TEN7, temporarily back in the SF Bay Area, CA, US (to do some live duet concerts and see family/friends). |
| jibran | Jibran, AU |
0️⃣.5️⃣ What are you looking forward to with the change in seasons?
| quietone | That it will force me to knit myself a new hat. |
| larowlan | getting more sleep |
| darvanen | Hopefully a little skiing |
| ambermatz | going camping |
| Kristen Pol (she/her) | summer fog keeps things cool on the coast |
| lendude | I love the point where the tree in front of our house, in a very short period of time, explodes with leaves and blocks the view of the concrete and steel skyline of Amsterdam and all we can see is green instead of grey when looking out the living room window |
| Tinto | Longer daylight! |
| dipakmdhrm | Monsoon is coming! It's going to be gloomy, but at least a little cooler. Summer was :hot_face: |
| dww | Excited for summer music camp season up on this side of the globe, although the pandemic (and a host of other global crises, really) continues to make that challenging and uncertain.(Aside: I love how "change in seasons" means so many different things to the folks participating in this meeting.) |
1️⃣ Do you have suggested topics you are looking to discuss? Post in this thread and we’ll open threads for them as appropriate.
| quietone | Would it make sense to have an issue of the day, say 12 hours after the current one to suit more timezones. |
| Kristen Pol (she/her) | https://drupal.slack.com/archives/C03FH8GTB1A/p1654576621772299 |
| Kristen Pol (she/her) | I've scheduled it to be after the bugsmash meeting for anyone that wants to spillover :wink: (edited) |
| ambermatz | Are folks finding any gaps in the triage and comment template documentation? For example, @quietone added a section on “committed but reopened” last week. |
2️⃣.1️⃣ Wins - what wins have you had since the last meeting? Share your successes!
| quietone | Went through the postponed bugs, only to see if any can be un-postponed. Found a few and then a 7 and 9 yr were closed an hour later by Berdir. |
| Kristen Pol (she/her) | Did some triage and it was nice to close some things :slightly_smiling_face: |
| Tinto | Wrote my first patch for a Drupal 10 issue and it passed automated tests :dancercarlton: |
| dww | Glad to have helped smash another major #accessibility bug since the last meeting: #3227431: Tabledrag icon doesn't adapt to forced-colors mode |
2️⃣.2️⃣ Thanks - a space for callouts to other contributors who’ve helped you
| ambermatz | Thanks @quietone for answering questions, adding docs, and just being an awesome person to contribute with. |
| Tinto | Thanks @Gábor Hojtsy (he/him) for being everywhere at once and recognizing even the small contributions, @quietone for explaining things I don't understand and @lendude for figuring out why my tests fail. :pray: (edited) |
| dww | Thanks @Kristen Pol (she/her) for spearheading the #contribution-events effort. |
| dww | Thanks @quietone for getting #coding-standards going again. I'm guessing we will notice some bugs in the code we're going to end up touching. :wink: |
2️⃣.3️⃣ Blockers - what’s getting in the way of your issues / goals
| larowlan | v/ busy again at work and in spare time |
| Kristen Pol (she/her) | Split between 3 different initiatives makes balancing tricky |
| lendude | Work stuff |
| Tinto | Client projects |
| dww | The usual stuff, plus performing/producing some live music shows this Friday (Santa Rosa, CA) and Sunday (Oakland, CA) is happily taking a lot of my time and attention. |
2️⃣.4️⃣ :loudspeaker: If you helped with the triage since the last meeting then don't forget to post a comment to triage issue on d.o.
| larowlan | #3282188: [Meta] Bug Smash Initiative triage fortnight commencing 2022-05-24 |
| Tinto | I think the previous meta is ready to be closed now?#3280028: [Meta] Bug Smash Initiative triage fortnight commencing 2022-05-10 |
2️⃣.5️⃣ Approve last fortnight's minutes
| larowlan | #3277586: Meeting of the Bug Smash Initiative 2022-05-10 |
| larowlan | #3279816: Meeting of the Bug Smash Initiative 2022-05-24 |
| Kristen Pol (she/her) | Maybe this is documented, but what are we looking for to approve the minutes? |
| Tinto | Sometimes not all meeting participants are listed with their Drupal.org usernames. I guess we want to make sure everyone is credited. |
| dww | For extra credit, you can scroll back up to the meeting in Slack in 1 window, and compare with the issue to make sure the scraper script didn't botch anything in any of the threads... |
| dww | But I don't always go to that much trouble. :wink: |
3️⃣ Core bug statistics - current state of open bugs
| quietone | Today: 2022-06-07
From: 2022-05-24 to 2022-06-07 All bugs Status Count Approximately 263 yr reduction in total number of years of all open bugs. Only bugs tagged Bug Smash Initiative Status Count Approximately 236 yr reduction in total number of years of all open bugs. |
| quietone | Also under 6500 bugs in D9/10 Displaying 1 - 50 of 6497 |
| larowlan | That's a nice milestone |
| quietone | Priority (goal): actual
|
| dww | Wow, this is fabulous! Great work, everyone. It seemed like I barely had any time to contribute at all the last few weeks. It's lovely to see the stats this good, anyway. :heart_eyes: Filled with the collective joy of being part of something bigger than individuals. :heartpulse: |
4️⃣ Lets check back on our targets and set some new ones
| larowlan | :dart: critical #1863258: Move entity preparation from form controller to entity class: "last changed" timestamp not updated and "create new revision" setting not respected when updating entities via Entity API |
| larowlan | :checkbox: major #2620346: Logic Exception with preview button for block-comment |
| larowlan | :checkbox: normal #2907995: Views UI sometimes fails to set overridden display to "All displays" |
| larowlan | :checkbox: normal #2470489: NodeRevisionDeleteForm::submitForm() has a SQL query and is not checking access on redirect |
| larowlan | :dart: critical #3265868: MySQL sql_require_primary_key variable prevents primary keys from being dropped |
| quietone | Summary of the above:Critical - both waiting on triageMajor - closed (cannot reproduce)Normal - NW and NR |
| dww | 1863258 is still a critical bug. We have catch saying it's worth changing default behavior for (#15) and xjm escalating to critical as a data integrity bug (#34), and \Drupal\Core\Entity\ContentEntityForm is still the home of buildEntity() , updateChangedTime() and friends, which is what the bug seeks to change. |
| dww | Given that 3265868 was opened by catch a few months ago, I see no reason to doubt that it is a critical bug. :wink:I'm following all 4 open targets now, and I think we can consider the criticals triaged.Do we want to grab another random major to set 5 targets again? (edited) |
| quietone | I'll do the new randoms that after lunch. |
| quietone | Fortnightly issues (at top of page) updated. |
5️⃣ Help me - Is there anything you could use a :hand:
6️⃣ Let's look back at progress closing PMNMI issues that we are now eligible
| ambermatz | Meaning the ones 3+ months since our last comment? |
| Kristen Pol (she/her) | I think I might have been doing this wrong.If something was marked PMNMI a year ago, I was closing it if it didn't look like it could be reproduced (either lack of instructions or someone tried and couldn't reproduce).But then I saw an issue where @quietone gave 3 months for someone to add more info.Maybe this is clear in the docs and I need to relook... I was just copy/pasting from a template :) |
| dww | Yeah, I thought there's a somewhat elaborate process we're trying to move PMNMI issues through, although I can't find it documented anywhere. :sweat_smile: Maybe @quietone knows where it lives? Let's cross link it from a few other spots like https://www.drupal.org/docs/develop/issues/issue-procedures-and-etiquette, perhaps under https://www.drupal.org/docs/develop/issues/issue-procedures-and-etiquett... , and/or at https://www.drupal.org/community-initiatives/bug-smash-initiative/issue-... ? |
| quietone | What we have so far is, https://www.drupal.org/community-initiatives/bug-smash-initiative/issue-.... I just skimmed it and I think it needs some updating. I don't see that it covers what happens when you find a PMNMI that has the 3 month notice and it is passed the 3 months. |
| dww | Okay, so it's just the 1 template on that page. I was confused... |
7️⃣ Would it make sense to have an issue of the day, say 12 hours after the current one to suit more timezones via quietone
| larowlan | That's a good idea, I can do that easily enough, it's just a reminder |
| quietone | Will the script produce 2 different issues in 24 hours? |
| larowlan | I don't think so, but we could make the second message say 'click send me to a random issue'? |
| larowlan | or perhaps Len could add a second link? |
| quietone | I like the less work option of adjusting the message. |
| ambermatz | I like the idea |
| lendude | I can just pad the seeding string (which is now the current day) with something like AM or PM, that should give us 2 targets each dayEasypeasy :woman-shrugging: |
| dww | Yay, thanks! Glad folks are open to double the triage fun, and that it was so easy to add 2 random targets a day. |
| lendude | Done, see https://lendude.gitlab.io/bug-smash-initiative/I went for the ‘first’ and ‘second’ prefix in the link , did ‘morning’ and ‘afternoon’ first but than figured that wouldn’t work for all the time zones :smile: |
Participants:
quietone, larowlan, darvanen, ambermatz, Kristen Pol, lendude, Tinto, dipakmdhrm, dww
Comments
Comment #2
griffynh commentedComment #8
larowlanComment #12
larowlanComment #13
quietone commentedThe practice in bugsmash is to give credit for active participation in the discussion, right? If so , I think credit should be modified.
Small formatting change to minutes.
Comment #14
darvanenI agree, I for one, don't deserve credit for this meeting.
Comment #15
larowlanThanks, removing credit
Comment #16
griffynh commented