Problem/Motivation

I'm implementing an ECK integration for the 2.x branch of this module and I noticed the module is still assuming the entity to implement EntityChangedInterface.

Steps to reproduce

Enable scheduling on an ECK entity without changed field

Proposed resolution

Check whether the entity implements EntityChangedInterface before trying to change the changed date.

Issue fork scheduler-3282068

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

DieterHolvoet created an issue. See original summary.

DieterHolvoet opened merge request !43

dieterholvoet’s picture

dieterholvoet commented
Status: Active » Needs review
jonathan1055’s picture

jonathan1055 commented
Category: Bug report » Feature request
Related issues: +#3282071: Add support for entities without label_collection key

Thanks, this is useful. Can you fix the coding standard error please?

Also, should we try to add test coverage for this? How much work would it be to create a ECK entity in our testbase and then use it on selective tests (not all tests, but the ones in which relevent to the code changes in these two issues).

dieterholvoet’s picture

dieterholvoet commented

Well, I was planning on creating a new project for the ECK integration, but if you want I can create a MR on the main project. If not, I think we would have to add the separate integration as a test dependency to the main project in order to use ECK entities in tests.

jonathan1055’s picture

jonathan1055 commented

I was planning on creating a new project for the ECK integration

That sounds like a good idea. When that is done, we can add the new module as a test dependency and create some extra tests.

jonathan1055’s picture

jonathan1055 commented
Status: Needs review » Fixed

Committed. Thank you for providing these enhancements, and #3282982: Simplify the scheduler plugin implementations

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.