Problem/Motivation

I'm implementing an ECK integration for the 2.x branch of this module and I noticed the module requires entities to have a label_collection key, in order to show the entity type label on the admin form.

Steps to reproduce

Create an ECK entity type and visit the admin form.

Proposed resolution

Fall back to the more common label key in case the label_collection key does not exist.

Issue fork scheduler-3282071

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

DieterHolvoet created an issue. See original summary.

DieterHolvoet opened merge request !44

dieterholvoet’s picture

dieterholvoet commented
Status: Active » Needs review
jonathan1055’s picture

jonathan1055 commented
Category: Bug report » Feature request

Thanks DieterHolvoet, this looks helpful.

jonathan1055’s picture

jonathan1055 commented
Status: Needs review » Fixed

Thanks. Committed. All seems fine for the entity types we currently support, which all have 'label_collection' key. When this, and the other similar issues are all in, we can look at expanding the test coverage to use a test ECK entity type via your new module.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.