Problem/Motivation

Drupal config inspector reports error about missing schema for h5p.settings:h5p_site_type and h5p.settings:h5p_first_runnable_saved

Proposed resolution

Provide proper schema definition for these keys

CommentFileSizeAuthor
#4 h5p-config-schema-3281878-4.patch424 bytesshaundychko
#2 h5p-3281878-2.patch463 bytessorlov

Issue fork h5p-3281878

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

sorlov created an issue. See original summary.

sorlov’s picture

sorlov commented
Status: Active » Needs review
StatusFileSize
new h5p-3281878-2.patch463 bytes
sokru’s picture

sokru commented
Status: Needs review » Reviewed & tested by the community

Tested to work and looks good.

shaundychko’s picture

shaundychko
Location Vancouver, Canada
commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new h5p-config-schema-3281878-4.patch424 bytes

`h5p_site_type` no longer exists and was removed here: https://git.drupalcode.org/project/h5p/-/commit/78c2fba9f9c8c0a02e9c7e15...
The updated patch adds only h5p_first_runnable_saved.

shaundychko’s picture

shaundychko
Location Vancouver, Canada
commented
Version: 2.0.0-alpha2 » 2.0.x-dev
maya maier’s picture

maya maier
she/her
Primary language English
commented
Assigned: Unassigned » maya maier
maya maier’s picture

maya maier
she/her
Primary language English
commented

Confirmed that #4's patch fixes the h5p.settings:h5p_first_runnable_saved error, but the h5p.settings:h5p_site_type error still appears after uninstalling & installing h5p@2.0.x. Is it certain that it should no longer be in the config?

maya maier’s picture

maya maier
she/her
Primary language English
commented
Status: Needs review » Needs work
maya maier’s picture

maya maier
she/her
Primary language English
commented

I see there are $this->h5pF->setOption('site_type' calls still in h5p.classes.php, if that's where they're coming from.

maya maier’s picture

maya maier
she/her
Primary language English
commented
Assigned: maya maier » Unassigned
Status: Needs work » Needs review

Added h5p.settings:h5p_site_type schema, it's still added by h5p-core. Ready for review.

maya maier opened merge request !45

msandoval’s picture

msandoval commented
Status: Needs review » Reviewed & tested by the community

Confirmed, these changes remove the errors seen from Config Inspector.

sim_1 made their first commit to this issue’s fork.

  • sim_1 committed 05667c2f on 2.0.x authored by maya maier 
    [#3281878] fix: Fix config definition h5p.settings

By: sorlov
By: sokru...
sim_1’s picture

sim_1
she/her
commented
Status: Reviewed & tested by the community » Fixed

Merged and marking as fixed. Thanks, everyone!

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.