Problem/Motivation
There are several references to Bartik and Seven:
2 core/tests/Drupal/KernelTests/Core/Asset/ResolvedLibraryDefinitionsFilesMatchTest.php
1 core/tests/Drupal/KernelTests/Core/Config/ConfigImporterTest.php
1 core/tests/Drupal/KernelTests/Core/Config/DefaultConfigTest.php
4 core/tests/Drupal/KernelTests/Core/Theme/ConfirmClassyCopiesTest.php
3 core/tests/Drupal/KernelTests/Core/Theme/ThemeInstallerTest.php
These tests should be updated to either use Olivero, Claro, or System module's test_theme so we can deprecate Bartik #3249109: Deprecate Bartik and Seven #3084814: Deprecate Seven theme as mentioned at #3278124: Convert various tests that use bartik/seven to olivero/claro.
Steps to reproduce
git grep -E '(bartik)|(seven)' -- 'core/tests/Drupal/KernelTests/Core/' | awk -F: '{print $1}' | sort | uniq -c
should return no results when this work is complete, except for ResolvedLibraryDefinitionsFilesMatchTest
and ConfirmClassyCopiesTest
.
Remaining tasks
Update the tests.
User interface changes
None.
API changes
None.
Data model changes
None.
Release notes snippet
I don't think we need release notes or a change record.
Comment | File | Size | Author |
---|---|---|---|
#10 | 3281452-10.patch | 6.11 KB | mrinalini9 |
| |||
#2 | 3281452-2.patch | 6.11 KB | longwave |
|
Comments
Comment #2
longwaveThese references must remain:
ResolvedLibraryDefinitionsFilesMatchTest tests all core themes via a hardcoded list. ConfirmClassyCopiesTest ensures templates are correctly copied. Both tests need to stay as-is until the themes are removed.
DefaultConfigTest manually installed Seven before, but the test passes without it. There is a comment that says "If a theme provides default configuration but does not have a schema then this test needs to enable it" but Seven has a config schema so I guess this is no longer needed.
Comment #3
deviantintegral CreditAttribution: deviantintegral at Lullabot commentedYou're finding some nice test debt! 🙌
I'm going to update the issue to mark the exceptions you found. Otherwise, the diff looks good to me.
Comment #4
deviantintegral CreditAttribution: deviantintegral at Lullabot commentedComment #5
deviantintegral CreditAttribution: deviantintegral at Lullabot commentedComment #7
daffie CreditAttribution: daffie commentedAssign this issue to the parent #3285205: [META] Convert test that use Bartik/Seven to Olivero/Claro.
Comment #8
deviantintegral CreditAttribution: deviantintegral at Lullabot commentedI'm skeptical about the test failures unless we have some surprising cross-test dependencies. Requeued!
Comment #9
SpokjeThis one needs a 9.4.x/9.5.x patch currently, otherwise looks grand.
Comment #10
mrinalini9 CreditAttribution: mrinalini9 at Srijan | A Material+ Company for Drupal India Association commentedRerolled patch #2 for the 9.5.x branch, please review it.
Comment #11
SpokjeLGTM, changed version to
9.4.x-dev
, since related issues were all backported as far as that branch because it being a "test only change".Comment #15
lauriiiCommitted 4411770 and pushed to 10.1.x. Cherry-picked to 10.0.x and 9.5.x. Thanks!