Problem/Motivation

See the parent issue for all the tasks that are needed to deprecate Bartik.

Steps to reproduce

Proposed resolution

Remaining tasks

Work on the patch is postponed on #3278124: Convert various tests that use bartik/seven to olivero/claro but there is other work that can be done.

  1. Create a section on Deprecated and obsolete themes and themes to provide recommendations for sites using theme Bartik. The recommendation are to include instructions for sites using Bartik and for contributed themes that depend on Bartik.
  2. Set lifecycle to deprecated.
  3. Set lifecylcle_link to the section added above, https://www.drupal.org/node//3223395#s-Bartik.
  4. The change record for this issue includes a link to the doc page.

User interface changes

API changes

Data model changes

Release notes snippet

The Bartik theme has been deprecated in Drupal 9.5.0 and will be removed in Drupal 10.0.0. Drupal 9.4 introduced a new default theme, Olivero.

If you want to keep using the Bartik theme, read the change record for more information.

CommentFileSizeAuthor
#11 3249109-11.patch900 bytescatch
#3 3249109.patch482 bytescatch

Comments

catch created an issue. See original summary.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

catch’s picture

catch
he/him
Primary language English
commented
Title: [PP1] Deprecate Bartik in core once Olivero is the default theme » Deprecate Bartik in core once Olivero is the default theme
Status: Active » Needs review
StatusFileSize
new 3249109.patch482 bytes

Trying a patch.

Status: Needs review » Needs work

The last submitted patch, 3: 3249109.patch, failed testing. View results

catch’s picture

catch
he/him
Primary language English
commented
Related issues: +#3278124: Convert various tests that use bartik/seven to olivero/claro

Postponing on #3278124: Convert various tests that use bartik/seven to olivero/claro.

catch’s picture

catch
he/him
Primary language English
commented
Title: Deprecate Bartik in core once Olivero is the default theme » [PP-1] Deprecate Bartik in core once Olivero is the default theme
Status: Needs work » Postponed
quietone’s picture

quietone commented
Title: [PP-1] Deprecate Bartik in core once Olivero is the default theme » Deprecate Bartik in core once Olivero is the default theme
Issue summary: View changes
Issue tags: +Needs change record
Parent issue: #3118154: [meta] Deprecate dependencies, libraries, modules, and themes that will be removed from Drupal 10 core by 9.4.0-beta1 » #3278213: [Meta] Tasks to deprecate Bartik

Updating the issue and parent according to the developing policy on deprecating modules and themes.

Removing the postponed because the task "a section on Deprecated and obsolete themes and themes" can be worked on as well as adding a change record.

quietone’s picture

quietone commented
Status: Postponed » Needs work

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

catch’s picture

catch
he/him
Primary language English
commented
Title: Deprecate Bartik in core once Olivero is the default theme » Deprecate Bartik
catch’s picture

catch
he/him
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new 3249109-11.patch900 bytes
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs change record

Reviewed and added a change record similar to how seven wrote theirs.

quietone’s picture

quietone commented
Status: Reviewed & tested by the community » Needs work

@smustgrave, thanks for creating the change record.

This also needs work for documentation at https://www.drupal.org/node/3223395#s-bartik. That step is not listed in the issue summary, maybe the policy needs to add this step?

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs work » Needs review

Updated the documentation: https://www.drupal.org/docs/core-modules-and-themes/deprecated-and-obsolete

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Verified I'm seeing bartik on the documentation page. Moving back to RTBC

quietone’s picture

quietone commented

@catch, thanks.

I read the Bartik and Seven sections on the wiki page and checked the links. Claro was pointing to Olivero so I changed that.

I read the change record and updated that according to policy to have a link to the wiki page. and I tested the link.

I agree with the RTBC.

dww’s picture

dww
we/he/they
commented

FWIW, I also reviewed patch #11 (totally clean and fine) and the draft CR (needed a tiny edit). $RTBC++;

lauriii credited Gábor Hojtsy.

lauriii credited xjm.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Issue summary: View changes
Issue tags: +Needs product manager review

Reviewed the Bartik contrib theme and discovered major bug. Since I'm the maintainer of that project, I fixed it with @Wim Leers and tagged a new release.

I also updated the change record. That was created in collaboration with @Gábor Hojtsy and @xjm.

Added draft release note to the issue summary.

I can't find product manager sign-off anywhere for deprecation of Bartik so tagging this for product manager review.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Issue tags: -Needs product manager review

I am a core product manager and fully on board to deprecate and remove Bartik. I thought I signed off on this earlier somewhere but could not find it now. Let's do this!

  • lauriii committed a58a9b0 on 10.1.x 
    Issue #3249109 by catch, quietone, Gábor Hojtsy, smustgrave, dww, xjm:...

  • lauriii committed ba3edc8 on 10.0.x 
    Issue #3249109 by catch, quietone, Gábor Hojtsy, smustgrave, dww, xjm:...

  • lauriii committed a34b54d on 9.5.x 
    Issue #3249109 by catch, quietone, Gábor Hojtsy, smustgrave, dww, xjm:...
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Reviewed & tested by the community » Fixed

Committed a58a9b0 and pushed to 10.1.x. Cherry-picked to 10.0.x and 9.5.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

quietone’s picture

quietone commented

Added a CR specific for the deprecation, so the branch/version information is correct, and published it.