Closed (fixed)
Project:
Drupal core
Version:
10.0.x-dev
Component:
base system
Priority:
Major
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
11 Jun 2022 at 09:46 UTC
Updated:
31 Aug 2022 at 09:04 UTC
Jump to comment: Most recent
We want to deprecate and remove the themes bartik and seven from Drupal core. For this all tests in core that are using the themes Bartik and/or Seven need to switch to using Olivero and/or Claro.
Done:
- #3281434: Update System module tests to not use Bartik and Seven
- #3281439: Update Help Topics tests to not use Bartik and Seven
- #3281438: Update CKEditorTest to not use Bartik and Seven
- #3281443: Update Taxonomy tests to not use Bartik and Seven
- #3281451: Update Ajax FunctionalJavascript test to not use Bartik and Seven
- #3281452: Update Core kernel tests to not use Bartik and Seven
- #3281454: Update various module tests to not use Bartik and Seven
- #3281440: Update Shortcut tests to not use Bartik and Seven
- #3278124: Convert various tests that use bartik/seven to olivero/claro
- #3281449: Update Core unit tests to not use Bartik and Seven
- #3281429: Update Block non-Migration tests to not use Bartik and Seven
- #3295735: Fix ConfigImportUITest with olivero
- #3281427: Update Block and Theme setting migrations to not use Bartik and Seven
- #3298319: Update ExtensionDiscoveryTest to not use seven
- #3281444: Update Installer tests to not use Bartik and Seven
- #3281441: Update Settings Tray tests to not use Bartik and Seven
- #3281430: Update non-migration Color tests to not use Bartik
- Also a number of specific Bartik and Seven tests need to be moved to the Bartik or Seven theme. We have #3281457: Move Seven and Bartik tests in the core FunctionalTests\Theme namespace to their respective themes.
- #3302800: Core tests need to filter out deprecated themes when looping over all themes
Follow-ups:
- #3280049: Create a test admin and front end theme
- #3301713: Update migration Color tests to not use Bartik - nod_ confirmed in #7 of that issue, that olivero does not use color so MigrateColorTest.php, now @legacy, will continue to use bartik.
Comments
Comment #2
quietone commentedThanks @daffie.
Let's make this a child of the issue tracking all the module and theme removals, #3213858: [META] Remove deprecated modules and themes from the Drupal 10 branch
Comment #3
lauriiiAdding separate list for completed issues.
Comment #4
lauriiiComment #5
nod_Comment #6
nod_oups :)
Comment #7
lauriiiMarking #3281440: Update Shortcut tests to not use Bartik and Seven and #3281454: Update various module tests to not use Bartik and Seven as done 🎉
Comment #8
nod_Comment #9
lauriiiMarking #3278124: Convert various tests that use bartik/seven to olivero/claro as done.
Comment #10
lauriiiComment #11
nod_tweak the order to make the 2 that blocks a few other issues first
Comment #12
lauriiiComment #13
nod_Comment #14
nod_Comment #15
nod_moved the wrong issue :p
Comment #16
tinto#3281429: Update Block non-Migration tests to not use Bartik and Seven is ready to be reviewed.
Comment #17
catchComment #18
catchComment #19
lauriiiShould we move #3280049: Create a test admin and front end theme to a separate section since I assume it's not a hard requirement?
Comment #20
lauriiiComment #21
catchComment #22
catchComment #23
nod_refreshing issue status
Comment #24
nod_Comment #25
nod_Added #3301713: Update migration Color tests to not use Bartik to the child issues, maybe it's just a followup?
Comment #26
nod_Comment #27
nod_Comment #28
nod_Comment #29
nod_Comment #30
nod_Comment #31
catchThere are some generic tests that fail if any core theme is deprecated: #3302800: Core tests need to filter out deprecated themes when looping over all themes
Comment #32
quietone commentedComment #33
quietone commentedMove comment to correct issue.
Comment #34
catchOne left.
Comment #35
nod_last one is RTBC :)
Comment #36
catchCommitted! I think we're done!
Comment #37
nod_:D