Problem/Motivation

There are several tests that have references to Bartik and Seven:

   7 core/modules/shortcut/tests/src/Functional/ShortcutLinksTest.php
   5 core/modules/shortcut/tests/src/Kernel/ShortcutSevenIntegrationTest.php

These tests should be updated to either use Olivero, Claro, or System module's test_theme so we can deprecate Bartik #3249109: Deprecate Bartik and Seven #3084814: Deprecate Seven theme as mentioned at #3278124: Convert various tests that use bartik/seven to olivero/claro.

Steps to reproduce

git grep -E '(bartik)|(seven)' -- 'core/modules/shortcut/tests' | awk -F: '{print $1}' | sort | uniq -c should return no results when this work is complete.

Remaining tasks

Update the tests.

User interface changes

None.

API changes

None.

Data model changes

None.

Release notes snippet

I don't think we need release notes or a change record.

CommentFileSizeAuthor
#2 3281440-2.patch4.4 KB_shy

Comments

deviantintegral created an issue. See original summary.

_shy’s picture

Status: Active » Needs review
StatusFileSize
new4.4 KB

Replaced references for the Seven theme (not found any references for the Bartik theme).

nod_’s picture

Status: Needs review » Reviewed & tested by the community

no more seven/bartik in shortcut tests :)

looks like it applies to 9.5 too, RTBC

  • lauriii committed 02656d5 on 10.1.x
    Issue #3281440 by _shY, nod_: Update Shortcut tests to not use Bartik...

  • lauriii committed 4d6ae45 on 10.0.x
    Issue #3281440 by _shY, nod_: Update Shortcut tests to not use Bartik...

  • lauriii committed 3a2ddfe on 9.5.x
    Issue #3281440 by _shY, nod_: Update Shortcut tests to not use Bartik...
lauriii’s picture

Version: 10.0.x-dev » 9.5.x-dev
Status: Reviewed & tested by the community » Fixed

Committed 02656d5 and pushed to 10.1.x. Also cherry-picked to 10.0.x and 9.5.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.