Update Help Topics tests to not use Bartik and Seven

Replaced references to the Seven and Bartik.

Reworked patch. Correction for the warning message, seems like for the Claro theme they a bit different.

@_shY just a tip for you. It's always a good practice to provide an interdiff between the new patch and the last one so other developers can see clearly what you changed in the code. :)

This is what I discovered so far about this issue.

By using the new themes, the element's markup gets completely different and this is part or the reason why the HelpTopicSearchTest.php is failing.
Checking the code and the pages' HTML from inside the tests, I noticed that when we use the method statusMessageContains('some text', 'warning'); it internally calls for buildStatusMessageSelector() that creates a selector like //div[@data-drupal-messages]//div[contains(@aria-label, "Warning message") (you can see an image of the selector builder attached).

The problem is not that the warning message is different with the new themes, but the warning element markup is different (image attached) and because statusMessageContains() internally uses a predetermined xpath selector this method can't find the selector. Fortunately we still can check for the warning message by another way, like by replacing

$this->assertSession()->statusMessageContains('Help search is not fully indexed', 'warning');

with

$this->assertSession()->elementTextContains('xpath', '//div[@data-drupal-messages]//div[contains(@aria-labelledby, "message-warning-title")]', 'Help search is not fully indexed');

It would be nice if that was the only problem (replacing the statusMessageContains() methods), but another problem I found is that the search/help page looses the search field with the provided patch (image attached), and I wasn't able to fix this.

This is a partial patch that fixes the setUp() method and 2 of the 3 tests in HelpTopicSearchTest.php. It still needs work for the testHelpSearch() though.

Assign this issue to the parent #3285205: [META] Convert test that use Bartik/Seven to Olivero/Claro.

added a comment on the MR + needs a reroll

Hiding now outdated patch files.

Works for me :) thanks

Need to fix the 9.5 test failures :/

Missing file in the d9.5 patch, hang on.

all good, thanks :)

+++ b/core/modules/help_topics/tests/src/Functional/HelpTopicSearchTest.php
@@ -68,7 +68,7 @@ protected function setUp(): void {
-    $this->assertSession()->statusMessageContains('Help search is not fully indexed', 'warning');
+    $this->assertSession()->statusMessageContains('Help search is not fully indexed');

@@ -261,7 +261,7 @@ public function testUninstall() {
-    $this->assertSession()->statusMessageContains('The selected modules have been uninstalled.', 'status');
+    $this->assertSession()->statusMessageContains('The selected modules have been uninstalled.');

@@ -278,7 +278,7 @@ public function testUninstallSearch() {
-    $this->assertSession()->statusMessageContains('The selected modules have been uninstalled.', 'status');
+    $this->assertSession()->statusMessageContains('The selected modules have been uninstalled.');

Removing the status message type essentially leads into lost test coverage. I think we need to update \Drupal\Tests\WebAssert::buildStatusMessageSelector so that it works with Claro 😬

updated the 10.x branch to fix the buildStatusMessageSelector method to work with claro

Added a comment

Verified merge request for Drupal 9.5.x dev version
https://git.drupalcode.org/project/drupal/-/merge_requests/2476

Testing Steps:
* Install a new Drupal instance
* Add & fetch this issue fork’s repository using
git remote add drupal-3281439 git@git.drupal.org:issue/drupal-3281439.git
git fetch drupal-3281439
* Switch to that branch
git checkout 3281439-update-help-topics
* Clear all catches
* Run git grep -E '(bartik)|(seven)' -- 'core/modules/help_topics/tests' | awk -F: '{print $1}' | sort | uniq -c

Test Result:
This git command return nothing which is expected behaviour
Refer SS

MR result Pass.
Can be move to RTBC.

Posted some feedback on the MR.

adressed feedback, should still be green but waiting on what testbot says.

@aarti zikre DrupalCI already indicates whether the MR applies or not, to set something RTBC you should also indicate that you've read the code and that it looks OK. Additionally there's no need to provide a screenshot of command line output. I've removed commit credit for this issue but hopefully it will help for the next one.

Committed/pushed to 10.1.x, cherry-picked to 10.0.x and 9.5.x, thanks!